ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-08-21 22:30:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: clean up VaultHelpers

Browse Source
This commit is contained in:
Vito
2026-08-13 14:08:14 +02:00
parent c57709b17a
commit 840a41f880
1 changed files with 40 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

90
src/libxrpl/ledger/helpers/VaultHelpers.cpp
View File

@@ -27,6 +27,45 @@
#include <utility>
namespace xrpl {
namespace {
// Applies a full-removal mutation to the Vault's ledger fields: both
// callers (clawbackVaultAssets and removeVaultAssets) apply `amount` to
// sfAssetsTotal and sfAssetsAvailable equally (unlike
// addVaultAssets/moveVaultAssets, a full removal always shrinks both fields
// by the same amount). On a final removal, both fields are hard-reset to
// exactly zero rather than computed via subtraction: see FinalRemoval's
// doc comment for why an arithmetic subtraction cannot be trusted to land
// on exactly zero here.
void
applyRemoveVaultAssets(
ApplyView& view,
SLE::ref vault,
STAmount const& amount,
FinalRemoval finalRemoval)
{
if (finalRemoval == FinalRemoval::Yes)
{
vault->at(sfAssetsTotal) = 0;
vault->at(sfAssetsAvailable) = 0;
}
else
{
vault->at(sfAssetsTotal) -= amount;
vault->at(sfAssetsAvailable) -= amount;
}
view.update(vault);
}
[[nodiscard]] VaultKind
decodeVaultKind(std::optional<std::uint8_t> vaultKind)
{
if (vaultKind && *vaultKind == std::to_underlying(VaultKind::ClosedEnded))
return VaultKind::ClosedEnded;
return VaultKind::OpenEnded;
}
} // namespace
[[nodiscard]] std::optional<STAmount>
assetsToSharesDeposit(SLE::const_ref vault, SLE::const_ref issuance, STAmount const& assets)
@@ -205,46 +244,9 @@ addVaultAssets(
vault->at(sfAssetsAvailable) += amount;
view.update(vault);
if (auto const ter =
accountSend(view, sender, vault->at(sfAccount), amount, j, {}, WaiveTransferFee::Yes);
!isTesSuccess(ter))
return ter;
return tesSUCCESS;
return accountSend(view, sender, vault->at(sfAccount), amount, j, {}, WaiveTransferFee::Yes);
}
namespace {
// Applies a full-removal mutation to the Vault's ledger fields: both
// callers (clawbackVaultAssets and removeVaultAssets) apply `amount` to
// sfAssetsTotal and sfAssetsAvailable equally (unlike
// addVaultAssets/moveVaultAssets, a full removal always shrinks both fields
// by the same amount). On a final removal, both fields are hard-reset to
// exactly zero rather than computed via subtraction: see FinalRemoval's
// doc comment for why an arithmetic subtraction cannot be trusted to land
// on exactly zero here.
void
applyRemoveVaultAssets(
ApplyView& view,
SLE::ref vault,
STAmount const& amount,
FinalRemoval finalRemoval)
{
if (finalRemoval == FinalRemoval::Yes)
{
vault->at(sfAssetsTotal) = 0;
vault->at(sfAssetsAvailable) = 0;
}
else
{
vault->at(sfAssetsTotal) -= amount;
vault->at(sfAssetsAvailable) -= amount;
}
view.update(vault);
}
} // namespace
[[nodiscard]] TER
clawbackVaultAssets(
ApplyView& view,
@@ -356,18 +358,6 @@ moveVaultAssets(
view, vault->at(sfAccount), asset, recipients, j, WaiveTransferFee::Yes);
}
namespace {
[[nodiscard]] VaultKind
decodeVaultKind(std::optional<std::uint8_t> vaultKind)
{
if (vaultKind && *vaultKind == std::to_underlying(VaultKind::ClosedEnded))
return VaultKind::ClosedEnded;
return VaultKind::OpenEnded;
}
} // namespace
[[nodiscard]] VaultKind
getVaultKind(SLE::const_ref vault)
{