ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-03 08:46:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Restore try-catch to protect against other exceptions

Browse Source
This commit is contained in:
Bart
2026-03-01 13:33:39 -05:00
parent f749c41306
commit 82db6ac498
1 changed files with 39 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

69
src/xrpld/app/ledger/detail/InboundLedger.cpp
View File

@@ -836,44 +836,53 @@ InboundLedger::receiveNode(protocol::TMLedgerData& packet, SHAMapAddNode& san)
mLedger->stateMap().family().db(), app_.getLedgerMaster())};
}();
auto const f = filter.get();
for (auto const& ledger_node : packet.nodes())
try
{
if (!validateLedgerNode(ledger_node))
{
JLOG(journal_.warn()) << "Got malformed ledger node";
san.incInvalid();
return;
}
auto const f = filter.get();
auto treeNode = getTreeNode(ledger_node.nodedata());
if (!treeNode)
for (auto const& ledger_node : packet.nodes())
{
JLOG(journal_.warn()) << "Got invalid node data";
san.incInvalid();
return;
}
if (!validateLedgerNode(ledger_node))
{
JLOG(journal_.warn()) << "Got malformed ledger node";
san.incInvalid();
return;
}
auto const nodeID = getSHAMapNodeID(ledger_node, *treeNode);
if (!nodeID)
{
JLOG(journal_.warn()) << "Got invalid node id";
san.incInvalid();
return;
}
auto treeNode = getTreeNode(ledger_node.nodedata());
if (!treeNode)
{
JLOG(journal_.warn()) << "Got invalid node data";
san.incInvalid();
return;
}
if (nodeID->isRoot())
san += map.addRootNode(rootHash, std::move(*treeNode), f);
else
san += map.addKnownNode(*nodeID, std::move(*treeNode), f);
auto const nodeID = getSHAMapNodeID(ledger_node, *treeNode);
if (!nodeID)
{
JLOG(journal_.warn()) << "Got invalid node id";
san.incInvalid();
return;
}
if (!san.isGood())
{
JLOG(journal_.warn()) << "Received bad node data";
return;
if (nodeID->isRoot())
san += map.addRootNode(rootHash, std::move(*treeNode), f);
else
san += map.addKnownNode(*nodeID, std::move(*treeNode), f);
if (!san.isGood())
{
JLOG(journal_.warn()) << "Received bad node data";
return;
}
}
}
catch (std::exception const& e)
{
JLOG(journal_.error()) << "Received bad node data: " << e.what();
san.incInvalid();
return;
}
if (!map.isSynching())
{