ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-11-20 11:05:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant check, add test

Browse Source 
There is no way to pass a non-object params to an RPC because it is
always prepared as an object inside ServerHandler.cpp
This commit is contained in:
Bronek Kozicki
2025-05-01 11:40:43 +01:00
parent 6c97d2ec7e
commit 7b680ed47b
2 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/test/app/Vault_test.cpp
View File

@@ -2228,6 +2228,16 @@ class Vault_test : public beast::unit_test::suite
jv[jss::result][jss::vault][jss::shares]); jv[jss::result][jss::vault][jss::shares]);
} }
{
testcase("RPC vault_info invalid vault_id");
Json::Value jvParams;
jvParams[jss::ledger_index] = jss::validated;
jvParams[jss::vault_id] = "foobar";
auto jv = env.rpc("json", "vault_info", to_string(jvParams));
BEAST_EXPECT(
jv[jss::result][jss::error].asString() == "malformedRequest");
}
{ {
testcase("RPC vault_info json invalid index"); testcase("RPC vault_info json invalid index");
Json::Value jvParams; Json::Value jvParams;

6
src/xrpld/rpc/handlers/VaultInfo.cpp
View File

@@ -32,12 +32,6 @@ namespace ripple {
static std::optional<uint256> static std::optional<uint256>
parseVault(Json::Value const& params, Json::Value& jvResult) parseVault(Json::Value const& params, Json::Value& jvResult)
{ {
if (!params.isObject())
{
jvResult[jss::error] = "malformedRequest";
return std::nullopt;
}
auto const hasVaultId = params.isMember(jss::vault_id); auto const hasVaultId = params.isMember(jss::vault_id);
auto const hasOwner = params.isMember(jss::owner); auto const hasOwner = params.isMember(jss::owner);
auto const hasSeq = params.isMember(jss::seq); auto const hasSeq = params.isMember(jss::seq);