diff --git a/src/test/app/Vault_test.cpp b/src/test/app/Vault_test.cpp index ac0df1702c..303235faf1 100644 --- a/src/test/app/Vault_test.cpp +++ b/src/test/app/Vault_test.cpp @@ -2228,6 +2228,16 @@ class Vault_test : public beast::unit_test::suite jv[jss::result][jss::vault][jss::shares]); } + { + testcase("RPC vault_info invalid vault_id"); + Json::Value jvParams; + jvParams[jss::ledger_index] = jss::validated; + jvParams[jss::vault_id] = "foobar"; + auto jv = env.rpc("json", "vault_info", to_string(jvParams)); + BEAST_EXPECT( + jv[jss::result][jss::error].asString() == "malformedRequest"); + } + { testcase("RPC vault_info json invalid index"); Json::Value jvParams; diff --git a/src/xrpld/rpc/handlers/VaultInfo.cpp b/src/xrpld/rpc/handlers/VaultInfo.cpp index 012ef6f980..244829149b 100644 --- a/src/xrpld/rpc/handlers/VaultInfo.cpp +++ b/src/xrpld/rpc/handlers/VaultInfo.cpp @@ -32,12 +32,6 @@ namespace ripple { static std::optional parseVault(Json::Value const& params, Json::Value& jvResult) { - if (!params.isObject()) - { - jvResult[jss::error] = "malformedRequest"; - return std::nullopt; - } - auto const hasVaultId = params.isMember(jss::vault_id); auto const hasOwner = params.isMember(jss::owner); auto const hasSeq = params.isMember(jss::seq);