ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-10-11 06:08:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(telemetry): Move the validation span into its job again

Browse Source 
The job closure copied the span holder, so with telemetry off nothing
modified it and clang-tidy's misc-const-correctness would fail. The
job takes the holder by move again. A const copy, statusSpan, keeps
the span open for the validation_receive_status write after addJob()
returns.
This commit is contained in:
Pratik Mankawde
2026-10-02 18:42:54 +01:00
parent 0b8bd1b274
commit 78906e5c5d
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/xrpld/overlay/detail/PeerImp.cpp
View File

@@ -2707,19 +2707,21 @@ PeerImp::onMessage(std::shared_ptr<protocol::TMValidation> const& m)
std::string const name = isTrusted ? "ChkTrust" : "ChkUntrust";
std::weak_ptr<PeerImp> const weak = shared_from_this();
// The job holds its own reference to the span. The span is still
// open when addJob() returns. validation_receive_status then
// records whether the job queue took the job. The job may already
// be running by then. The SDK span takes its lock for each
// attribute write.
// statusSpan keeps the span open after the job takes its own
// reference, so validation_receive_status can record whether the
// job queue took the job. The job may already be running by then.
// The SDK span takes its lock for each attribute write.
auto const statusSpan = span;
bool const queued = app_.getJobQueue().addJob(
isTrusted ? JtValidationT : JtValidationUt, name, [weak, val, m, key, sp = span]() {
isTrusted ? JtValidationT : JtValidationUt,
name,
[weak, val, m, key, sp = std::move(span)]() {
if (auto peer = weak.lock())
peer->checkValidation(val, key, m);
});
if (span && *span)
if (statusSpan && *statusSpan)
{
span->setAttribute(
statusSpan->setAttribute(
telemetry::consensus::span::attr::validationReceiveStatus,
queued ? std::string_view{telemetry::consensus::span::val::validationQueued}
: std::string_view{