ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-05 01:37:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Support sfSponsorSignature autofilling in Simulate RPC

Browse Source
This commit is contained in:
tequ
2025-10-07 16:02:02 +09:00
parent 32cc7825f2
commit 754f597078
2 changed files with 92 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

85
src/test/rpc/Simulate_test.cpp
View File

@@ -592,6 +592,91 @@ class Simulate_test : public beast::unit_test::suite
// test without autofill
testTx(env, tx, validateOutput);
}
{
// autofill sponsor signature
auto validateOutput = [&](Json::Value const& resp,
Json::Value const& tx) {
auto result = resp[jss::result];
checkBasicReturnValidity(
result, tx, 2, env.current()->fees().base);
BEAST_EXPECT(result[jss::engine_result] == "tesSUCCESS");
BEAST_EXPECT(result[jss::engine_result_code] == 0);
BEAST_EXPECT(
result[jss::engine_result_message] ==
"The simulated transaction would have been applied.");
if (BEAST_EXPECT(
result.isMember(jss::meta) ||
result.isMember(jss::meta_blob)))
{
Json::Value const metadata = getJsonMetadata(result);
if (BEAST_EXPECT(
metadata.isMember(sfAffectedNodes.jsonName)))
{
BEAST_EXPECT(
metadata[sfAffectedNodes.jsonName].size() == 2);
auto node = metadata[sfAffectedNodes.jsonName][0u];
if (BEAST_EXPECT(
node.isMember(sfModifiedNode.jsonName)))
{
auto modifiedNode = node[sfModifiedNode];
BEAST_EXPECT(
modifiedNode[sfLedgerEntryType] ==
"AccountRoot");
auto previousFields =
modifiedNode[sfPreviousFields];
BEAST_EXPECT(
!previousFields.isMember(sfBalance.jsonName));
}
auto node2 = metadata[sfAffectedNodes.jsonName][1u];
if (BEAST_EXPECT(
node2.isMember(sfModifiedNode.jsonName)))
{
auto modifiedNode = node2[sfModifiedNode];
BEAST_EXPECT(
modifiedNode[sfLedgerEntryType] ==
"AccountRoot");
auto previousFields =
modifiedNode[sfPreviousFields];
BEAST_EXPECT(
previousFields.isMember(sfBalance.jsonName));
}
}
BEAST_EXPECT(metadata[sfTransactionIndex.jsonName] == 0);
BEAST_EXPECT(
metadata[sfTransactionResult.jsonName] == "tesSUCCESS");
}
};
Account const sponsor("sponsor");
env.fund(XRP(10000), sponsor);
env.close();
Json::Value tx;
tx[jss::Account] = env.master.human();
tx[jss::TransactionType] = jss::AccountSet;
tx[sfDomain] = newDomain;
tx[sfSponsor.jsonName][sfAccount.jsonName] = sponsor.human();
tx[sfSponsor.jsonName][sfFlags.jsonName] = tfSponsorFee;
tx[sfSponsorSignature.jsonName] = Json::objectValue;
// test with autofill
testTx(env, tx, validateOutput);
tx[sfSponsorSignature.jsonName][sfTxnSignature.jsonName] = "";
tx[sfSponsorSignature.jsonName][sfSigningPubKey.jsonName] = "";
// test without autofill
testTx(env, tx, validateOutput);
}
}
void

7
src/xrpld/rpc/handlers/Simulate.cpp
View File

@@ -149,6 +149,13 @@ autofillTx(Json::Value& tx_json, RPC::JsonContext& context)
if (auto error = autofillSignature(tx_json))
return *error;
if (tx_json.isMember(sfSponsorSignature.jsonName))
{
if (auto error =
autofillSignature(tx_json[sfSponsorSignature.jsonName]))
return *error;
}
if (!tx_json.isMember(jss::Sequence))
{
auto const seq = getAutofillSequence(tx_json, context);