mirror of
https://github.com/XRPLF/rippled.git
synced 2026-08-21 22:30:57 +00:00
fix(test): brace assertion bodies gcc reads as a dangling else
The gcc debug-coverage job rejected an unbraced `if` whose body is a GTest assertion: EXPECT_EQ expands to an if/else, so the outer `if` leaves an else that could bind either way, and -Werror=dangling-else refuses it. clang does not warn, which is why only that one job failed. Braced the span-names case that failed, then swept every test file this branch touches for the same shape and braced the two others found, so the next gcc run does not fail on the next one down the list. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -539,7 +539,9 @@ class JobQueue_test : public beast::unit_test::Suite
|
||||
// Every one of these must defer: the limit is already reached.
|
||||
int const extra = 4;
|
||||
for (int i = 0; i < extra; ++i)
|
||||
{
|
||||
BEAST_EXPECT(fixture.queue.addJob(JtPack, "GaugeDefer", blockingJob));
|
||||
}
|
||||
|
||||
// Exact values, not bounds: `running` equals the type's limit and
|
||||
// `deferred` equals the number of submissions beyond it. Both are
|
||||
|
||||
@@ -468,7 +468,9 @@ class TMGetObjectByHash_test : public beast::unit_test::Suite
|
||||
auto reply = parseReply(peer);
|
||||
BEAST_EXPECT(reply.has_value());
|
||||
if (reply)
|
||||
{
|
||||
BEAST_EXPECT(reply->objects_size() == 0);
|
||||
}
|
||||
|
||||
// Positive counterpart to the oversize test: because the handler did
|
||||
// run, a differential charge was applied, and it is exactly the
|
||||
|
||||
@@ -465,8 +465,12 @@ TEST(LedgerSpanNames, phaseOutcome_covers_its_whole_input_domain)
|
||||
// Whenever the budget expired, the answer is `timeout`
|
||||
// regardless of the other two -- the precedence property, not
|
||||
// just the four sampled points above.
|
||||
// Braced deliberately: EXPECT_EQ expands to an if/else, so an
|
||||
// unbraced if around it is a dangling else, which gcc rejects.
|
||||
if (timedOut)
|
||||
{
|
||||
EXPECT_EQ(outcome, std::string_view(ledger_span::val::timeout));
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user