ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-02 16:26:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(telemetry): add const qualifiers to TraceContextPropagator locals

Browse Source 
Mark local variables in extractFromProtobuf() and injectToProtobuf()
as const since they are not modified after initialization: traceId,
spanId, flags, spanCtx, and span.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Pratik Mankawde
2026-04-28 11:51:45 +01:00
parent 3a1e462bef
commit 6154357daa
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
include/xrpl/telemetry/TraceContextPropagator.h
View File

@@ -43,15 +43,14 @@ extractFromProtobuf(protocol::TraceContext const& proto)
auto const* rawTraceId = reinterpret_cast<std::uint8_t const*>(proto.trace_id().data());
auto const* rawSpanId = reinterpret_cast<std::uint8_t const*>(proto.span_id().data());
trace::TraceId traceId(opentelemetry::nostd::span<std::uint8_t const, 16>(rawTraceId, 16));
trace::SpanId spanId(opentelemetry::nostd::span<std::uint8_t const, 8>(rawSpanId, 8));
// Default to not-sampled (0x00) per W3C Trace Context spec when
// the trace_flags field is absent.
trace::TraceFlags flags(
trace::TraceId const traceId(
opentelemetry::nostd::span<std::uint8_t const, 16>(rawTraceId, 16));
trace::SpanId const spanId(opentelemetry::nostd::span<std::uint8_t const, 8>(rawSpanId, 8));
trace::TraceFlags const flags(
proto.has_trace_flags() ? static_cast<std::uint8_t>(proto.trace_flags())
: static_cast<std::uint8_t>(0));
trace::SpanContext spanCtx(traceId, spanId, flags, /* remote = */ true);
trace::SpanContext const spanCtx(traceId, spanId, flags, /* remote = */ true);
return opentelemetry::context::Context{}.SetValue(
trace::kSpanKey,
@@ -68,7 +67,7 @@ injectToProtobuf(opentelemetry::context::Context const& ctx, protocol::TraceCont
{
namespace trace = opentelemetry::trace;
auto span = trace::GetSpan(ctx);
auto const span = trace::GetSpan(ctx);
if (!span)
return;