Fix no destination errors.

This commit is contained in:
Arthur Britto
2012-12-15 13:47:56 -08:00
parent 4baa8b3c5d
commit 6114a0b643
3 changed files with 9 additions and 9 deletions

View File

@@ -77,18 +77,18 @@ TER PaymentTransactor::doApply()
if (!saDstAmount.isNative()) if (!saDstAmount.isNative())
{ {
// This restriction could be relaxed. Log(lsINFO) << "doPayment: Delay transaction: Destination account does not exist.";
Log(lsINFO) << "doPayment: Malformed transaction: Create account may only fund XRP.";
return temCREATEXRP; // Another transaction could create the account and then this transaction would succeed.
return terNO_DST;
} }
else if (isSetBit(mParams, tapOPEN_LEDGER) // Ledger is not final, we can vote. else if (isSetBit(mParams, tapOPEN_LEDGER) // Ledger is not final, we can vote.
&& saDstAmount.getNValue() < theConfig.FEE_ACCOUNT_RESERVE) // Reserve is not scaled by fee. && saDstAmount.getNValue() < theConfig.FEE_ACCOUNT_RESERVE) // Reserve is not scaled by fee.
{ {
Log(lsINFO) << "doPayment: Delay transaction: Destination account does not exist insufficent payment to create account."; Log(lsINFO) << "doPayment: Delay transaction: Destination account does not exist. Insufficent payment to create account.";
// Not a local failure. Another transaction could create account and then this transaction would succeed. // Another transaction could create the account and then this transaction would succeed.
return terNO_DST; return terNO_DST_INSUF_XRP;
} }
// Create the account. // Create the account.

View File

@@ -34,7 +34,6 @@ bool transResultInfo(TER terCode, std::string& strToken, std::string& strHuman)
{ temBAD_TRANSFER_RATE, "temBAD_TRANSFER_RATE", "Malformed: Transfer rate must be >= 1.0" }, { temBAD_TRANSFER_RATE, "temBAD_TRANSFER_RATE", "Malformed: Transfer rate must be >= 1.0" },
{ temBAD_SET_ID, "temBAD_SET_ID", "Malformed." }, { temBAD_SET_ID, "temBAD_SET_ID", "Malformed." },
{ temBAD_SEQUENCE, "temBAD_SEQUENCE", "Malformed: Sequence in not in the past." }, { temBAD_SEQUENCE, "temBAD_SEQUENCE", "Malformed: Sequence in not in the past." },
{ temCREATEXRP, "temCREATEXRP", "Can not specify non XRP for Create." },
{ temDST_IS_SRC, "temDST_IS_SRC", "Destination may not be source." }, { temDST_IS_SRC, "temDST_IS_SRC", "Destination may not be source." },
{ temDST_NEEDED, "temDST_NEEDED", "Destination not specified." }, { temDST_NEEDED, "temDST_NEEDED", "Destination not specified." },
{ temINSUF_FEE_P, "temINSUF_FEE_P", "Fee not allowed." }, { temINSUF_FEE_P, "temINSUF_FEE_P", "Fee not allowed." },
@@ -52,7 +51,8 @@ bool transResultInfo(TER terCode, std::string& strToken, std::string& strHuman)
{ terFUNDS_SPENT, "terFUNDS_SPENT", "Can't set password, password set funds already spent." }, { terFUNDS_SPENT, "terFUNDS_SPENT", "Can't set password, password set funds already spent." },
{ terINSUF_FEE_B, "terINSUF_FEE_B", "Account balance can't pay fee." }, { terINSUF_FEE_B, "terINSUF_FEE_B", "Account balance can't pay fee." },
{ terNO_ACCOUNT, "terNO_ACCOUNT", "The source account does not exist." }, { terNO_ACCOUNT, "terNO_ACCOUNT", "The source account does not exist." },
{ terNO_DST, "terNO_DST", "The destination does not exist." }, { terNO_DST, "terNO_DST", "Destination does not exist. Send XRP to create it." },
{ terNO_DST_INSUF_XRP, "terNO_DST_INSUF_XRP", "Destination does not exist. Too little XRP sent to create it." },
{ terNO_LINE, "terNO_LINE", "No such line." }, { terNO_LINE, "terNO_LINE", "No such line." },
{ terNO_LINE_NO_ZERO, "terNO_LINE_NO_ZERO", "Can't zero non-existant line, destination might make it." }, { terNO_LINE_NO_ZERO, "terNO_LINE_NO_ZERO", "Can't zero non-existant line, destination might make it." },
{ terPRE_SEQ, "terPRE_SEQ", "Missing/inapplicable prior transaction." }, { terPRE_SEQ, "terPRE_SEQ", "Missing/inapplicable prior transaction." },

View File

@@ -36,7 +36,6 @@ enum TER // aka TransactionEngineResult
temBAD_TRANSFER_RATE, temBAD_TRANSFER_RATE,
temBAD_SEQUENCE, temBAD_SEQUENCE,
temBAD_SET_ID, temBAD_SET_ID,
temCREATEXRP,
temDST_IS_SRC, temDST_IS_SRC,
temDST_NEEDED, temDST_NEEDED,
temINSUF_FEE_P, temINSUF_FEE_P,
@@ -83,6 +82,7 @@ enum TER // aka TransactionEngineResult
terINSUF_FEE_B, terINSUF_FEE_B,
terNO_ACCOUNT, terNO_ACCOUNT,
terNO_DST, terNO_DST,
terNO_DST_INSUF_XRP,
terNO_LINE, terNO_LINE,
terNO_LINE_NO_ZERO, terNO_LINE_NO_ZERO,
terPRE_SEQ, terPRE_SEQ,