ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-07-24 23:50:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

explicit amendment checking

Browse Source
This commit is contained in:
Mayukha Vadari
2026-07-10 11:38:06 -04:00
parent 1267fedf74
commit 55cab65ab2
1 changed files with 27 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/libxrpl/tx/transactors/token/TrustSet.cpp
View File

@@ -329,6 +329,10 @@ TrustSet::doApply()
// With any sponsor on the tx, the sponsor must cover the reserve (via balance or
// prefunded budget), so the reserve check always runs.
bool const freeTrustLine = !sponsorSle && (ownerCount(sle, j_) < 2);
std::uint32_t const ownerCount = ownerCount(sle, j_) < 2;
XRPAmount const reserveCreate(
(ownerCount < 2) ? XRPAmount(beast::kZero)
: view().fees().accountReserve(ownerCount + 1, 1));
std::uint32_t const uQualityIn(bQualityIn ? ctx_.tx.getFieldU32(sfQualityIn) : 0);
std::uint32_t uQualityOut(bQualityOut ? ctx_.tx.getFieldU32(sfQualityOut) : 0);
@@ -615,6 +619,17 @@ TrustSet::doApply()
terResult = trustDelete(view(), sleRippleState, uLowAccountID, uHighAccountID, viewJ);
}
// Reserve is not scaled by load.
else if (
!view().rules().enabled(featureSponsor) && bReserveIncrease &&
preFeeBalance_ < reserveCreate)
{
JLOG(j_.trace()) << "Delay transaction: Insufficent reserve to "
"add trust line.";
// Another transaction could provide XRP to the account and then
// this transaction would succeed.
terResult = ret;
}
else if (
auto const ret = checkReserve(
ctx_.getApplyViewContext(),
@@ -652,6 +667,18 @@ TrustSet::doApply()
JLOG(j_.trace()) << "Redundant: Setting non-existent ripple line to defaults.";
return tecNO_LINE_REDUNDANT;
}
else if (!view().rules().enabled(featureSponsor) && preFeeBalance_ < reserveCreate) // Reserve
// is not
// scaled
// by load.
{
JLOG(j_.trace()) << "Delay transaction: Line does not exist. "
"Insufficent reserve to create line.";
// Another transaction could create the account and then this
// transaction would succeed.
terResult = tecNO_LINE_INSUF_RESERVE;
}
else if (
auto const ret = checkReserve(
ctx_.getApplyViewContext(),