ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-03 08:46:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix

Browse Source
This commit is contained in:
Valentin Balaschenko
2026-05-29 13:44:39 +01:00
parent 2f3558c610
commit 532cac0446
3 changed files with 28 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/libxrpl/ledger/helpers/PermissionedDEXHelpers.cpp
View File

@@ -19,6 +19,14 @@ namespace xrpl::permissioned_dex {
bool
accountInDomain(ReadView const& view, AccountID const& account, Domain const& domainID)
{
// A zero domainID is malformed: it would build a keylet with a zero key
// and violate Ledger::read's invariant. Defense in depth: callers should
// reject this at preflight, but guard here too so any future caller and
// the order-book sweep path (offerInDomain -> here) cannot trip the
// invariant.
if (domainID.isZero())
return false;
auto const sleDomain = view.read(keylet::permissionedDomain(domainID));
if (!sleDomain)
return false;

10
src/libxrpl/tx/transactors/dex/OfferCreate.cpp
View File

@@ -94,6 +94,16 @@ OfferCreate::preflight(PreflightContext const& ctx)
if (tx.isFlag(tfHybrid) && !tx.isFieldPresent(sfDomainID))
return temINVALID_FLAG;
// A present but zero DomainID is malformed: it would build a keylet with
// a zero key and violate Ledger::read's invariant. Reject at preflight
// (temMALFORMED) instead of letting it slip to preclaim and be
// misclassified as tecNO_PERMISSION.
if (tx.isFieldPresent(sfDomainID) && tx.getFieldH256(sfDomainID).isZero())
{
JLOG(j.debug()) << "Malformed offer: zero DomainID";
return temMALFORMED;
}
bool const bImmediateOrCancel(tx.isFlag(tfImmediateOrCancel));
bool const bFillOrKill(tx.isFlag(tfFillOrKill));

10
src/libxrpl/tx/transactors/payment/Payment.cpp
View File

@@ -125,6 +125,16 @@ Payment::preflight(PreflightContext const& ctx)
if (!mpTokensV2 && isDstMPT && ctx.tx.isFieldPresent(sfPaths))
return temMALFORMED;
// A present but zero DomainID is malformed: it would build a keylet with
// a zero key and violate Ledger::read's invariant. Reject at preflight
// (temMALFORMED) instead of letting it slip to preclaim and be
// misclassified as tecNO_PERMISSION.
if (tx.isFieldPresent(sfDomainID) && tx.getFieldH256(sfDomainID).isZero())
{
JLOG(j.debug()) << "Malformed payment: zero DomainID";
return temMALFORMED;
}
bool const partialPaymentAllowed = tx.isFlag(tfPartialPayment);
bool const limitQuality = tx.isFlag(tfLimitQuality);
bool const defaultPathsAllowed = !tx.isFlag(tfNoRippleDirect);