ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-03 16:56:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Sponsored account creation double-counts base reserve #6894

Browse Source
This commit is contained in:
tequ
2026-04-21 13:48:07 +09:00
parent dd82977e6c
commit 52e7cdc24d
2 changed files with 24 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/libxrpl/tx/transactors/payment/Payment.cpp
View File

@@ -611,8 +611,7 @@ Payment::doApply()
// the number of reserves in this ledger for this account that require a
// reserve.
auto const reserve = calculateReserve(sleSrc, view().fees()) +
(((txFlags & tfSponsorCreatedAccount) != 0u) ? view().fees().reserve : beast::zero);
auto const reserve = calculateReserve(sleSrc, view().fees());
// In a delegated payment, the fee payer is the delegated account,
// not the source account (account_).

24
src/test/app/Sponsor_test.cpp
View File

@@ -1710,8 +1710,10 @@ public:
Account const alice("alice");
Account const sponsor("sponsor");
Account const sponsor2("sponsor2");
Account const sponsor3("sponsor3");
Account const bob("bob");
Account const charlie("charlie");
Account const dave("dave");
Account const gw("gw");
auto const USD = gw["USD"];
@@ -1725,7 +1727,7 @@ public:
}
Env env{*this, testable_amendments()};
env.fund(XRP(10000), alice, sponsor, sponsor2);
env.fund(XRP(10000), alice, sponsor, sponsor2, sponsor3);
env.close();
// Invalid flags
@@ -1788,6 +1790,26 @@ public:
// verify sponsor balance decreased by payment + fee
BEAST_EXPECT(env.balance(sponsor2) == sponsor2BalanceBefore - drops(1) - XRP(1));
}
{
// insufficient reserve to sponsor acount
auto const sendAmount = drops(1);
// 2 account reserve + send amount
auto const requireBalance = accountReserve(env, 2) + sendAmount;
adjustAccountXRPBalance(env, sponsor3, requireBalance - drops(1));
env(pay(sponsor3, dave, sendAmount),
txflags(tfSponsorCreatedAccount),
fee(XRP(1)),
ter(tecUNFUNDED_PAYMENT));
env.close();
adjustAccountXRPBalance(env, sponsor3, requireBalance);
env(pay(sponsor3, dave, sendAmount),
txflags(tfSponsorCreatedAccount),
fee(XRP(1)),
ter(tesSUCCESS));
env.close();
}
}
void