ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-04 17:27:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix to return error if FeeAmount > Balance on SponsorshipSet

Browse Source
This commit is contained in:
tequ
2026-01-30 23:24:50 +09:00
parent 4a205eb9d8
commit 527d7bbede
2 changed files with 21 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/test/app/Sponsor_test.cpp
View File

@@ -156,22 +156,36 @@ public:
// Invalid Sponsee
env(sponsor::set(sponsor, 0), sponsor::sponseeAcc(noFunded), ter(tecNO_DST));
env.close();
// Invalid Sponsor
env(sponsor::set(sponsor, tfDeleteObject), sponsor::sponsorAcc(noFunded), ter(tecNO_DST));
env.close();
// Invalid Delete operation (sponsorship not found)
env(sponsor::set(sponsor, tfDeleteObject), sponsor::sponseeAcc(alice), ter(tecNO_ENTRY));
env.close();
// DisallowIncomingSponsor: tested in other testcase
// insufficent reserve to create sponsorship
adjustAccountXRPBalance(env, sponsor, reserve(env, 1) - drops(1));
env(sponsor::set(sponsor, 0, 100, XRP(100)), sponsor::sponseeAcc(alice), ter(tecUNFUNDED));
env.close();
// FeeAmount + Fee > Balance
/// Balance = 1000XRP, FeeAmount = 1001XRP
adjustAccountXRPBalance(env, sponsor, XRP(1000));
env(sponsor::set_fee(sponsor, 0, XRP(1001)), sponsor::sponseeAcc(alice), fee(XRP(1)), ter(tecUNFUNDED));
env.close();
/// Balance = 1000XRP, FeeAmount = 999XRP, Fee=2XRP
adjustAccountXRPBalance(env, sponsor, XRP(1000));
env(sponsor::set_fee(sponsor, 0, XRP(999)), sponsor::sponseeAcc(alice), fee(XRP(2)), ter(tecUNFUNDED));
env.close();
// create sponsor to use above tests
adjustAccountXRPBalance(env, sponsor, reserve(env, 1));
env(sponsor::set(sponsor, 0, 100, XRP(100)), sponsor::sponseeAcc(alice), ter(tesSUCCESS));
adjustAccountXRPBalance(env, sponsor, XRP(1001));
env(sponsor::set(sponsor, 0, 100, XRP(1000)), sponsor::sponseeAcc(alice), fee(XRP(1)), ter(tesSUCCESS));
env.close();
}

6
src/xrpld/app/tx/detail/SponsorshipSet.cpp
View File

@@ -147,7 +147,8 @@ SponsorshipSet::preclaim(PreclaimContext const& ctx)
return tecINTERNAL; // LCOV_EXCL_LINE
// check Sponsor
if (!ctx.view.exists(keylet::account(sponsor)))
auto const sponsorAccSle = ctx.view.read(keylet::account(sponsor));
if (!sponsorAccSle)
return tecNO_DST;
// check Sponsee
@@ -215,6 +216,9 @@ SponsorshipSet::doApply()
auto reserveSponsorAccSle = getTxReserveSponsor(view(), ctx_.tx);
if (feeAmount && (*feeAmount).xrp() > (*sponsorAccSle)[sfBalance])
return tecUNFUNDED;
if (!sponsorObjSle)
{
// Create