chore: Apply clang-tidy include and const-correctness fixes

Keep the develop-merge tree tidy-clean for headers and tests that
include-cleaner and braces checks flagged.

include/xrpl/tx/transactors/vault/VaultDeposit.h

@@ -9,6 +9,8 @@
 #include <xrpl/tx/ApplyContext.h>
 #include <xrpl/tx/Transactor.h>
 
+#include <cstdint>
+
 namespace xrpl {
 
 class VaultDeposit : public Transactor

include/xrpl/tx/transactors/vault/VaultSet.h

@@ -9,6 +9,8 @@
 #include <xrpl/tx/ApplyContext.h>
 #include <xrpl/tx/Transactor.h>
 
+#include <cstdint>
+
 namespace xrpl {
 
 class VaultSet : public Transactor

src/libxrpl/tx/transactors/lending/LoanBrokerSet.cpp

@@ -12,6 +12,7 @@
 #include <xrpl/ledger/helpers/TokenHelpers.h>
 #include <xrpl/ledger/helpers/VaultHelpers.h>
 #include <xrpl/protocol/AccountID.h>
+#include <xrpl/protocol/Asset.h>
 #include <xrpl/protocol/Feature.h>
 #include <xrpl/protocol/Indexes.h>
 #include <xrpl/protocol/Protocol.h>

src/test/app/VaultDepositLossInvariantRounding_test.cpp

@@ -1,4 +1,6 @@
+#include <test/jtx/Account.h>
 #include <test/jtx/Env.h>
+#include <test/jtx/amount.h>
 #include <test/jtx/pay.h>
 #include <test/jtx/ter.h>
 #include <test/jtx/trust.h>
@@ -6,12 +8,13 @@
 
 #include <xrpl/basics/Number.h>
 #include <xrpl/beast/unit_test/suite.h>
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/OpenView.h>
 #include <xrpl/ledger/Sandbox.h>
-#include <xrpl/protocol/Indexes.h>
 #include <xrpl/protocol/Keylet.h>
 #include <xrpl/protocol/SField.h>
-#include <xrpl/protocol/STNumber.h>
+#include <xrpl/protocol/TER.h>
 #include <xrpl/protocol/TxFlags.h>
 
 namespace xrpl {
@@ -84,7 +87,7 @@ class VaultDepositLossInvariantRounding_test : public beast::unit_test::Suite
 
         // Seed so the vault has outstanding shares (a donation needs them), then force the
         // lawful loss pre-state.
-        Vault vault{env};
+        Vault const vault{env};
         auto const [tx, keylet] = vault.create({.owner = owner, .asset = asset.raw()});
         env(tx);
         env.close();

src/test/app/VaultDustDebit_test.cpp

@@ -1,5 +1,5 @@
 #include <test/jtx/Env.h>
-#include <test/jtx/fee.h>
+#include <test/jtx/amount.h>
 #include <test/jtx/flags.h>
 #include <test/jtx/pay.h>
 #include <test/jtx/ter.h>
@@ -13,7 +13,8 @@
 #include <xrpl/protocol/MPTIssue.h>
 #include <xrpl/protocol/SField.h>
 #include <xrpl/protocol/STAmount.h>
-#include <xrpl/protocol/STNumber.h>
+#include <xrpl/protocol/TER.h>
+#include <xrpl/protocol/TxFlags.h>
 
 #include <cstdint>
 #include <string>
@@ -34,8 +35,8 @@ class VaultDustDebit_test : public beast::unit_test::Suite
         Number assetsTotal;
         Number assetsAvailable;
         Number pseudoLine;  // vault pseudo-account trust line
-        std::uint64_t sharesTotal;
-        std::uint64_t holderShares;
+        std::uint64_t sharesTotal{};
+        std::uint64_t holderShares{};
     };
 
     static VaultData
@@ -96,7 +97,7 @@ class VaultDustDebit_test : public beast::unit_test::Suite
         env(pay(issuer, owner, asset(donation)));
         env.close();
 
-        Vault vault{env};
+        Vault const vault{env};
         auto const [tx, keylet] = vault.create({.owner = owner, .asset = asset.raw()});
         env(tx);
         env.close();

src/test/app/lending/LoanCashBasis_test.cpp

@@ -27,6 +27,7 @@
 #include <chrono>
 #include <cstdint>
 #include <functional>
+#include <optional>
 #include <string>
 #include <tuple>
 

src/test/app/lending/LoanSet_test.cpp

@@ -1152,9 +1152,13 @@ private:
 
             Number const destAfter = env.balance(borrower, usd.raw()).number();
             if (isTesSuccess(expected))
+            {
                 BEAST_EXPECT(destAfter == destBefore + Number{100});
+            }
             else
+            {
                 BEAST_EXPECT(destAfter == destBefore);
+            }
         };
 
         run(all_ - fixCleanup3_4_0, terNO_RIPPLE);

src/test/app/vault/VaultBlockDeposit_test.cpp

@@ -4,12 +4,11 @@
 #include <test/jtx/amount.h>
 #include <test/jtx/pay.h>
 #include <test/jtx/ter.h>
-#include <test/jtx/trust.h>
 #include <test/jtx/vault.h>
 
 #include <xrpl/beast/unit_test/suite.h>
 #include <xrpl/protocol/Feature.h>
-#include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/Issue.h>
 #include <xrpl/protocol/Keylet.h>
 #include <xrpl/protocol/LedgerFormats.h>
 #include <xrpl/protocol/TER.h>

src/test/app/vault/VaultDonate_test.cpp

@@ -9,9 +9,9 @@
 #include <xrpl/protocol/Asset.h>
 #include <xrpl/protocol/Feature.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/Issue.h>
 #include <xrpl/protocol/Keylet.h>
 #include <xrpl/protocol/SField.h>
-#include <xrpl/protocol/STNumber.h>
 #include <xrpl/protocol/TER.h>
 #include <xrpl/protocol/TxFlags.h>