Merge branch 'ripple/wasmi-host-functions' into mvadari/remove-wasm-number

include/xrpl/tx/wasm/README.md

@@ -103,7 +103,7 @@ WASM execution is metered, and if the gas limit is exceeded, execution fails.
 ## Entry Point
 
 The WASM module must export a function with the name defined by
-`ESCROW_FUNCTION_NAME` (currently `"finish"`). This function:
+`escrowFunctionName` (currently `"escrow_finish"`). This function:
 
 - Takes no parameters (or parameters passed via host function calls)
 - Returns an `int32_t`:

include/xrpl/tx/wasm/WasmVM.h

@@ -17,7 +17,7 @@ std::string_view inline constexpr wAlloc = "allocate";
 std::string_view inline constexpr wDealloc = "deallocate";
 std::string_view inline constexpr wProcExit = "proc_exit";
 
-std::string_view inline constexpr escrowFunctionName = "finish";
+std::string_view inline constexpr escrowFunctionName = "escrow_finish";
 
 uint32_t inline constexpr maxPages = 128;  // 8MB = 64KB*128
 

src/test/app/Wasm_test.cpp

@@ -217,7 +217,7 @@ struct Wasm_test : public beast::unit_test::Suite
             auto re = engine.run(
                 allHostFuncWasm, hfs, 1'000'000, escrowFunctionName, {}, imp, env.journal);
 
-            checkResult(re, 1, 27'032);
+            checkResult(re, 1, 27'617);
 
             env.close();
         }
@@ -239,7 +239,7 @@ struct Wasm_test : public beast::unit_test::Suite
             auto re = engine.run(
                 allHostFuncWasm, hfs, 1'000'000, escrowFunctionName, {}, imp, env.journal);
 
-            checkResult(re, 1, 68'792);
+            checkResult(re, 1, 70'877);
 
             env.close();
         }
@@ -280,7 +280,7 @@ struct Wasm_test : public beast::unit_test::Suite
         {
             TestHostFunctions hfs(env);
             auto re = runEscrowWasm(allHFWasm, hfs, 100'000, escrowFunctionName, {});
-            checkResult(re, 1, 68'792);
+            checkResult(re, 1, 70'877);
         }
 
         {
@@ -304,7 +304,7 @@ struct Wasm_test : public beast::unit_test::Suite
             TestHostFunctions hfs(env);
             auto re = runEscrowWasm(
                 allHFWasm, hfs, std::numeric_limits<int64_t>::max(), escrowFunctionName, {});
-            checkResult(re, 1, 68'792);
+            checkResult(re, 1, 70'877);
         }
 
         {  // fail because trying to access nonexistent field
@@ -322,7 +322,7 @@ struct Wasm_test : public beast::unit_test::Suite
 
             FieldNotFoundHostFunctions hfs(env);
             auto re = runEscrowWasm(allHFWasm, hfs, 100'000, escrowFunctionName, {});
-            checkResult(re, -201, 28'965);
+            checkResult(re, -201, 29'502);
         }
 
         {  // fail because trying to allocate more than MAX_PAGES memory
@@ -340,7 +340,7 @@ struct Wasm_test : public beast::unit_test::Suite
 
             OversizedFieldHostFunctions hfs(env);
             auto re = runEscrowWasm(allHFWasm, hfs, 100'000, escrowFunctionName, {});
-            checkResult(re, -201, 28'965);
+            checkResult(re, -201, 29'502);
         }
     }
 

src/test/app/wasm_fixtures/all_host_functions/src/lib.rs

@@ -32,7 +32,7 @@ use xrpl_std::host::trace::{trace, trace_account_buf, trace_data, trace_num, Dat
 use xrpl_std::sfield;
 
 #[unsafe(no_mangle)]
-pub extern "C" fn finish() -> i32 {
+pub extern "C" fn escrow_finish() -> i32 {
     let _ = trace("=== HOST FUNCTIONS TEST ===");
     let _ = trace("Testing 26 host functions");
 
@@ -210,7 +210,9 @@ fn test_transaction_data_functions() -> i32 {
     // Use get_tx_field() with appropriate parameters for all transaction field access.
 
     // Test 2.2: get_tx_nested_field() - Nested field access with locator
-    let locator = [0x01_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8]; // Two int32s in little-endian: [1, 0]
+    let locator = [
+        0x01_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8,
+    ]; // Two int32s in little-endian: [1, 0]
     let mut nested_buffer = [0u8; 32];
     let nested_result = unsafe {
         host::tx_inner(
@@ -323,7 +325,9 @@ fn test_current_ledger_object_functions() -> i32 {
     }
 
     // Test 3.2: get_current_ledger_obj_nested_field() - Nested field access
-    let locator = [0x01_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8]; // Two int32s in little-endian: [1, 0]
+    let locator = [
+        0x01_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8,
+    ]; // Two int32s in little-endian: [1, 0]
     let mut current_nested_buffer = [0u8; 32];
     let current_nested_result = unsafe {
         host::home_le_inner(
@@ -434,7 +438,9 @@ fn test_any_ledger_object_functions() -> i32 {
         }
 
         // Test get_ledger_obj_nested_field with invalid slot
-        let locator = [0x01_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8]; // Two int32s in little-endian: [1, 0]
+        let locator = [
+            0x01_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8,
+        ]; // Two int32s in little-endian: [1, 0]
         let nested_result = unsafe {
             host::le_inner(
                 1,
@@ -517,7 +523,9 @@ fn test_any_ledger_object_functions() -> i32 {
     }
 
     // Test 4.3: get_ledger_obj_nested_field() - Nested field from cached object
-    let locator = [0x01_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8]; // Two int32s in little-endian: [1, 0]
+    let locator = [
+        0x01_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8, 0x00_u8,
+    ]; // Two int32s in little-endian: [1, 0]
     let mut cached_nested_buffer = [0u8; 32];
     let cached_nested_result = unsafe {
         host::le_inner(

src/test/app/wasm_fixtures/all_keylets/src/lib.rs

@@ -67,7 +67,7 @@ pub fn object_exists<T: LedgerObjectFieldGetter, const CODE: i32>(
 }
 
 #[unsafe(no_mangle)]
-pub extern "C" fn finish() -> i32 {
+pub extern "C" fn escrow_finish() -> i32 {
     let _ = trace("$$$$$ STARTING WASM EXECUTION $$$$$");
 
     let escrow: CurrentEscrow = get_current_escrow();

src/test/app/wasm_fixtures/codecov_tests/src/lib.rs

@@ -48,7 +48,7 @@ where
 }
 
 #[unsafe(no_mangle)]
-pub extern "C" fn finish() -> i32 {
+pub extern "C" fn escrow_finish() -> i32 {
     let _ = trace("$$$$$ STARTING WASM EXECUTION $$$$$");
 
     // ########################################

src/test/app/wasm_fixtures/ledgerSqn.c

@@ -2,7 +2,7 @@
 
 int32_t ldgr_index(uint8_t *, int32_t);
 
-int finish()
+int escrow_finish()
 {
   uint32_t sqn;
   int32_t result = ldgr_index((uint8_t *)&sqn, sizeof(sqn));