ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-10-20 02:28:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: Drop extern template declarations from SLEBase test

Browse Source 
An explicit instantiation declaration stops clang from emitting the
inline constructors of the header-only entries at -O0, so the debug
builds fail to link xrpl_tests (undefined AccountRootEntry constructors).
Naming each class in a static_assert already instantiates its definition,
which is all the exhaustiveness check needs.

(cherry picked from commit 611415e1f9)
This commit is contained in:
Mayukha Vadari
2026-10-05 14:32:44 +01:00
parent 191c1a6bf8
commit 3efbf48827
1 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/tests/libxrpl/ledger/SLEBase.cpp
View File

@@ -76,19 +76,22 @@ template class SLEBase<ApplyView>;
#pragma push_macro("LEDGER_ENTRY")
#undef LEDGER_ENTRY
// Explicit instantiation *declarations*, not definitions: an entry whose
// member bodies live in its own .cpp (with the explicit instantiation
// definition there) must not be instantiated a second time here. MSVC also
// rejects (C4661, an error under /WX) an explicit instantiation definition of
// a class whose out-of-line members are not visible in this translation unit.
// A declaration still instantiates the class definition itself, which is all
// this exhaustiveness check needs.
// No explicit instantiation here, neither a definition nor a declaration.
// A definition would instantiate an entry a second time once its member
// bodies live in its own .cpp (MSVC rejects that with C4661 under /WX), and a
// declaration (`extern template`) stops clang from emitting the inline
// constructors of the header-only entries at -O0, which leaves them undefined
// at link time in the debug builds. Naming the class in a static_assert is
// enough to instantiate its definition, which is all this exhaustiveness
// check needs; the per-type suites exercise the members.
#define LEDGER_ENTRY(tag, value, name, ...) \
extern template class name##Entry<ReadView>; \
extern template class name##Entry<ApplyView>; \
static_assert( \
name##Entry<ReadView>::kEntryType == tag && name##Entry<ApplyView>::kEntryType == tag, \
#name "Entry must be bound to " #tag);
#name "Entry must be bound to " #tag); \
static_assert( \
std::is_constructible_v<name##Entry<ReadView>, Keylet const&, ReadView const&> && \
std::is_constructible_v<name##Entry<ApplyView>, Keylet const&, ApplyView&>, \
#name "Entry must be constructible from a Keylet and a view");
#include <xrpl/protocol/detail/ledger_entries.macro>