ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-08-19 13:20:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: Hook up delegate_id host function

Browse Source
This commit is contained in:
TimothyBanks
2026-08-10 18:07:49 -04:00
parent 9c423d2743
commit 3e113db4f5
11 changed files with 176 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
crates/xrpl-host-functions/src/lib.rs
View File

@@ -267,6 +267,17 @@ host_functions! {
out: &mut [u8],
) -> HostResult<usize>;
/// The 32-byte keylet of a `Delegate` object, computed from the 20-byte account
/// and the account it authorizes. Reads both account regions and writes the keylet.
#[gas = 350]
#[wasm_name = "delegate_id"]
fn delegate_keylet(
&self,
account: &[u8],
authorize: &[u8],
out: &mut [u8],
) -> HostResult<usize>;
/// The XRPL `sha512Half` of `data`: the first [`HASH_LEN`] bytes of its SHA-512.
#[gas = 2000]
#[wasm_name = "sha512_half"]

27
crates/xrpl-host-functions/tests/generated_abi.rs
View File

@@ -216,6 +216,23 @@ impl HostFunctions for FakeHost {
put(out, &[subject[0]; HASH_LEN])
}
/// A keylet from two accounts; `InvalidAccount` if either is empty, `InvalidParams`
/// if they are equal.
fn delegate_keylet(
&self,
account: &[u8],
authorize: &[u8],
out: &mut [u8],
) -> HostResult<usize> {
if account.is_empty() || authorize.is_empty() {
return Err(HostError::InvalidAccount);
}
if account == authorize {
return Err(HostError::InvalidParams);
}
put(out, &[account[0]; HASH_LEN])
}
fn sha512_half(&self, data: &[u8], out: &mut [u8]) -> HostResult<usize> {
let mut digest = [0; HASH_LEN];
digest[0] = data.len() as u8;
@@ -329,6 +346,15 @@ fn the_trait_is_implementable() {
host.credential_keylet(&[], &[8; 20], b"cred", &mut out),
Err(HostError::InvalidAccount)
);
assert_eq!(
host.delegate_keylet(&[7; 20], &[8; 20], &mut out),
Ok(HASH_LEN)
);
assert_eq!(out[0], 7);
assert_eq!(
host.delegate_keylet(&[], &[8; 20], &mut out),
Err(HostError::InvalidAccount)
);
assert_eq!(host.sha512_half(b"abc", &mut out), Ok(HASH_LEN));
assert_eq!(out[0], 3);
assert_eq!(host.trace("hello", b"xy", true), Ok(()));
@@ -419,6 +445,7 @@ fn the_spec_table_matches_the_declarations() {
("amm_id", 450),
("check_id", 350),
("credential_id", 350),
("delegate_id", 350),
("sha512_half", 2000),
("trace", 500),
("trace_num", 500),

18
crates/xrpl-wasm-vm-ffi/src/lib.rs
View File

@@ -282,6 +282,15 @@ mod ffi {
out: &mut [u8],
) -> i32;
#[namespace = "xrpl"]
#[cxx_name = "delegateKeylet"]
fn delegate_keylet(
self: &HostContext,
account: &[u8],
authorize: &[u8],
out: &mut [u8],
) -> i32;
#[namespace = "xrpl"]
#[cxx_name = "sha512Half"]
fn sha512_half(self: &HostContext, data: &[u8], out: &mut [u8]) -> i32;
@@ -454,6 +463,15 @@ impl HostFunctions for CxxHost<'_> {
)
}
fn delegate_keylet(
&self,
account: &[u8],
authorize: &[u8],
out: &mut [u8],
) -> HostResult<usize> {
bytes_written(self.ctx.delegate_keylet(account, authorize, out))
}
fn sha512_half(&self, data: &[u8], out: &mut [u8]) -> HostResult<usize> {
bytes_written(self.ctx.sha512_half(data, out))
}

8
crates/xrpl-wasm-vm/src/abi.rs
View File

@@ -283,6 +283,14 @@ mod tests {
) -> HostResult<usize> {
unreachable!("no unit test in this module calls the host")
}
fn delegate_keylet(
&self,
_account: &[u8],
_authorize: &[u8],
_out: &mut [u8],
) -> HostResult<usize> {
unreachable!("no unit test in this module calls the host")
}
fn sha512_half(&self, _data: &[u8], _out: &mut [u8]) -> HostResult<usize> {
unreachable!("no unit test in this module calls the host")
}

21
crates/xrpl-wasm-vm/src/register.rs
View File

@@ -411,6 +411,27 @@ pub(crate) fn register_host_functions(
})
},
),
HostFunctionSpec::DelegateKeylet => linker.func_wrap(
HOST_MODULE,
op.wasm_name(),
|mut caller: Caller<'_, VmState<'_>>,
acc_ptr: i32,
acc_len: i32,
auth_ptr: i32,
auth_len: i32,
out_ptr: i32,
out_len: i32|
-> Result<i32, wasmi::Error> {
charged(&mut caller, HostFunctionSpec::DelegateKeylet, |c| {
let out = Region::new(out_ptr, out_len);
let account = Region::new(acc_ptr, acc_len);
let authorize = Region::new(auth_ptr, auth_len);
write_buffered(c, out, |host, data, buf| {
host.delegate_keylet(account.read(data)?, authorize.read(data)?, buf)
})
})
},
),
HostFunctionSpec::Sha512Half => linker.func_wrap(
HOST_MODULE,
op.wasm_name(),

5
crates/xrpl-wasm-vm/tests/budgets.rs
View File

@@ -164,6 +164,11 @@ fn call_for(op: HostFunctionSpec) -> Call {
"(call $credential_id (i32.const 0) (i32.const 20) (i32.const 20) (i32.const 20) (i32.const 40) (i32.const 4) (i32.const 44) (i32.const 20))",
8,
),
HostFunctionSpec::DelegateKeylet => (
import::DELEGATE_ID,
"(call $delegate_id (i32.const 0) (i32.const 20) (i32.const 20) (i32.const 20) (i32.const 40) (i32.const 32))",
6,
),
HostFunctionSpec::Sha512Half => (
import::SHA512_HALF,
"(call $sha512_half (i32.const 0) (i32.const 4) (i32.const 0) (i32.const 32))",

26
crates/xrpl-wasm-vm/tests/host_calls.rs
View File

@@ -462,6 +462,32 @@ fn credential_id_reads_subject_issuer_and_type() {
);
}
/// A two-account keylet getter: both accounts reach the host as a pair, and the
/// keylet lands where the guest asked.
#[test]
fn delegate_id_reads_both_accounts_and_writes_the_keylet() {
let account = vec![0u8; 20];
let authorize = vec![0u8; 20];
let host = FakeHost::new().answering_delegate_keylet(
account.clone(),
authorize.clone(),
support::Answer::filler(32),
);
let wat = module(
&[import::DELEGATE_ID, ONE_PAGE],
"(call $delegate_id
(i32.const 0) (i32.const 20)
(i32.const 20) (i32.const 20)
(i32.const 64) (i32.const 64))",
);
assert_eq!(status(&wat, &host), 32, "the 32-byte keylet length");
assert_eq!(
*host.delegate_keylets_asked.borrow(),
vec![(account, authorize)]
);
}
/// A leading scalar parameter reaches the host as declared.
#[test]
fn home_le_field_passes_the_field_selector_through() {

3
crates/xrpl-wasm-vm/tests/preflight.rs
View File

@@ -98,7 +98,7 @@ fn a_disabled_feature_does_not_pass() {
/// Every host function the ABI declares, spelled as a guest imports it. The count
/// is asserted against the ABI so a function added to it cannot be left out here.
const ALL_IMPORTS: [&str; 26] = [
const ALL_IMPORTS: [&str; 27] = [
import::LDGR_INDEX,
import::PARENT_LDGR_TIME,
import::PARENT_LDGR_HASH,
@@ -122,6 +122,7 @@ const ALL_IMPORTS: [&str; 26] = [
import::AMM_ID,
import::CHECK_ID,
import::CREDENTIAL_ID,
import::DELEGATE_ID,
import::SHA512_HALF,
import::TRACE,
import::TRACE_NUM,

32
crates/xrpl-wasm-vm/tests/support/mod.rs
View File

@@ -199,6 +199,11 @@ pub struct FakeHost {
pub credential_keylets: HashMap<(Vec<u8>, Vec<u8>, Vec<u8>), Answer>,
/// Every (subject, issuer, type) `credential_keylet` was asked for.
pub credential_keylets_asked: RefCell<Vec<(Vec<u8>, Vec<u8>, Vec<u8>)>>,
/// What `delegate_keylet` answers, by (account, authorize) bytes. An unlisted key
/// answers `InvalidAccount`.
pub delegate_keylets: HashMap<(Vec<u8>, Vec<u8>), Answer>,
/// Every (account, authorize) `delegate_keylet` was asked for.
pub delegate_keylets_asked: RefCell<Vec<(Vec<u8>, Vec<u8>)>>,
/// What `sha512_half` answers, whatever it is given.
pub digest: Answer,
/// Every field selector `get_current_ledger_obj_field` was asked for.
@@ -261,6 +266,8 @@ impl Default for FakeHost {
check_keylets_asked: RefCell::new(Vec::new()),
credential_keylets: HashMap::new(),
credential_keylets_asked: RefCell::new(Vec::new()),
delegate_keylets: HashMap::new(),
delegate_keylets_asked: RefCell::new(Vec::new()),
digest: Answer::filler(32),
fields_asked: RefCell::new(Vec::new()),
digested: RefCell::new(Vec::new()),
@@ -416,6 +423,16 @@ impl FakeHost {
self
}
pub fn answering_delegate_keylet(
mut self,
account: Vec<u8>,
authorize: Vec<u8>,
answer: Answer,
) -> FakeHost {
self.delegate_keylets.insert((account, authorize), answer);
self
}
pub fn answering_digest(mut self, answer: Answer) -> FakeHost {
self.digest = answer;
self
@@ -627,6 +644,20 @@ impl HostFunctions for FakeHost {
}
}
fn delegate_keylet(
&self,
account: &[u8],
authorize: &[u8],
out: &mut [u8],
) -> HostResult<usize> {
let key = (account.to_vec(), authorize.to_vec());
self.delegate_keylets_asked.borrow_mut().push(key.clone());
match self.delegate_keylets.get(&key) {
Some(answer) => answer.fill(out),
None => Err(HostError::InvalidAccount),
}
}
fn sha512_half(&self, data: &[u8], out: &mut [u8]) -> HostResult<usize> {
self.digested.borrow_mut().push(data.to_vec());
self.digest.fill(out)
@@ -690,6 +721,7 @@ pub mod import {
pub const AMM_ID: &str = r#"(import "host_lib" "amm_id" (func $amm_id (param i32 i32 i32 i32 i32 i32) (result i32)))"#;
pub const CHECK_ID: &str = r#"(import "host_lib" "check_id" (func $check_id (param i32 i32 i32 i32 i32) (result i32)))"#;
pub const CREDENTIAL_ID: &str = r#"(import "host_lib" "credential_id" (func $credential_id (param i32 i32 i32 i32 i32 i32 i32 i32) (result i32)))"#;
pub const DELEGATE_ID: &str = r#"(import "host_lib" "delegate_id" (func $delegate_id (param i32 i32 i32 i32 i32 i32) (result i32)))"#;
pub const SHA512_HALF: &str = r#"(import "host_lib" "sha512_half" (func $sha512_half (param i32 i32 i32 i32) (result i32)))"#;
pub const TRACE: &str =
r#"(import "host_lib" "trace" (func $trace (param i32 i32 i32 i32 i32) (result i32)))"#;

7
include/xrpl/tx/wasm/HostContext.h
View File

@@ -150,6 +150,13 @@ public:
rust::Slice<std::uint8_t const> credentialType,
rust::Slice<std::uint8_t> out) const noexcept;
// Both accounts must be 20 bytes, else `InvalidParams`. Writes the 32-byte keylet.
[[nodiscard]] std::int32_t
delegateKeylet(
rust::Slice<std::uint8_t const> account,
rust::Slice<std::uint8_t const> authorize,
rust::Slice<std::uint8_t> out) const noexcept;
[[nodiscard]] std::int32_t
sha512Half(rust::Slice<std::uint8_t const> data, rust::Slice<std::uint8_t> out) const noexcept;

19
src/libxrpl/tx/wasm/HostContext.cpp
View File

@@ -527,6 +527,25 @@ HostContext::credentialKeylet(
});
}
std::int32_t
HostContext::delegateKeylet(
rust::Slice<std::uint8_t const> account,
rust::Slice<std::uint8_t const> authorize,
rust::Slice<std::uint8_t> out) const noexcept
{
return guarded(hostFunctions_.getJournal(), kHostInternal, [&] {
if (account.size() != AccountID::size() || authorize.size() != AccountID::size())
return hfErrorToInt(HostFunctionError::InvalidParams);
auto const value = hostFunctions_.delegateKeylet(
AccountID::fromVoid(account.data()), AccountID::fromVoid(authorize.data()));
if (!value)
return hfErrorToInt(value.error());
return answer(out, value->data(), value->size());
});
}
std::int32_t
HostContext::sha512Half(rust::Slice<std::uint8_t const> data, rust::Slice<std::uint8_t> out)
const noexcept