ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-02-27 17:22:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This commit is contained in:
Ed Hennis
2026-02-25 21:10:11 -04:00
committed by GitHub
parent e27249134a
commit 3d5ff2c8a2
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/libxrpl/basics/Number.cpp
View File

@@ -314,8 +314,10 @@ Number::externalToInternal(rep mantissa)
if (mantissa >= 0)
return mantissa;
// Cast to unsigned before negating to avoid undefined behavior
// when v == INT64_MIN (negating INT64_MIN in signed is UB)
// Cast to unsigned before negating to avoid undefined behavior when
// mantissa == std::numeric_limits<rep>::min() (INT64_MIN). Negating
// INT64_MIN in signed arithmetic is UB, but casting to the unsigned
// internalrep first makes the operation well-defined.
return -static_cast<internalrep>(mantissa);
}