ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-04-29 15:37:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rewrite LoanManage flag check to skip if field not set or 0

Browse Source
This commit is contained in:
Ed Hennis
2025-09-17 15:41:03 -04:00
parent d1c708ca01
commit 2c0c4567f4
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/xrpld/app/tx/detail/LoanManage.cpp
View File

@@ -44,13 +44,16 @@ LoanManage::preflight(PreflightContext const& ctx)
return temINVALID;
// Flags are mutually exclusive
auto const flags = ctx.tx[~sfFlags].value_or(0) & tfUniversalMask;
if ((flags & (flags - 1)) != 0)
if (auto const flagField = ctx.tx[~sfFlags]; flagField && *flagField)
{
JLOG(ctx.j.warn())
<< "LoanManage: Only one of tfLoanDefault, tfLoanImpair, or "
"tfLoanUnimpair can be set.";
return temINVALID_FLAG;
auto const flags = *flagField & tfUniversalMask;
if ((flags & (flags - 1)) != 0)
{
JLOG(ctx.j.warn())
<< "LoanManage: Only one of tfLoanDefault, tfLoanImpair, or "
"tfLoanUnimpair can be set.";
return temINVALID_FLAG;
}
}
return tesSUCCESS;