ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-04 01:06:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

audit 14

Browse Source
This commit is contained in:
tequ
2026-02-18 17:22:23 +09:00
parent dcfcb1f3fd
commit 293394fbc6
2 changed files with 19 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/libxrpl/tx/transactors/Payment.cpp
View File

@@ -562,7 +562,8 @@ Payment::doApply()
// the number of reserves in this ledger for this account that require a
// reserve.
auto const reserve = calculateReserve(sleSrc, view().fees());
auto const reserve = calculateReserve(sleSrc, view().fees()) +
((txFlags & tfSponsorCreatedAccount) ? view().fees().reserve : beast::zero);
// mPriorBalance is the balance on the sending account BEFORE the
// fees were charged. We want to make sure we have enough reserve

22
src/test/app/Sponsor_test.cpp
View File

@@ -1226,6 +1226,7 @@ public:
Account const alice("alice");
Account const sponsor("sponsor");
Account const sponsor2("sponsor2");
Account const bob("bob");
Account const charlie("charlie");
Account const gw("gw");
@@ -1241,7 +1242,7 @@ public:
}
Env env{*this, testable_amendments()};
env.fund(XRP(10000), alice, sponsor);
env.fund(XRP(10000), alice, sponsor, sponsor2);
env.close();
// Invalid flags
@@ -1275,18 +1276,29 @@ public:
// Use tfSponsorCreatedAccount to sponsor an account
{
// to funded account
env(pay(sponsor, bob, drops(1)), txflags(tfSponsorCreatedAccount), ter(tecNO_SPONSOR_PERMISSION));
env(pay(sponsor2, bob, drops(1)),
txflags(tfSponsorCreatedAccount),
fee(XRP(1)),
ter(tecNO_SPONSOR_PERMISSION));
env.close();
BEAST_EXPECT(env.balance(sponsor2) == XRP(9999));
// to non-funded account / insufficient balance for reserve
env(pay(sponsor2, charlie, XRP(9999) - env.current()->fees().reserve + drops(1)),
txflags(tfSponsorCreatedAccount),
ter(tecUNFUNDED_PAYMENT));
env.close();
// to non-funded account
env(pay(sponsor, charlie, drops(1)), txflags(tfSponsorCreatedAccount));
env(pay(sponsor2, charlie, drops(1)), txflags(tfSponsorCreatedAccount), fee(XRP(1)));
env.close();
auto const charlieSle = env.le(keylet::account(charlie));
BEAST_EXPECT(charlieSle->isFieldPresent(sfSponsor));
BEAST_EXPECT(charlieSle->getAccountID(sfSponsor) == sponsor.id());
BEAST_EXPECT(charlieSle->getAccountID(sfSponsor) == sponsor2.id());
BEAST_EXPECT(sponsoredOwnerCount(env, charlie) == 0);
BEAST_EXPECT(sponsoringAccountCount(env, sponsor) == 1);
BEAST_EXPECT(sponsoringAccountCount(env, sponsor2) == 1);
}
}