ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-11-04 19:25:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert unnecessary change and update unit test

Browse Source 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
This commit is contained in:
JCW
2025-08-08 15:53:03 +01:00
parent 96d0fcfbd1
commit 1fd24c31d3
2 changed files with 4 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
include/xrpl/beast/hash/xxhasher.h
View File

@@ -172,14 +172,7 @@ public:
explicit
operator result_type() noexcept
{
auto result = retrieveHash();
resetBuffers();
if (state_)
{
XXH3_freeState(state_);
state_ = nullptr;
}
return result;
return XXH3_64bits_digest(state_);
}
};

46
src/test/beast/xxhasher_test.cpp
View File

@@ -185,57 +185,17 @@ public:
}
void
testOperatorResultTypeDoesTheSameAsOtherHashers()
testResultTypeCanBeCalledIdempotently()
{
testcase("Operator result type does the same as other hashers");
testcase("Operator result type doesn't change the internal state");
xxhasher hasher1;
ripple::sha256_hasher hasher2{};
std::string object{"Hello xxhash"};
hasher1(object.data(), object.size());
hasher2(object.data(), object.size());
auto xxhashResult1 = static_cast<xxhasher::result_type>(hasher1);
auto xxhashResult2 = static_cast<xxhasher::result_type>(hasher1);
auto sha256Result1 = static_cast<ripple::sha256_hasher::result_type>(hasher2);
auto sha256Result2 = static_cast<ripple::sha256_hasher::result_type>(hasher2);
auto xxhashChanged = xxhashResult1 == xxhashResult2;
auto sha256Changed = sha256Result1 == sha256Result2;
BEAST_EXPECT(xxhashChanged == sha256Changed);
}
void
testHasherStateStillValidAfterReset()
{
testcase("Hasher state still valid after reset");
{
xxhasher hasher1;
std::string object{"Hello xxhash"};
hasher1(object.data(), object.size());
auto xxhashResult1 = static_cast<xxhasher::result_type>(hasher1);
hasher1(object.data(), object.size());
auto xxhashResult2 = static_cast<xxhasher::result_type>(hasher1);
BEAST_EXPECT(xxhashResult1 == xxhashResult2);
}
{
xxhasher hasher1;
std::string object;
for (int i = 0; i < 100; i++)
{
object += "Hello, xxHash!";
}
hasher1(object.data(), object.size());
auto xxhashResult1 = static_cast<xxhasher::result_type>(hasher1);
hasher1(object.data(), object.size());
auto xxhashResult2 = static_cast<xxhasher::result_type>(hasher1);
BEAST_EXPECT(xxhashResult1 == xxhashResult2);
}
BEAST_EXPECT(xxhashResult1 == xxhashResult2);
}
void