ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-09-27 07:26:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'pratik/otel-sync-diagnostics' into pratik/otel-sync-diagnostics-freshen-fix

Browse Source
This commit is contained in:
Pratik Mankawde
2026-09-23 12:03:20 +01:00
parent f7e65949b8 992e600929
commit 1d49c64a9d
18 changed files with 24 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
OpenTelemetryPlan/09-data-collection-reference.md
View File

@@ -858,7 +858,7 @@ by perf-comparison run:
| `$service_name` | `service_name` | Filter by service (`service.name`, e.g. `xrpld`) |
| `$deployment_environment` | `deployment_environment` | Filter by deployment tier (`local` / `test` / `ci` / `prod`) |
| `$xrpl_network_type` | `xrpl_network_type` | Filter by network (`mainnet` / `testnet` / `devnet` / `perf`) |
| `$xrpl_work_item` | `xrpl_work_item` | Filter by perf-iac work item / ticket (e.g. `RIPD-7455`) |
| `$xrpl_work_item` | `xrpl_work_item` | Filter by perf-iac work item / ticket |
| `$xrpl_branch` | `xrpl_branch` | Filter by comparison side (`baseline:<ref>:<commit>` / `test:…`) |
| `$xrpl_node_role` | `xrpl_node_role` | Filter by node role (`validator` / `peer`) |

2
docker/telemetry/grafana/dashboards/consensus-health.json
View File

@@ -1404,7 +1404,7 @@
{
"name": "xrpl_work_item",
"label": "Work Item",
"description": "Filter by perf-iac work item / ticket (e.g. RIPD-7455)",
"description": "Filter by perf-iac work item / ticket",
"type": "query",
"query": "label_values(xrpl_work_item)",
"datasource": {

2
docker/telemetry/grafana/dashboards/fee-market.json
View File

@@ -622,7 +622,7 @@
{
"name": "xrpl_work_item",
"label": "Work Item",
"description": "Filter by perf-iac work item / ticket (e.g. RIPD-7455)",
"description": "Filter by perf-iac work item / ticket",
"type": "query",
"query": "label_values(xrpl_work_item)",
"datasource": {

2
docker/telemetry/grafana/dashboards/job-queue.json
View File

@@ -756,7 +756,7 @@
{
"name": "xrpl_work_item",
"label": "Work Item",
"description": "Filter by perf-iac work item / ticket (e.g. RIPD-7455)",
"description": "Filter by perf-iac work item / ticket",
"type": "query",
"query": "label_values(xrpl_work_item)",
"datasource": {

2
docker/telemetry/grafana/dashboards/ledger-data-sync.json
View File

@@ -2421,7 +2421,7 @@
{
"name": "xrpl_work_item",
"label": "Work Item",
"description": "Filter by perf-iac work item / ticket (e.g. RIPD-7455)",
"description": "Filter by perf-iac work item / ticket",
"type": "query",
"query": "label_values(xrpl_work_item)",
"datasource": {

2
docker/telemetry/grafana/dashboards/ledger-operations.json
View File

@@ -638,7 +638,7 @@
{
"name": "xrpl_work_item",
"label": "Work Item",
"description": "Filter by perf-iac work item / ticket (e.g. RIPD-7455)",
"description": "Filter by perf-iac work item / ticket",
"type": "query",
"query": "label_values(xrpl_work_item)",
"datasource": {

2
docker/telemetry/grafana/dashboards/ledger-sync-health.json
View File

@@ -5555,7 +5555,7 @@
{
"name": "xrpl_work_item",
"label": "Work Item",
"description": "Filter by perf-iac work item / ticket (e.g. RIPD-7455)",
"description": "Filter by perf-iac work item / ticket",
"type": "query",
"query": "label_values(xrpl_work_item)",
"datasource": {

2
docker/telemetry/grafana/dashboards/network-traffic.json
View File

@@ -1037,7 +1037,7 @@
{
"name": "xrpl_work_item",
"label": "Work Item",
"description": "Filter by perf-iac work item / ticket (e.g. RIPD-7455)",
"description": "Filter by perf-iac work item / ticket",
"type": "query",
"query": "label_values(xrpl_work_item)",
"datasource": {

2
docker/telemetry/grafana/dashboards/node-health.json
View File

@@ -5425,7 +5425,7 @@
{
"name": "xrpl_work_item",
"label": "Work Item",
"description": "Filter by perf-iac work item / ticket (e.g. RIPD-7455)",
"description": "Filter by perf-iac work item / ticket",
"type": "query",
"query": "label_values(xrpl_work_item)",
"datasource": {

2
docker/telemetry/grafana/dashboards/overlay-traffic-detail.json
View File

@@ -1050,7 +1050,7 @@
{
"name": "xrpl_work_item",
"label": "Work Item",
"description": "Filter by perf-iac work item / ticket (e.g. RIPD-7455)",
"description": "Filter by perf-iac work item / ticket",
"type": "query",
"query": "label_values(xrpl_work_item)",
"datasource": {

2
docker/telemetry/grafana/dashboards/peer-network.json
View File

@@ -459,7 +459,7 @@
{
"name": "xrpl_work_item",
"label": "Work Item",
"description": "Filter by perf-iac work item / ticket (e.g. RIPD-7455)",
"description": "Filter by perf-iac work item / ticket",
"type": "query",
"query": "label_values(xrpl_work_item)",
"datasource": {

2
docker/telemetry/grafana/dashboards/peer-quality.json
View File

@@ -680,7 +680,7 @@
{
"name": "xrpl_work_item",
"label": "Work Item",
"description": "Filter by perf-iac work item / ticket (e.g. RIPD-7455)",
"description": "Filter by perf-iac work item / ticket",
"type": "query",
"query": "label_values(xrpl_work_item)",
"datasource": {

2
docker/telemetry/grafana/dashboards/rpc-pathfinding.json
View File

@@ -838,7 +838,7 @@
{
"name": "xrpl_work_item",
"label": "Work Item",
"description": "Filter by perf-iac work item / ticket (e.g. RIPD-7455)",
"description": "Filter by perf-iac work item / ticket",
"type": "query",
"query": "label_values(xrpl_work_item)",
"datasource": {

2
docker/telemetry/grafana/dashboards/rpc-performance.json
View File

@@ -1105,7 +1105,7 @@
{
"name": "xrpl_work_item",
"label": "Work Item",
"description": "Filter by perf-iac work item / ticket (e.g. RIPD-7455)",
"description": "Filter by perf-iac work item / ticket",
"type": "query",
"query": "label_values(xrpl_work_item)",
"datasource": {

2
docker/telemetry/grafana/dashboards/transaction-overview.json
View File

@@ -1241,7 +1241,7 @@
{
"name": "xrpl_work_item",
"label": "Work Item",
"description": "Filter by perf-iac work item / ticket (e.g. RIPD-7455)",
"description": "Filter by perf-iac work item / ticket",
"type": "query",
"query": "label_values(xrpl_work_item)",
"datasource": {

2
docker/telemetry/grafana/dashboards/validator-health.json
View File

@@ -1163,7 +1163,7 @@
{
"name": "xrpl_work_item",
"label": "Work Item",
"description": "Filter by perf-iac work item / ticket (e.g. RIPD-7455)",
"description": "Filter by perf-iac work item / ticket",
"type": "query",
"query": "label_values(xrpl_work_item)",
"datasource": {

2
docs/telemetry-runbook.md
View File

@@ -2081,7 +2081,7 @@ one dashboard set serves every deployment:
| Service | `service.name` | xrpld cfg | `xrpld`, `xrpld-validator` |
| Network | `xrpl.network.type` | xrpld node | `mainnet`, `testnet`, `devnet`, `perf` |
| Environment | `deployment.environment` | collector | `local`, `test`, `ci`, `prod` |
| Work Item | `xrpl.work.item` | perf-iac | `RIPD-7455` (empty outside perf runs) |
| Work Item | `xrpl.work.item` | perf-iac | the work-item key (empty outside perf runs) |
| Branch | `xrpl.branch` | perf-iac | `baseline:<ref>:<commit>`, `test:<ref>:<commit>` |
| Node Role | `xrpl.node.role` | perf-iac | `validator`, `peer` |

14
src/tests/libxrpl/telemetry/MetricsRegistry.cpp
View File

@@ -644,14 +644,14 @@ constexpr auto kNow = netTime(800'000'000);
constexpr auto kDay = 86'400U;
// Ahead of the deadline: ordinary positive readings.
static_assert(Registry::daysUntil(netTime(800'000'000 + 7 * kDay), kNow) == 7.0);
static_assert(Registry::daysUntil(netTime(800'000'000 + kDay / 2), kNow) == 0.5);
static_assert(Registry::daysUntil(netTime(800'000'000 + (7 * kDay)), kNow) == 7.0);
static_assert(Registry::daysUntil(netTime(800'000'000 + (kDay / 2)), kNow) == 0.5);
static_assert(Registry::daysUntil(kNow, kNow) == 0.0);
// Past the deadline: the readings the unsigned subtraction used to wrap.
static_assert(Registry::daysUntil(netTime(800'000'000 - kDay), kNow) == -1.0);
static_assert(Registry::daysUntil(netTime(800'000'000 - kDay / 2), kNow) == -0.5);
static_assert(Registry::daysUntil(netTime(800'000'000 - 30 * kDay), kNow) == -30.0);
static_assert(Registry::daysUntil(netTime(800'000'000 - (kDay / 2)), kNow) == -0.5);
static_assert(Registry::daysUntil(netTime(800'000'000 - (30 * kDay)), kNow) == -30.0);
// The sentinel the config path sets for a list that never expires.
static_assert(
@@ -681,9 +681,9 @@ TEST(MetricsRegistryDaysUntil, readings_decrease_monotonically_as_the_deadline_p
// anywhere in that walk is a jump upward, so this fails on the exact
// second the old arithmetic went wrong rather than only on sampled points.
constexpr auto kHour = 3'600U;
auto previous = Registry::daysUntil(netTime(800'000'000 + 7 * kDay), kNow);
auto previous = Registry::daysUntil(netTime(800'000'000 + (7 * kDay)), kNow);
for (std::uint32_t offset = 7 * kDay - kHour; offset > 0; offset -= kHour)
for (std::uint32_t offset = (7 * kDay) - kHour; offset > 0; offset -= kHour)
{
auto const ahead = Registry::daysUntil(netTime(800'000'000 + offset), kNow);
EXPECT_LT(ahead, previous) << "ahead of deadline by " << offset << "s";
@@ -698,7 +698,7 @@ TEST(MetricsRegistryDaysUntil, readings_decrease_monotonically_as_the_deadline_p
}
// Ends a full week past the deadline, which is where the wrap was largest.
EXPECT_EQ(Registry::daysUntil(netTime(800'000'000 - 7 * kDay), kNow), -7.0);
EXPECT_EQ(Registry::daysUntil(netTime(800'000'000 - (7 * kDay)), kNow), -7.0);
}
TEST(MetricsRegistryDaysUntil, never_expires_sentinel_outranks_every_finite_reading)