ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-04 09:16:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

address spec changes (payment flags/ iou amount)

Browse Source
This commit is contained in:
tequ
2026-01-14 12:49:49 +09:00
parent ec05613472
commit 1bc5a1bb43
3 changed files with 50 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/xrpl/protocol/detail/transactions.macro
View File

@@ -1063,7 +1063,7 @@ TRANSACTION(ttLOAN_PAY, 84, LoanPay,
# include <xrpld/app/tx/detail/SponsorshipTransfer.h>
#endif
TRANSACTION(ttSPONSORSHIP_TRANSFER, 85, SponsorshipTransfer,
Delegation::delegatable,
Delegation::delegable,
featureSponsor,
noPriv,
({
@@ -1075,7 +1075,7 @@ TRANSACTION(ttSPONSORSHIP_TRANSFER, 85, SponsorshipTransfer,
# include <xrpld/app/tx/detail/SponsorshipSet.h>
#endif
TRANSACTION(ttSPONSORSHIP_SET, 86, SponsorshipSet,
Delegation::delegatable,
Delegation::delegable,
featureSponsor,
noPriv,
({

50
src/test/app/Sponsor_test.cpp
View File

@@ -1120,19 +1120,55 @@ public:
{
testcase("Sponsor Account");
using namespace test::jtx;
Env env{*this, testable_amendments()};
Env env{*this, testable_amendments() - featureSponsor};
Account const alice("alice");
Account const sponsor("sponsor");
Account const bob("bob");
Account const charlie("charlie");
Account const gw("gw");
auto const USD = gw["USD"];
env.fund(XRP(10000), alice, sponsor);
// Disabled
env(pay(alice, bob, XRP(100)),
txflags(tfSponsorCreatedAccount),
ter(temDISABLED));
env.close();
env.enableFeature(featureSponsor);
env.close();
// Invalid flags
for (auto flag : {
tfNoRippleDirect,
tfPartialPayment,
tfLimitQuality,
})
{
env(pay(alice, bob, XRP(100)),
txflags(tfSponsorCreatedAccount | flag),
ter(temINVALID_FLAG));
env.close();
}
// Invalid amount(iou)
env(pay(alice, bob, USD(100)),
txflags(tfSponsorCreatedAccount),
ter(temBAD_AMOUNT));
env.close();
// Insufficient reserve
env(pay(alice,
bob,
(env.current()->fees().accountReserve(0) - drops(1))),
txflags(tfSponsorCreatedAccount),
ter(tecNO_DST_INSUF_XRP));
env.close();
// Account is not sponsored by normal Sponsor specification
{
env(pay(alice,
bob,
STAmount(env.current()->fees().accountReserve(0))),
env(pay(alice, bob, drops(env.current()->fees().accountReserve(0))),
sponsor::as(sponsor, tfSponsorReserve),
sig(sfSponsorSignature, sponsor));
env.close();
@@ -1145,17 +1181,17 @@ public:
// Use tfSponsorCreatedAccount to sponsor an account
{
// to funded accoutn
// to funded account
env(pay(sponsor,
bob,
STAmount(env.current()->fees().accountReserve(0))),
drops(env.current()->fees().accountReserve(0))),
txflags(tfSponsorCreatedAccount),
ter(tecNO_SPONSOR_PERMISSION));
// to non-funded account
env(pay(sponsor,
charlie,
STAmount(env.current()->fees().accountReserve(0))),
drops(env.current()->fees().accountReserve(0))),
txflags(tfSponsorCreatedAccount));
env.close();

6
src/xrpld/app/tx/detail/Payment.cpp
View File

@@ -87,10 +87,14 @@ Payment::preflight(PreflightContext const& ctx)
if (txFlags & tfSponsorCreatedAccount)
{
if (!ctx.rules.enabled(featureSponsor))
return temDISABLED;
if (txFlags & tfNoRippleDirect || txFlags & tfPartialPayment ||
txFlags & tfLimitQuality)
return temINVALID_FLAG;
if (!dstAmount.native())
return temMALFORMED;
return temBAD_AMOUNT;
}
if (mptDirect && ctx.tx.isFieldPresent(sfPaths))