Review feedback from @gregtatcam: variable name

- Renamed "fee" to "overpaymentFee" in "computeOverpaymentComponents".
This commit is contained in:
Ed Hennis
2025-11-23 23:32:23 -05:00
parent 76766e93df
commit 1ba010031d

View File

@@ -1047,7 +1047,7 @@ computeOverpaymentComponents(
"ripple::detail::computeOverpaymentComponents : valid overpayment " "ripple::detail::computeOverpaymentComponents : valid overpayment "
"amount"); "amount");
Number const fee = roundToAsset( Number const overpaymentFee = roundToAsset(
asset, tenthBipsOfValue(overpayment, overpaymentFeeRate), loanScale); asset, tenthBipsOfValue(overpayment, overpaymentFeeRate), loanScale);
auto const [rawOverpaymentInterest, _] = [&]() { auto const [rawOverpaymentInterest, _] = [&]() {
@@ -1065,12 +1065,12 @@ computeOverpaymentComponents(
auto const result = detail::ExtendedPaymentComponents{ auto const result = detail::ExtendedPaymentComponents{
detail::PaymentComponents{ detail::PaymentComponents{
.trackedValueDelta = overpayment - fee, .trackedValueDelta = overpayment - overpaymentFee,
.trackedPrincipalDelta = overpayment - roundedOverpaymentInterest - .trackedPrincipalDelta = overpayment - roundedOverpaymentInterest -
roundedOverpaymentManagementFee - fee, roundedOverpaymentManagementFee - overpaymentFee,
.trackedManagementFeeDelta = roundedOverpaymentManagementFee, .trackedManagementFeeDelta = roundedOverpaymentManagementFee,
.specialCase = detail::PaymentSpecialCase::extra}, .specialCase = detail::PaymentSpecialCase::extra},
fee, overpaymentFee,
roundedOverpaymentInterest}; roundedOverpaymentInterest};
XRPL_ASSERT_PARTS( XRPL_ASSERT_PARTS(
result.trackedInterestPart() == roundedOverpaymentInterest, result.trackedInterestPart() == roundedOverpaymentInterest,