From 1ba010031d560c485f05e5e74fdbb0c4d2e171ca Mon Sep 17 00:00:00 2001 From: Ed Hennis Date: Sun, 23 Nov 2025 23:32:23 -0500 Subject: [PATCH] Review feedback from @gregtatcam: variable name - Renamed "fee" to "overpaymentFee" in "computeOverpaymentComponents". --- src/xrpld/app/misc/detail/LendingHelpers.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/xrpld/app/misc/detail/LendingHelpers.cpp b/src/xrpld/app/misc/detail/LendingHelpers.cpp index 80423e7269..8ba49c787c 100644 --- a/src/xrpld/app/misc/detail/LendingHelpers.cpp +++ b/src/xrpld/app/misc/detail/LendingHelpers.cpp @@ -1047,7 +1047,7 @@ computeOverpaymentComponents( "ripple::detail::computeOverpaymentComponents : valid overpayment " "amount"); - Number const fee = roundToAsset( + Number const overpaymentFee = roundToAsset( asset, tenthBipsOfValue(overpayment, overpaymentFeeRate), loanScale); auto const [rawOverpaymentInterest, _] = [&]() { @@ -1065,12 +1065,12 @@ computeOverpaymentComponents( auto const result = detail::ExtendedPaymentComponents{ detail::PaymentComponents{ - .trackedValueDelta = overpayment - fee, + .trackedValueDelta = overpayment - overpaymentFee, .trackedPrincipalDelta = overpayment - roundedOverpaymentInterest - - roundedOverpaymentManagementFee - fee, + roundedOverpaymentManagementFee - overpaymentFee, .trackedManagementFeeDelta = roundedOverpaymentManagementFee, .specialCase = detail::PaymentSpecialCase::extra}, - fee, + overpaymentFee, roundedOverpaymentInterest}; XRPL_ASSERT_PARTS( result.trackedInterestPart() == roundedOverpaymentInterest,