mirror of
https://github.com/XRPLF/rippled.git
synced 2026-08-21 22:30:57 +00:00
style(telemetry): keep the JMeter annotation colour as it was
The driver split changed the existing perf-run regions from grey to violet, which was not asked for. Restore `rgb(70, 70, 70)` on `Perf Runs (JMeter)` so every region that rendered before keeps its colour; `Perf Runs (Locust)` stays aqua, since it is new. Grey separates from aqua well (dE 22.8 deutan, 25.9 tritan, 26.1 normal), but it sits at 1.98:1 against the dark-theme surface, below the 3:1 floor, so its region edges read faint there. Noted in the runbook.
This commit is contained in:
@@ -20,7 +20,7 @@
|
||||
},
|
||||
"enable": true,
|
||||
"hide": false,
|
||||
"iconColor": "rgb(144, 133, 233)",
|
||||
"iconColor": "rgb(70, 70, 70)",
|
||||
"name": "Perf Runs (JMeter)",
|
||||
"target": {
|
||||
"limit": 100,
|
||||
|
||||
@@ -20,7 +20,7 @@
|
||||
},
|
||||
"enable": true,
|
||||
"hide": false,
|
||||
"iconColor": "rgb(144, 133, 233)",
|
||||
"iconColor": "rgb(70, 70, 70)",
|
||||
"name": "Perf Runs (JMeter)",
|
||||
"target": {
|
||||
"limit": 100,
|
||||
|
||||
@@ -20,7 +20,7 @@
|
||||
},
|
||||
"enable": true,
|
||||
"hide": false,
|
||||
"iconColor": "rgb(144, 133, 233)",
|
||||
"iconColor": "rgb(70, 70, 70)",
|
||||
"name": "Perf Runs (JMeter)",
|
||||
"target": {
|
||||
"limit": 100,
|
||||
|
||||
@@ -20,7 +20,7 @@
|
||||
},
|
||||
"enable": true,
|
||||
"hide": false,
|
||||
"iconColor": "rgb(144, 133, 233)",
|
||||
"iconColor": "rgb(70, 70, 70)",
|
||||
"name": "Perf Runs (JMeter)",
|
||||
"target": {
|
||||
"limit": 100,
|
||||
|
||||
@@ -20,7 +20,7 @@
|
||||
},
|
||||
"enable": true,
|
||||
"hide": false,
|
||||
"iconColor": "rgb(144, 133, 233)",
|
||||
"iconColor": "rgb(70, 70, 70)",
|
||||
"name": "Perf Runs (JMeter)",
|
||||
"target": {
|
||||
"limit": 100,
|
||||
|
||||
@@ -34,7 +34,7 @@
|
||||
},
|
||||
"enable": true,
|
||||
"hide": false,
|
||||
"iconColor": "rgb(144, 133, 233)",
|
||||
"iconColor": "rgb(70, 70, 70)",
|
||||
"name": "Perf Runs (JMeter)",
|
||||
"target": {
|
||||
"limit": 100,
|
||||
|
||||
@@ -20,7 +20,7 @@
|
||||
},
|
||||
"enable": true,
|
||||
"hide": false,
|
||||
"iconColor": "rgb(144, 133, 233)",
|
||||
"iconColor": "rgb(70, 70, 70)",
|
||||
"name": "Perf Runs (JMeter)",
|
||||
"target": {
|
||||
"limit": 100,
|
||||
|
||||
@@ -20,7 +20,7 @@
|
||||
},
|
||||
"enable": true,
|
||||
"hide": false,
|
||||
"iconColor": "rgb(144, 133, 233)",
|
||||
"iconColor": "rgb(70, 70, 70)",
|
||||
"name": "Perf Runs (JMeter)",
|
||||
"target": {
|
||||
"limit": 100,
|
||||
|
||||
@@ -20,7 +20,7 @@
|
||||
},
|
||||
"enable": true,
|
||||
"hide": false,
|
||||
"iconColor": "rgb(144, 133, 233)",
|
||||
"iconColor": "rgb(70, 70, 70)",
|
||||
"name": "Perf Runs (JMeter)",
|
||||
"target": {
|
||||
"limit": 100,
|
||||
|
||||
@@ -20,7 +20,7 @@
|
||||
},
|
||||
"enable": true,
|
||||
"hide": false,
|
||||
"iconColor": "rgb(144, 133, 233)",
|
||||
"iconColor": "rgb(70, 70, 70)",
|
||||
"name": "Perf Runs (JMeter)",
|
||||
"target": {
|
||||
"limit": 100,
|
||||
|
||||
@@ -20,7 +20,7 @@
|
||||
},
|
||||
"enable": true,
|
||||
"hide": false,
|
||||
"iconColor": "rgb(144, 133, 233)",
|
||||
"iconColor": "rgb(70, 70, 70)",
|
||||
"name": "Perf Runs (JMeter)",
|
||||
"target": {
|
||||
"limit": 100,
|
||||
|
||||
@@ -20,7 +20,7 @@
|
||||
},
|
||||
"enable": true,
|
||||
"hide": false,
|
||||
"iconColor": "rgb(144, 133, 233)",
|
||||
"iconColor": "rgb(70, 70, 70)",
|
||||
"name": "Perf Runs (JMeter)",
|
||||
"target": {
|
||||
"limit": 100,
|
||||
|
||||
@@ -20,7 +20,7 @@
|
||||
},
|
||||
"enable": true,
|
||||
"hide": false,
|
||||
"iconColor": "rgb(144, 133, 233)",
|
||||
"iconColor": "rgb(70, 70, 70)",
|
||||
"name": "Perf Runs (JMeter)",
|
||||
"target": {
|
||||
"limit": 100,
|
||||
|
||||
@@ -20,7 +20,7 @@
|
||||
},
|
||||
"enable": true,
|
||||
"hide": false,
|
||||
"iconColor": "rgb(144, 133, 233)",
|
||||
"iconColor": "rgb(70, 70, 70)",
|
||||
"name": "Perf Runs (JMeter)",
|
||||
"target": {
|
||||
"limit": 100,
|
||||
|
||||
@@ -20,7 +20,7 @@
|
||||
},
|
||||
"enable": true,
|
||||
"hide": false,
|
||||
"iconColor": "rgb(144, 133, 233)",
|
||||
"iconColor": "rgb(70, 70, 70)",
|
||||
"name": "Perf Runs (JMeter)",
|
||||
"target": {
|
||||
"limit": 100,
|
||||
|
||||
@@ -1995,10 +1995,10 @@ shaded band covers exactly the interval over which the load was applied.
|
||||
|
||||
Every dashboard carries two tag-matched annotation layers, one per load driver:
|
||||
|
||||
| Layer | Tags | Color |
|
||||
| -------------------- | --------------------- | ------ |
|
||||
| `Perf Runs (JMeter)` | `perf-iac` + `jmeter` | violet |
|
||||
| `Perf Runs (Locust)` | `perf-iac` + `locust` | aqua |
|
||||
| Layer | Tags | Color |
|
||||
| -------------------- | --------------------- | ----- |
|
||||
| `Perf Runs (JMeter)` | `perf-iac` + `jmeter` | grey |
|
||||
| `Perf Runs (Locust)` | `perf-iac` + `locust` | aqua |
|
||||
|
||||
Both layers set `matchAny: false`, so a region is drawn only if it carries
|
||||
**both** of the layer's tags — the tag list is an AND, not an OR. Grafana tag
|
||||
@@ -2028,7 +2028,9 @@ Two rendering limits are worth knowing. Grafana draws annotations only on time
|
||||
series, state timeline and candlestick panels, so on a board of mostly stats and
|
||||
gauges most panels show no band. And the shaded fill is rendered at 10% opacity,
|
||||
so the two drivers' colours are near-identical inside the band; the region's two
|
||||
full-colour dashed edges and the toolbar toggles are what tell them apart.
|
||||
full-colour dashed edges and the toolbar toggles are what tell them apart. The
|
||||
JMeter grey sits below the 3:1 contrast floor on the dark theme, so its edges
|
||||
read faint there; the Locust aqua clears it in both themes.
|
||||
|
||||
### Who owns which attribute
|
||||
|
||||
|
||||
Reference in New Issue
Block a user