ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify clean up for takeOffers.

Browse Source
This commit is contained in:
Arthur Britto
2012-08-27 13:20:47 -07:00
parent 344f551c39
commit 0d8ad928f6
1 changed files with 9 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/TransactionEngine.cpp
View File

@@ -4184,24 +4184,14 @@ TransactionEngineResult TransactionEngine::takeOffers(
}
// On storing meta data, delete offers that were found unfunded to prevent encountering them in future.
switch (terResult)
if (tesSUCCESS == terResult)
{
case tesSUCCESS:
case tepPATH_DRY:
case tepPATH_PARTIAL:
BOOST_FOREACH(const uint256& uOfferIndex, usOfferUnfundedFound)
{
TransactionEngineResult terDelete = offerDelete(uOfferIndex);
if (tesSUCCESS != terDelete)
terResult = terDelete;
break;
}
break;
default:
nothing();
break;
BOOST_FOREACH(const uint256& uOfferIndex, usOfferUnfundedFound)
{
terResult = offerDelete(uOfferIndex);
if (tesSUCCESS != terResult)
break;
}
}
if (tesSUCCESS == terResult)
@@ -4209,10 +4199,8 @@ TransactionEngineResult TransactionEngine::takeOffers(
// On success, delete offers that became unfunded.
BOOST_FOREACH(const uint256& uOfferIndex, usOfferUnfundedBecame)
{
TransactionEngineResult terDelete = offerDelete(uOfferIndex);
if (tesSUCCESS != terDelete)
terResult = terDelete;
terResult = offerDelete(uOfferIndex);
if (tesSUCCESS != terResult)
break;
}
}