ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-07-24 23:50:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(telemetry): name trace_id/span_id literals and hex widths in Log

Browse Source 
Replace the raw "trace_id="/" span_id=" prefix literals and the bare 32/16
hex-width magic numbers in the log trace-context injection with named
constexpr constants (kTraceIdPrefix, kSpanIdPrefix, kTraceIdHexLen,
kSpanIdHexLen), documenting that the widths are the W3C 16-byte trace_id /
8-byte span_id rendered as lowercase hex. No behavior change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Pratik Mankawde
2026-07-24 15:32:41 +01:00
parent 0de12c75b3
commit 07bc6d2ce7
1 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/libxrpl/basics/Log.cpp
View File

@@ -17,6 +17,7 @@
#endif // XRPL_ENABLE_TELEMETRY
#include <chrono>
#include <cstddef>
#include <cstring>
#include <fstream>
#include <functional>
@@ -315,13 +316,21 @@ Logs::format(
auto spanCtx = span->GetContext();
if (spanCtx.IsValid())
{
char traceId[32], spanId[16];
spanCtx.trace_id().ToLowerBase16(opentelemetry::nostd::span<char, 32>{traceId});
spanCtx.span_id().ToLowerBase16(opentelemetry::nostd::span<char, 16>{spanId});
output += "trace_id=";
output.append(traceId, 32);
output += " span_id=";
output.append(spanId, 16);
// Hex widths of a W3C trace context: 16-byte trace_id and
// 8-byte span_id render to 32 and 16 lowercase hex chars.
constexpr std::size_t kTraceIdHexLen = 32;
constexpr std::size_t kSpanIdHexLen = 16;
constexpr auto kTraceIdPrefix = "trace_id=";
constexpr auto kSpanIdPrefix = " span_id=";
char traceId[kTraceIdHexLen], spanId[kSpanIdHexLen];
spanCtx.trace_id().ToLowerBase16(
opentelemetry::nostd::span<char, kTraceIdHexLen>{traceId});
spanCtx.span_id().ToLowerBase16(
opentelemetry::nostd::span<char, kSpanIdHexLen>{spanId});
output += kTraceIdPrefix;
output.append(traceId, kTraceIdHexLen);
output += kSpanIdPrefix;
output.append(spanId, kSpanIdHexLen);
output += ' ';
}
}