clang-tidy I hope you get a rock in your shoe

include/xrpl/tx/ApplyContext.h

@@ -112,7 +112,7 @@ public:
     TER
     checkInvariants(TER const result, XRPAmount const fee);
 
-    inline ApplyViewContext&
+    ApplyViewContext&
     getApplyViewContext()
     {
         XRPL_ASSERT(view_.has_value() && (&viewCtx_.view == &*view_), "Previous view discarded");

src/libxrpl/ledger/helpers/MPTokenHelpers.cpp

@@ -23,7 +23,6 @@
 #include <xrpl/protocol/SField.h>
 #include <xrpl/protocol/STAmount.h>
 #include <xrpl/protocol/STLedgerEntry.h>
-#include <xrpl/protocol/STTx.h>
 #include <xrpl/protocol/TER.h>
 #include <xrpl/protocol/TxFlags.h>
 #include <xrpl/protocol/UintTypes.h>

src/libxrpl/ledger/helpers/RippleStateHelpers.cpp

@@ -22,7 +22,6 @@
 #include <xrpl/protocol/SField.h>
 #include <xrpl/protocol/STAmount.h>
 #include <xrpl/protocol/STLedgerEntry.h>
-#include <xrpl/protocol/STTx.h>
 #include <xrpl/protocol/TER.h>
 #include <xrpl/protocol/UintTypes.h>
 #include <xrpl/protocol/XRPAmount.h>

src/libxrpl/ledger/helpers/TokenHelpers.cpp

@@ -24,7 +24,6 @@
 #include <xrpl/protocol/SField.h>
 #include <xrpl/protocol/STAmount.h>
 #include <xrpl/protocol/STLedgerEntry.h>
-#include <xrpl/protocol/STTx.h>
 #include <xrpl/protocol/TER.h>
 #include <xrpl/protocol/UintTypes.h>
 #include <xrpl/protocol/XRPAmount.h>

src/libxrpl/tx/ApplyContext.cpp

@@ -42,7 +42,7 @@ ApplyContext::ApplyContext(
     , flags_(flags)
     , view_{std::in_place, &base_, flags_}
     , parentBatchId_(parentBatchId)
-    , viewCtx_{*view_, tx}
+    , viewCtx_{.view = *view_, .tx = tx}
 {
     XRPL_ASSERT(
         parentBatchId.has_value() == ((flags_ & TapBatch) == TapBatch),

src/libxrpl/tx/transactors/check/CheckCash.cpp

@@ -3,6 +3,7 @@
 #include <xrpl/basics/Log.h>
 #include <xrpl/basics/scope.h>
 #include <xrpl/core/ServiceRegistry.h>
+#include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/PaymentSandbox.h>
 #include <xrpl/ledger/View.h>
 #include <xrpl/ledger/helpers/AccountRootHelpers.h>