ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-07-25 08:00:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixup! Make preflight1 and preflight2 private static Transactor functions

Browse Source
This commit is contained in:
Ed Hennis
2025-07-22 12:10:58 -04:00
parent 6c5945f9e8
commit 021bee8dd4
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/xrpld/app/tx/detail/Transactor.cpp
View File

@@ -118,22 +118,23 @@ preflightCheckSimulateKeys(
STObject const& sigObject,
beast::Journal j)
{
if (ctx.flags & tapDRY_RUN) // simulation
if (flags & tapDRY_RUN) // simulation
{
if (!ctx.tx.getSignature().empty())
std::optional<Slice> const signature = sigObject[~sfTxnSignature];
if (signature && !signature->empty())
{
// NOTE: This code should never be hit because it's checked in the
// `simulate` RPC
return temINVALID; // LCOV_EXCL_LINE
}
if (!ctx.tx.isFieldPresent(sfSigners))
if (!sigObject.isFieldPresent(sfSigners))
{
// no signers, no signature - a valid simulation
return tesSUCCESS;
}
for (auto const& signer : ctx.tx.getFieldArray(sfSigners))
for (auto const& signer : sigObject.getFieldArray(sfSigners))
{
if (signer.isFieldPresent(sfTxnSignature) &&
!signer[sfTxnSignature].empty())
@@ -144,7 +145,8 @@ preflightCheckSimulateKeys(
}
}
if (!ctx.tx.getSigningPubKey().empty())
Slice const signingPubKey = sigObject[sfSigningPubKey];
if (!signingPubKey.empty())
{
// trying to single-sign _and_ multi-sign a transaction
return temINVALID;