AI review feedback: function overload, merge error, clarify comment

include/xrpl/protocol/Rules.h

@@ -35,7 +35,20 @@ namespace ripple {
  * context.
  */
 bool
-isFeatureEnabled(uint256 const& feature, bool resultIfNoRules = false);
+isFeatureEnabled(uint256 const& feature, bool resultIfNoRules);
+
+/** Check whether a feature is enabled in the current ledger rules
+ *
+ * @param feature The feature to be tested.
+ *
+ * Returns false if no global Rules object is available. i.e. Outside of
+ * a Transactor context
+ */
+bool
+isFeatureEnabled(uint256 const& feature)
+{
+    return isFeatureEnabled(feature, false);
+}
 
 class DigestAwareReadView;
 

src/test/app/Invariants_test.cpp

@@ -124,7 +124,7 @@ class Invariants_test : public beast::unit_test::suite
             jlog};
 
         // Invariants normally run in the Transaction's "apply" (operator())
-        // context, and can access global Rules. (Not dependent on amendments.)
+        // context, and can always access global Rules.
         CurrentTransactionRulesGuard const rg(ov.rules());
 
         BEAST_EXPECT(precheck(A1, A2, ac));

src/xrpld/app/tx/detail/InvariantCheck.cpp

@@ -413,7 +413,6 @@ NoZeroEscrow::visitEntry(
         if (auto const locked = (*after)[~sfLockedAmount])
         {
             checkAmount(*locked);
-            bad_ = outstanding < *locked;
             bool const isBad = outstanding < *locked;
             if (overwriteFixEnabled)
                 bad_ |= isBad;