ARCHIVE/hpcore
1
0
Fork 0
mirror of https://github.com/EvernodeXRPL/hpcore.git synced 2026-04-29 15:37:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do a chmod to avoid umask (#377)

Browse Source
This commit is contained in:
Chalith Desaman
2023-07-05 11:07:39 +05:30
committed by GitHub
parent b8b8de662d
commit 29c8201974
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/hpfs/hpfs_sync.cpp
View File

@@ -769,7 +769,11 @@ namespace hpfs
{
if (!is_dir && errno == ENOENT) // File does not exist. So we must create it with the given 'mode'.
{
if (mknod(physical_path.data(), full_mode, 0) == -1)
// The permissions of a created file are restricted by the process's current umask, so group and world write are always disabled by default.
// We do the chmod seperatly after mknod the file. Because if we give the g+w permission in mknod() mode param,
// The file won't get that permission because of the above mentioned default umask.
if (mknod(physical_path.data(), full_mode, 0) == -1 || chmod(physical_path.data(), mode) == -1)
{
LOG_ERROR << errno << ": Error in creating file node. " << physical_path;
return -1;