chore: Delete duplicate etlng tests (#2920)

.github/workflows/build.yml

@@ -23,6 +23,7 @@ on:
       - "cmake/**"
       - "src/**"
       - "tests/**"
+      - "benchmarks/**"
 
       - docs/config-description.md
   workflow_dispatch:

.github/workflows/check-libxrpl.yml

@@ -29,7 +29,7 @@ jobs:
           fetch-depth: 0
 
       - name: Prepare runner
-        uses: XRPLF/actions/prepare-runner@f05cab7b8541eee6473aa42beb9d2fe35608a190
+        uses: XRPLF/actions/prepare-runner@e8d2d2a546a03e1d161dca52890705f3bc641215
         with:
           enable_ccache: false
 

.github/workflows/clang-tidy.yml

@@ -44,7 +44,7 @@ jobs:
           fetch-depth: 0
 
       - name: Prepare runner
-        uses: XRPLF/actions/prepare-runner@f05cab7b8541eee6473aa42beb9d2fe35608a190
+        uses: XRPLF/actions/prepare-runner@e8d2d2a546a03e1d161dca52890705f3bc641215
         with:
           enable_ccache: false
 

.github/workflows/docs.yml

@@ -27,7 +27,7 @@ jobs:
           lfs: true
 
       - name: Prepare runner
-        uses: XRPLF/actions/prepare-runner@f05cab7b8541eee6473aa42beb9d2fe35608a190
+        uses: XRPLF/actions/prepare-runner@e8d2d2a546a03e1d161dca52890705f3bc641215
         with:
           enable_ccache: false
 

.github/workflows/pre-commit.yml

@@ -8,7 +8,7 @@ on:
 
 jobs:
   run-hooks:
-    uses: XRPLF/actions/.github/workflows/pre-commit.yml@282890f46d6921249d5659dd38babcb0bd8aef48
+    uses: XRPLF/actions/.github/workflows/pre-commit.yml@01163508e81d7dd63d4601d4090b297a260b18c2
     with:
       runs_on: heavy
       container: '{ "image": "ghcr.io/xrplf/clio-pre-commit:14342e087ceb8b593027198bf9ef06a43833c696" }'

.github/workflows/reusable-build.yml

@@ -95,7 +95,7 @@ jobs:
           fetch-depth: 0
 
       - name: Prepare runner
-        uses: XRPLF/actions/prepare-runner@f05cab7b8541eee6473aa42beb9d2fe35608a190
+        uses: XRPLF/actions/prepare-runner@e8d2d2a546a03e1d161dca52890705f3bc641215
         with:
           enable_ccache: ${{ inputs.download_ccache }}
 

.github/workflows/reusable-release.yml

@@ -60,7 +60,7 @@ jobs:
           fetch-depth: 0
 
       - name: Prepare runner
-        uses: XRPLF/actions/prepare-runner@f05cab7b8541eee6473aa42beb9d2fe35608a190
+        uses: XRPLF/actions/prepare-runner@e8d2d2a546a03e1d161dca52890705f3bc641215
         with:
           enable_ccache: false
 

.github/workflows/reusable-test.yml

@@ -126,17 +126,17 @@ jobs:
         if: ${{ runner.os == 'macOS' }}
         uses: XRPLF/actions/cleanup-workspace@cf0433aa74563aead044a1e395610c96d65a37cf
 
-      - name: Restart colima
+      - name: Delete and start colima (macOS)
+        # This is a temporary workaround for colima issues on macOS runners
         if: ${{ runner.os == 'macOS' }}
         run: |
           colima delete --force
           colima start
 
-      - name: Spin up scylladb
+      - name: Spin up scylladb (macOS)
         if: ${{ runner.os == 'macOS' }}
-        timeout-minutes: 3
+        timeout-minutes: 1
         run: |
-          docker rm --force scylladb || true
           docker run \
             --detach \
             --name scylladb \
@@ -148,8 +148,12 @@ jobs:
             --memory 16G \
             scylladb/scylla
 
+      - name: Wait for scylladb container to be healthy (macOS)
+        if: ${{ runner.os == 'macOS' }}
+        timeout-minutes: 1
+        run: |
           until [ "$(docker inspect -f '{{.State.Health.Status}}' scylladb)" == "healthy" ]; do
-            sleep 5
+            sleep 1
           done
 
       - uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0

.github/workflows/upload-conan-deps.yml

@@ -78,7 +78,7 @@ jobs:
       - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
 
       - name: Prepare runner
-        uses: XRPLF/actions/prepare-runner@f05cab7b8541eee6473aa42beb9d2fe35608a190
+        uses: XRPLF/actions/prepare-runner@e8d2d2a546a03e1d161dca52890705f3bc641215
         with:
           enable_ccache: false
 

.gitignore

@@ -4,6 +4,7 @@
 .build
 .cache
 .vscode
+.zed
 .python-version
 .DS_Store
 .sanitizer-report

benchmarks/CMakeLists.txt

@@ -16,5 +16,5 @@ target_sources(
 include(deps/gbench)
 
 target_include_directories(clio_benchmark PRIVATE .)
-target_link_libraries(clio_benchmark PUBLIC clio_util clio_rpc benchmark::benchmark_main spdlog::spdlog)
+target_link_libraries(clio_benchmark PRIVATE clio_rpc clio_util benchmark::benchmark_main spdlog::spdlog)
 set_target_properties(clio_benchmark PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR})

benchmarks/rpc/WorkQueueBenchmarks.cpp

@@ -29,8 +29,6 @@
 
 #include <benchmark/benchmark.h>
 #include <boost/asio/steady_timer.hpp>
-#include <boost/asio/thread_pool.hpp>
-#include <boost/json/object.hpp>
 
 #include <algorithm>
 #include <atomic>

tests/unit/data/AmendmentCenterTests.cpp

@@ -32,8 +32,8 @@
 #include <xrpl/protocol/Indexes.h>
 
 #include <algorithm>
+#include <functional>
 #include <optional>
-#include <stdexcept>
 #include <string>
 #include <vector>
 

tests/unit/etlng/LedgerPublisherTests.cpp

@@ -1,356 +0,0 @@
-//------------------------------------------------------------------------------
-/*
-    This file is part of clio: https://github.com/XRPLF/clio
-    Copyright (c) 2025, the clio developers.
-
-    Permission to use, copy, modify, and distribute this software for any
-    purpose with or without fee is hereby granted, provided that the above
-    copyright notice and this permission notice appear in all copies.
-
-    THE  SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
-    WITH  REGARD  TO  THIS  SOFTWARE  INCLUDING  ALL  IMPLIED  WARRANTIES  OF
-    MERCHANTABILITY  AND  FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
-    ANY  SPECIAL,  DIRECT,  INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
-    WHATSOEVER  RESULTING  FROM  LOSS  OF USE, DATA OR PROFITS, WHETHER IN AN
-    ACTION  OF  CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
-    OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
-*/
-//==============================================================================
-
-#include "data/DBHelpers.hpp"
-#include "data/Types.hpp"
-#include "etl/SystemState.hpp"
-#include "util/AsioContextTestFixture.hpp"
-#include "util/MockBackendTestFixture.hpp"
-#include "util/MockPrometheus.hpp"
-#include "util/MockSubscriptionManager.hpp"
-#include "util/TestObject.hpp"
-#include "util/config/ConfigDefinition.hpp"
-
-#include <etlng/impl/LedgerPublisher.hpp>
-#include <fmt/format.h>
-#include <gmock/gmock.h>
-#include <gtest/gtest.h>
-#include <xrpl/basics/chrono.h>
-#include <xrpl/protocol/Indexes.h>
-#include <xrpl/protocol/LedgerHeader.h>
-
-#include <chrono>
-#include <optional>
-#include <vector>
-
-using namespace testing;
-using namespace etlng;
-using namespace data;
-using namespace std::chrono;
-
-namespace {
-
-constexpr auto kACCOUNT = "rf1BiGeXwwQoi8Z2ueFYTEXSwuJYfV2Jpn";
-constexpr auto kACCOUNT2 = "rLEsXccBGNR3UPuPu2hUXPjziKC3qKSBun";
-constexpr auto kLEDGER_HASH = "4BC50C9B0D8515D3EAAE1E74B29A95804346C491EE1A95BF25E4AAB854A6A652";
-constexpr auto kSEQ = 30;
-constexpr auto kAGE = 800;
-constexpr auto kAMOUNT = 100;
-constexpr auto kFEE = 3;
-constexpr auto kFINAL_BALANCE = 110;
-constexpr auto kFINAL_BALANCE2 = 30;
-
-MATCHER_P(ledgerHeaderMatcher, expectedHeader, "Headers match")
-{
-    return arg.seq == expectedHeader.seq && arg.hash == expectedHeader.hash &&
-        arg.closeTime == expectedHeader.closeTime;
-}
-
-}  // namespace
-
-struct ETLLedgerPublisherNgTest : util::prometheus::WithPrometheus, MockBackendTestStrict, SyncAsioContextTest {
-    util::config::ClioConfigDefinition cfg{{}};
-    StrictMockSubscriptionManagerSharedPtr mockSubscriptionManagerPtr;
-};
-
-TEST_F(ETLLedgerPublisherNgTest, PublishLedgerHeaderSkipDueToAge)
-{
-    // Use kAGE (800) which is > MAX_LEDGER_AGE_SECONDS (600) to test skipping
-    auto const dummyLedgerHeader = createLedgerHeader(kLEDGER_HASH, kSEQ, kAGE);
-    auto dummyState = etl::SystemState{};
-    auto publisher = etlng::impl::LedgerPublisher(ctx_, backend_, mockSubscriptionManagerPtr, dummyState);
-
-    backend_->setRange(kSEQ - 1, kSEQ);
-    publisher.publish(dummyLedgerHeader);
-
-    // Verify last published sequence is set immediately
-    EXPECT_TRUE(publisher.getLastPublishedSequence());
-    EXPECT_EQ(publisher.getLastPublishedSequence().value(), kSEQ);
-
-    // Since age > MAX_LEDGER_AGE_SECONDS, these should not be called
-    EXPECT_CALL(*backend_, doFetchLedgerObject).Times(0);
-    EXPECT_CALL(*backend_, fetchAllTransactionsInLedger).Times(0);
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubLedger).Times(0);
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubBookChanges).Times(0);
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubTransaction).Times(0);
-
-    ctx_.run();
-}
-
-TEST_F(ETLLedgerPublisherNgTest, PublishLedgerHeaderWithinAgeLimit)
-{
-    // Use age 0 which is < MAX_LEDGER_AGE_SECONDS to ensure publishing happens
-    auto const dummyLedgerHeader = createLedgerHeader(kLEDGER_HASH, kSEQ, 0);
-    auto dummyState = etl::SystemState{};
-    auto publisher = etlng::impl::LedgerPublisher(ctx_, backend_, mockSubscriptionManagerPtr, dummyState);
-
-    backend_->setRange(kSEQ - 1, kSEQ);
-    publisher.publish(dummyLedgerHeader);
-
-    // Verify last published sequence is set immediately
-    EXPECT_TRUE(publisher.getLastPublishedSequence());
-    EXPECT_EQ(publisher.getLastPublishedSequence().value(), kSEQ);
-
-    EXPECT_CALL(*backend_, doFetchLedgerObject(ripple::keylet::fees().key, kSEQ, _))
-        .WillOnce(Return(createLegacyFeeSettingBlob(1, 2, 3, 4, 0)));
-    EXPECT_CALL(*backend_, fetchAllTransactionsInLedger(kSEQ, _))
-        .WillOnce(Return(std::vector<TransactionAndMetadata>{}));
-
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubLedger(_, _, fmt::format("{}-{}", kSEQ - 1, kSEQ), 0));
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubBookChanges);
-
-    ctx_.run();
-    EXPECT_TRUE(publisher.lastPublishAgeSeconds() <= 1);
-}
-
-TEST_F(ETLLedgerPublisherNgTest, PublishLedgerHeaderIsWritingTrue)
-{
-    auto dummyState = etl::SystemState{};
-    dummyState.isWriting = true;
-    auto const dummyLedgerHeader = createLedgerHeader(kLEDGER_HASH, kSEQ, kAGE);
-    auto publisher = etlng::impl::LedgerPublisher(ctx_, backend_, mockSubscriptionManagerPtr, dummyState);
-    publisher.publish(dummyLedgerHeader);
-
-    EXPECT_TRUE(publisher.getLastPublishedSequence());
-    EXPECT_EQ(publisher.getLastPublishedSequence().value(), kSEQ);
-
-    ctx_.run();
-    EXPECT_FALSE(backend_->fetchLedgerRange());
-}
-
-TEST_F(ETLLedgerPublisherNgTest, PublishLedgerHeaderInRange)
-{
-    auto dummyState = etl::SystemState{};
-    dummyState.isWriting = true;
-
-    auto const dummyLedgerHeader = createLedgerHeader(kLEDGER_HASH, kSEQ, 0);  // age is 0
-    auto publisher = etlng::impl::LedgerPublisher(ctx_, backend_, mockSubscriptionManagerPtr, dummyState);
-    backend_->setRange(kSEQ - 1, kSEQ);
-
-    publisher.publish(dummyLedgerHeader);
-
-    EXPECT_CALL(*backend_, doFetchLedgerObject(ripple::keylet::fees().key, kSEQ, _))
-        .WillOnce(Return(createLegacyFeeSettingBlob(1, 2, 3, 4, 0)));
-
-    TransactionAndMetadata t1;
-    t1.transaction =
-        createPaymentTransactionObject(kACCOUNT, kACCOUNT2, kAMOUNT, kFEE, kSEQ).getSerializer().peekData();
-    t1.metadata = createPaymentTransactionMetaObject(kACCOUNT, kACCOUNT2, kFINAL_BALANCE, kFINAL_BALANCE2)
-                      .getSerializer()
-                      .peekData();
-    t1.ledgerSequence = kSEQ;
-
-    EXPECT_CALL(*backend_, fetchAllTransactionsInLedger).WillOnce(Return(std::vector<TransactionAndMetadata>{t1}));
-
-    EXPECT_TRUE(publisher.getLastPublishedSequence());
-    EXPECT_EQ(publisher.getLastPublishedSequence().value(), kSEQ);
-
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubLedger(_, _, fmt::format("{}-{}", kSEQ - 1, kSEQ), 1));
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubBookChanges);
-    // mock 1 transaction
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubTransaction);
-
-    ctx_.run();
-    EXPECT_TRUE(publisher.lastPublishAgeSeconds() <= 1);
-}
-
-TEST_F(ETLLedgerPublisherNgTest, PublishLedgerHeaderCloseTimeGreaterThanNow)
-{
-    auto dummyState = etl::SystemState{};
-    dummyState.isWriting = true;
-
-    auto dummyLedgerHeader = createLedgerHeader(kLEDGER_HASH, kSEQ, 0);
-    auto const nowPlus10 = system_clock::now() + seconds(10);
-    auto const closeTime = duration_cast<seconds>(nowPlus10.time_since_epoch()).count() - kRIPPLE_EPOCH_START;
-    dummyLedgerHeader.closeTime = ripple::NetClock::time_point{seconds{closeTime}};
-
-    backend_->setRange(kSEQ - 1, kSEQ);
-
-    auto publisher = etlng::impl::LedgerPublisher(ctx_, backend_, mockSubscriptionManagerPtr, dummyState);
-    publisher.publish(dummyLedgerHeader);
-
-    EXPECT_CALL(*backend_, doFetchLedgerObject(ripple::keylet::fees().key, kSEQ, _))
-        .WillOnce(Return(createLegacyFeeSettingBlob(1, 2, 3, 4, 0)));
-
-    TransactionAndMetadata t1;
-    t1.transaction =
-        createPaymentTransactionObject(kACCOUNT, kACCOUNT2, kAMOUNT, kFEE, kSEQ).getSerializer().peekData();
-    t1.metadata = createPaymentTransactionMetaObject(kACCOUNT, kACCOUNT2, kFINAL_BALANCE, kFINAL_BALANCE2)
-                      .getSerializer()
-                      .peekData();
-    t1.ledgerSequence = kSEQ;
-
-    EXPECT_CALL(*backend_, fetchAllTransactionsInLedger(kSEQ, _))
-        .WillOnce(Return(std::vector<TransactionAndMetadata>{t1}));
-
-    EXPECT_TRUE(publisher.getLastPublishedSequence());
-    EXPECT_EQ(publisher.getLastPublishedSequence().value(), kSEQ);
-
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubLedger(_, _, fmt::format("{}-{}", kSEQ - 1, kSEQ), 1));
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubBookChanges);
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubTransaction);
-
-    ctx_.run();
-    EXPECT_TRUE(publisher.lastPublishAgeSeconds() <= 1);
-}
-
-TEST_F(ETLLedgerPublisherNgTest, PublishLedgerSeqStopIsTrue)
-{
-    auto dummyState = etl::SystemState{};
-    dummyState.isStopping = true;
-    auto publisher = etlng::impl::LedgerPublisher(ctx_, backend_, mockSubscriptionManagerPtr, dummyState);
-    EXPECT_FALSE(publisher.publish(kSEQ, {}));
-}
-
-TEST_F(ETLLedgerPublisherNgTest, PublishLedgerSeqMaxAttempt)
-{
-    auto dummyState = etl::SystemState{};
-    dummyState.isStopping = false;
-    auto publisher = etlng::impl::LedgerPublisher(ctx_, backend_, mockSubscriptionManagerPtr, dummyState);
-
-    static constexpr auto kMAX_ATTEMPT = 2;
-
-    LedgerRange const range{.minSequence = kSEQ - 1, .maxSequence = kSEQ - 1};
-    EXPECT_CALL(*backend_, hardFetchLedgerRange).Times(kMAX_ATTEMPT).WillRepeatedly(Return(range));
-
-    EXPECT_FALSE(publisher.publish(kSEQ, kMAX_ATTEMPT, std::chrono::milliseconds{1}));
-}
-
-TEST_F(ETLLedgerPublisherNgTest, PublishLedgerSeqStopIsFalse)
-{
-    auto dummyState = etl::SystemState{};
-    dummyState.isStopping = false;
-    auto publisher = etlng::impl::LedgerPublisher(ctx_, backend_, mockSubscriptionManagerPtr, dummyState);
-
-    LedgerRange const range{.minSequence = kSEQ, .maxSequence = kSEQ};
-    EXPECT_CALL(*backend_, hardFetchLedgerRange).WillOnce(Return(range));
-
-    auto const dummyLedgerHeader = createLedgerHeader(kLEDGER_HASH, kSEQ, kAGE);
-    EXPECT_CALL(*backend_, fetchLedgerBySequence(kSEQ, _)).WillOnce(Return(dummyLedgerHeader));
-
-    EXPECT_TRUE(publisher.publish(kSEQ, {}));
-    ctx_.run();
-}
-
-TEST_F(ETLLedgerPublisherNgTest, PublishMultipleTxInOrder)
-{
-    auto dummyState = etl::SystemState{};
-    dummyState.isWriting = true;
-
-    auto const dummyLedgerHeader = createLedgerHeader(kLEDGER_HASH, kSEQ, 0);  // age is 0
-    auto publisher = etlng::impl::LedgerPublisher(ctx_, backend_, mockSubscriptionManagerPtr, dummyState);
-    backend_->setRange(kSEQ - 1, kSEQ);
-
-    publisher.publish(dummyLedgerHeader);
-
-    EXPECT_CALL(*backend_, doFetchLedgerObject(ripple::keylet::fees().key, kSEQ, _))
-        .WillOnce(Return(createLegacyFeeSettingBlob(1, 2, 3, 4, 0)));
-
-    // t1 index > t2 index
-    TransactionAndMetadata t1;
-    t1.transaction =
-        createPaymentTransactionObject(kACCOUNT, kACCOUNT2, kAMOUNT, kFEE, kSEQ).getSerializer().peekData();
-    t1.metadata = createPaymentTransactionMetaObject(kACCOUNT, kACCOUNT2, kFINAL_BALANCE, kFINAL_BALANCE2, 2)
-                      .getSerializer()
-                      .peekData();
-    t1.ledgerSequence = kSEQ;
-    t1.date = 1;
-    TransactionAndMetadata t2;
-    t2.transaction =
-        createPaymentTransactionObject(kACCOUNT, kACCOUNT2, kAMOUNT, kFEE, kSEQ).getSerializer().peekData();
-    t2.metadata = createPaymentTransactionMetaObject(kACCOUNT, kACCOUNT2, kFINAL_BALANCE, kFINAL_BALANCE2, 1)
-                      .getSerializer()
-                      .peekData();
-    t2.ledgerSequence = kSEQ;
-    t2.date = 2;
-
-    EXPECT_CALL(*backend_, fetchAllTransactionsInLedger(kSEQ, _))
-        .WillOnce(Return(std::vector<TransactionAndMetadata>{t1, t2}));
-
-    EXPECT_TRUE(publisher.getLastPublishedSequence());
-    EXPECT_EQ(publisher.getLastPublishedSequence().value(), kSEQ);
-
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubLedger(_, _, fmt::format("{}-{}", kSEQ - 1, kSEQ), 2));
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubBookChanges);
-
-    Sequence const s;
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubTransaction(t2, _)).InSequence(s);
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubTransaction(t1, _)).InSequence(s);
-
-    ctx_.run();
-    EXPECT_TRUE(publisher.lastPublishAgeSeconds() <= 1);
-}
-
-TEST_F(ETLLedgerPublisherNgTest, PublishVeryOldLedgerShouldSkip)
-{
-    auto dummyState = etl::SystemState{};
-    dummyState.isWriting = true;
-
-    // Create a ledger header with age (800) greater than MAX_LEDGER_AGE_SECONDS (600)
-    auto const dummyLedgerHeader = createLedgerHeader(kLEDGER_HASH, kSEQ, 800);
-    auto publisher = etlng::impl::LedgerPublisher(ctx_, backend_, mockSubscriptionManagerPtr, dummyState);
-    backend_->setRange(kSEQ - 1, kSEQ);
-
-    publisher.publish(dummyLedgerHeader);
-
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubLedger).Times(0);
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubBookChanges).Times(0);
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubTransaction).Times(0);
-
-    EXPECT_TRUE(publisher.getLastPublishedSequence());
-    EXPECT_EQ(publisher.getLastPublishedSequence().value(), kSEQ);
-
-    ctx_.run();
-}
-
-TEST_F(ETLLedgerPublisherNgTest, PublishMultipleLedgersInQuickSuccession)
-{
-    auto dummyState = etl::SystemState{};
-    dummyState.isWriting = true;
-
-    auto const dummyLedgerHeader1 = createLedgerHeader(kLEDGER_HASH, kSEQ, 0);
-    auto const dummyLedgerHeader2 = createLedgerHeader(kLEDGER_HASH, kSEQ + 1, 0);
-    auto publisher = etlng::impl::LedgerPublisher(ctx_, backend_, mockSubscriptionManagerPtr, dummyState);
-    backend_->setRange(kSEQ - 1, kSEQ + 1);
-
-    // Publish two ledgers in quick succession
-    publisher.publish(dummyLedgerHeader1);
-    publisher.publish(dummyLedgerHeader2);
-
-    EXPECT_CALL(*backend_, doFetchLedgerObject(ripple::keylet::fees().key, kSEQ, _))
-        .WillOnce(Return(createLegacyFeeSettingBlob(1, 2, 3, 4, 0)));
-    EXPECT_CALL(*backend_, doFetchLedgerObject(ripple::keylet::fees().key, kSEQ + 1, _))
-        .WillOnce(Return(createLegacyFeeSettingBlob(1, 2, 3, 4, 0)));
-
-    EXPECT_CALL(*backend_, fetchAllTransactionsInLedger(kSEQ, _))
-        .WillOnce(Return(std::vector<TransactionAndMetadata>{}));
-    EXPECT_CALL(*backend_, fetchAllTransactionsInLedger(kSEQ + 1, _))
-        .WillOnce(Return(std::vector<TransactionAndMetadata>{}));
-
-    Sequence const s;
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubLedger(ledgerHeaderMatcher(dummyLedgerHeader1), _, _, _)).InSequence(s);
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubBookChanges(ledgerHeaderMatcher(dummyLedgerHeader1), _)).InSequence(s);
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubLedger(ledgerHeaderMatcher(dummyLedgerHeader2), _, _, _)).InSequence(s);
-    EXPECT_CALL(*mockSubscriptionManagerPtr, pubBookChanges(ledgerHeaderMatcher(dummyLedgerHeader2), _)).InSequence(s);
-
-    EXPECT_TRUE(publisher.getLastPublishedSequence());
-    EXPECT_EQ(publisher.getLastPublishedSequence().value(), kSEQ + 1);
-
-    ctx_.run();
-}