[CI] clang-tidy auto fixes (#1099)

Fixes #1098. Fixes #1100.

---------

Co-authored-by: kuznetsss <kuznetsss@users.noreply.github.com>
Co-authored-by: Sergey Kuznetsov <skuznetsov@ripple.com>

.github/workflows/clang-tidy.yml

@@ -58,6 +58,12 @@ jobs:
         run: |
           run-clang-tidy-17 -p build -j ${{ steps.number_of_threads.outputs.threads_number }} -fix -quiet 1>output.txt
 
+      - name: Run pre-commit hook
+        if: ${{ steps.run_clang_tidy.outcome != 'success' }}
+        continue-on-error: true
+        shell: bash
+        run: ./.githooks/pre-commit
+
       - name: Print issues found
         if: ${{ steps.run_clang_tidy.outcome != 'success' }}
         shell: bash

src/rpc/AMMHelpers.cpp

@@ -20,9 +20,18 @@
 #include "rpc/AMMHelpers.h"
 
 #include "data/BackendInterface.h"
-#include "util/log/Logger.h"
+#include "rpc/RPCHelpers.h"
 
+#include <boost/asio/spawn.hpp>
 #include <ripple/protocol/AMMCore.h>
+#include <ripple/protocol/AccountID.h>
+#include <ripple/protocol/Issue.h>
+#include <ripple/protocol/SField.h>
+#include <ripple/protocol/STLedgerEntry.h>
+#include <ripple/protocol/UintTypes.h>
+
+#include <cstdint>
+#include <utility>
 
 namespace rpc {
 

src/rpc/common/Concepts.h

@@ -28,8 +28,6 @@
 
 namespace rpc {
 
-struct RpcSpec;
-
 /**
  * @brief Specifies what a requirement used with @ref rpc::FieldSpec must provide.
  */

src/rpc/common/Validators.cpp

@@ -20,6 +20,7 @@
 #include "rpc/common/Validators.h"
 
 #include "rpc/Errors.h"
+#include "rpc/JS.h"
 #include "rpc/RPCHelpers.h"
 #include "rpc/common/Types.h"
 
@@ -27,13 +28,17 @@
 #include <boost/json/value.hpp>
 #include <fmt/core.h>
 #include <ripple/basics/base_uint.h>
+#include <ripple/json/json_value.h>
 #include <ripple/protocol/AccountID.h>
 #include <ripple/protocol/ErrorCodes.h>
+#include <ripple/protocol/Issue.h>
 #include <ripple/protocol/UintTypes.h>
+#include <ripple/protocol/jss.h>
 #include <ripple/protocol/tokens.h>
 
 #include <charconv>
 #include <cstdint>
+#include <stdexcept>
 #include <string>
 #include <string_view>
 #include <system_error>

src/rpc/common/impl/Processors.h

@@ -19,10 +19,12 @@
 
 #pragma once
 
-#include "rpc/common/APIVersion.h"
 #include "rpc/common/Concepts.h"
+#include "rpc/common/Specs.h"
 #include "rpc/common/Types.h"
 
+#include <boost/json/value.hpp>
+
 namespace rpc::detail {
 
 template <typename>

src/rpc/handlers/AMMInfo.cpp

@@ -21,12 +21,44 @@
 
 #include "data/DBHelpers.h"
 #include "rpc/AMMHelpers.h"
+#include "rpc/Errors.h"
+#include "rpc/JS.h"
 #include "rpc/RPCHelpers.h"
 #include "rpc/common/MetaProcessors.h"
 #include "rpc/common/Specs.h"
+#include "rpc/common/Types.h"
 #include "rpc/common/Validators.h"
 
+#include <boost/json/array.hpp>
+#include <boost/json/conversion.hpp>
+#include <boost/json/object.hpp>
+#include <boost/json/value.hpp>
+#include <date/date.h>
+#include <ripple/basics/base_uint.h>
+#include <ripple/basics/chrono.h>
+#include <ripple/basics/strHex.h>
 #include <ripple/protocol/AMMCore.h>
+#include <ripple/protocol/AccountID.h>
+#include <ripple/protocol/ErrorCodes.h>
+#include <ripple/protocol/Indexes.h>
+#include <ripple/protocol/Issue.h>
+#include <ripple/protocol/LedgerHeader.h>
+#include <ripple/protocol/SField.h>
+#include <ripple/protocol/STAmount.h>
+#include <ripple/protocol/STBase.h>
+#include <ripple/protocol/STLedgerEntry.h>
+#include <ripple/protocol/Serializer.h>
+#include <ripple/protocol/UintTypes.h>
+#include <ripple/protocol/jss.h>
+#include <ripple/protocol/tokens.h>
+
+#include <chrono>
+#include <cstdint>
+#include <stdexcept>
+#include <string>
+#include <string_view>
+#include <utility>
+#include <variant>
 
 namespace {
 

src/rpc/handlers/AMMInfo.h

@@ -46,7 +46,7 @@ public:
         std::optional<bool> asset2Frozen;
 
         std::string ledgerHash;
-        uint32_t ledgerIndex;
+        uint32_t ledgerIndex{};
         bool validated = true;
     };
 

unittests/rpc/handlers/AMMInfoTests.cpp

@@ -17,14 +17,30 @@
 */
 //==============================================================================
 
+#include "data/Types.h"
+#include "rpc/Errors.h"
 #include "rpc/common/AnyHandler.h"
-#include "rpc/common/Specs.h"
+#include "rpc/common/Types.h"
 #include "rpc/handlers/AMMInfo.h"
 #include "util/Fixtures.h"
 #include "util/TestObject.h"
 
+#include <boost/json/parse.hpp>
 #include <fmt/core.h>
-#include <ripple/protocol/digest.h>
+#include <gmock/gmock.h>
+#include <gtest/gtest.h>
+#include <ripple/basics/base_uint.h>
+#include <ripple/protocol/AccountID.h>
+#include <ripple/protocol/Indexes.h>
+#include <ripple/protocol/Issue.h>
+#include <ripple/protocol/LedgerFormats.h>
+#include <ripple/protocol/SField.h>
+#include <ripple/protocol/STAmount.h>
+#include <ripple/protocol/UintTypes.h>
+
+#include <optional>
+#include <string>
+#include <vector>
 
 using namespace rpc;
 namespace json = boost::json;

unittests/util/TestObject.cpp

@@ -29,6 +29,7 @@
 #include <ripple/basics/chrono.h>
 #include <ripple/protocol/AMMCore.h>
 #include <ripple/protocol/AccountID.h>
+#include <ripple/protocol/Indexes.h>
 #include <ripple/protocol/Issue.h>
 #include <ripple/protocol/LedgerFormats.h>
 #include <ripple/protocol/LedgerHeader.h>