ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2025-12-06 17:27:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Return lgrIdxsInvalid error for ledger_max_index less than ledger_min_index (#339)

Browse Source 
Fixes #263
This commit is contained in:
Francis Mendoza
2022-11-23 13:38:13 -08:00
committed by GitHub
parent 4b94ed3e55
commit 7bb567761c
1 changed files with 27 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
src/rpc/RPCHelpers.cpp
View File

@@ -1539,47 +1539,54 @@ traverseTransactions(
}
auto minIndex = context.range.minSequence;
auto maxIndex = context.range.maxSequence;
std::optional<int64_t> min;
std::optional<int64_t> max;
if (request.contains(JS(ledger_index_min)))
{
auto& min = request.at(JS(ledger_index_min));
if (!min.is_int64())
if (!request.at(JS(ledger_index_min)).is_int64())
{
return Status{
RippledError::rpcINVALID_PARAMS, "ledgerSeqMinNotNumber"};
}
if (min.as_int64() != -1)
min = request.at(JS(ledger_index_min)).as_int64();
if (*min != -1)
{
if (context.range.maxSequence < min.as_int64() ||
context.range.minSequence > min.as_int64())
if (context.range.maxSequence < *min ||
context.range.minSequence > *min)
return Status{
RippledError::rpcLGR_IDX_MALFORMED,
"ledgerSeqMinOutOfRange"};
else
minIndex = boost::json::value_to<std::uint32_t>(min);
minIndex = static_cast<uint32_t>(*min);
}
if (forward && !cursor)
cursor = {minIndex, 0};
}
auto maxIndex = context.range.maxSequence;
if (request.contains(JS(ledger_index_max)))
{
auto& max = request.at(JS(ledger_index_max));
if (!max.is_int64())
if (!request.at(JS(ledger_index_max)).is_int64())
{
return Status{
RippledError::rpcINVALID_PARAMS, "ledgerSeqMaxNotNumber"};
}
if (max.as_int64() != -1)
max = request.at(JS(ledger_index_max)).as_int64();
if (*max != -1)
{
if (context.range.maxSequence < max.as_int64() ||
context.range.minSequence > max.as_int64())
if (context.range.maxSequence < *max ||
context.range.minSequence > *max)
return Status{
RippledError::rpcLGR_IDX_MALFORMED,
"ledgerSeqMaxOutOfRange"};
else
maxIndex = boost::json::value_to<std::uint32_t>(max);
maxIndex = static_cast<uint32_t>(*max);
}
if (minIndex > maxIndex)
@@ -1589,6 +1596,11 @@ traverseTransactions(
cursor = {maxIndex, INT32_MAX};
}
if (max && min && *max < *min)
{
return Status{RippledError::rpcLGR_IDXS_INVALID, "lgrIdxsInvalid"};
}
if (request.contains(JS(ledger_index)) || request.contains(JS(ledger_hash)))
{
if (request.contains(JS(ledger_index_max)) ||