ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2026-04-29 15:37:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Return correct error on subscription to non-existing stream (#390)

Browse Source 
Fixes #353
This commit is contained in:
Alex Kremer
2022-11-08 15:42:02 +01:00
committed by GitHub
parent 1f900fcf7f
commit 739dd81981
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/rpc/handlers/Subscribe.cpp
View File

@@ -18,17 +18,14 @@ static std::unordered_set<std::string> validCommonStreams{
Status
validateStreams(boost::json::object const& request)
{
boost::json::array const& streams = request.at(JS(streams)).as_array();
for (auto const& stream : streams)
for (auto const& streams = request.at(JS(streams)).as_array();
auto const& stream : streams)
{
if (!stream.is_string())
return Status{Error::rpcINVALID_PARAMS, "streamNotString"};
std::string s = stream.as_string().c_str();
if (validCommonStreams.find(s) == validCommonStreams.end())
return Status{Error::rpcINVALID_PARAMS, "invalidStream" + s};
if (!validCommonStreams.contains(stream.as_string().c_str()))
return Status{Error::rpcSTREAM_MALFORMED};
}
return OK;