style: clang-tidy auto fixes (#1740)

Fixes #1739. Please review and commit clang-tidy fixes.

Co-authored-by: kuznetsss <15742918+kuznetsss@users.noreply.github.com>

src/etlng/impl/Extraction.cpp

@@ -29,13 +29,8 @@
 #include "util/Profiler.hpp"
 #include "util/log/Logger.hpp"
 
-#include <google/protobuf/repeated_field.h>
-#include <sys/types.h>
 #include <xrpl/basics/Slice.h>
 #include <xrpl/basics/base_uint.h>
-#include <xrpl/proto/org/xrpl/rpc/v1/get_ledger.pb.h>
-#include <xrpl/proto/org/xrpl/rpc/v1/ledger.pb.h>
-#include <xrpl/protocol/LedgerHeader.h>
 #include <xrpl/protocol/STTx.h>
 #include <xrpl/protocol/Serializer.h>
 #include <xrpl/protocol/TxMeta.h>
@@ -147,8 +142,8 @@ model::BookSuccessor
 extractSuccessor(PBBookSuccessorType successor)
 {
     return {
-        .firstBook = std::move(successor.first_book()),
-        .bookBase = std::move(successor.book_base()),
+        .firstBook = successor.first_book(),
+        .bookBase = successor.book_base(),
     };
 }
 

tests/unit/etlng/ExtractionTests.cpp

@@ -28,16 +28,10 @@
 #include <gmock/gmock.h>
 #include <google/protobuf/repeated_ptr_field.h>
 #include <gtest/gtest.h>
-#include <xrpl/basics/Blob.h>
-#include <xrpl/basics/Slice.h>
-#include <xrpl/basics/StringUtilities.h>
-#include <xrpl/basics/base_uint.h>
 #include <xrpl/basics/strHex.h>
 #include <xrpl/proto/org/xrpl/rpc/v1/get_ledger.pb.h>
 #include <xrpl/proto/org/xrpl/rpc/v1/ledger.pb.h>
-#include <xrpl/protocol/LedgerHeader.h>
 #include <xrpl/protocol/STTx.h>
-#include <xrpl/protocol/Serializer.h>
 #include <xrpl/protocol/TxFormats.h>
 #include <xrpl/protocol/TxMeta.h>
 

tests/unit/etlng/RegistryTests.cpp

@@ -25,11 +25,7 @@
 
 #include <gmock/gmock.h>
 #include <gtest/gtest.h>
-#include <xrpl/basics/base_uint.h>
-#include <xrpl/protocol/STTx.h>
-#include <xrpl/protocol/Serializer.h>
 #include <xrpl/protocol/TxFormats.h>
-#include <xrpl/protocol/TxMeta.h>
 
 #include <cstdint>
 #include <string>