ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2025-11-20 11:45:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

return error on negative limit (#394)

Browse Source
This commit is contained in:
CJ Cobb
2022-11-08 14:41:18 -05:00
committed by GitHub
parent 739dd81981
commit 486f1f2fd2
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/rpc/RPC.cpp
View File

@@ -325,14 +325,15 @@ getLimit(RPC::Context const& context, std::uint32_t& limit)
if (context.params.contains(JS(limit))) if (context.params.contains(JS(limit)))
{ {
std::string errMsg = "Invalid field 'limit', not unsigned integer.";
if (!context.params.at(JS(limit)).is_int64()) if (!context.params.at(JS(limit)).is_int64())
return Status{Error::rpcINVALID_PARAMS, "limitNotInt"}; return Status{Error::rpcINVALID_PARAMS, errMsg};
limit = context.params.at(JS(limit)).as_int64(); int input = context.params.at(JS(limit)).as_int64();
if (limit <= 0) if (input <= 0)
return Status{Error::rpcINVALID_PARAMS, "limitNotPositive"}; return Status{Error::rpcINVALID_PARAMS, errMsg};
limit = std::clamp(limit, lo, hi); limit = std::clamp(static_cast<std::uint32_t>(input), lo, hi);
} }
else else
{ {