fix comments

docs/config-description.md

@@ -95,7 +95,7 @@ This document provides a list of all available Clio configuration properties in
 - **Type**: string
 - **Default value**: `cassandra`
 - **Constraints**: The value must be one of the following: `cassandra`, `aws_keyspace`.
-- **Description**: The specific database backend provider we are using. Currently we only support cassandra, or aws_keyspace.
+- **Description**: The specific database backend provider we are using.
 
 ### database.cassandra.core_connections_per_host
 

src/data/CassandraBackend.hpp

@@ -225,9 +225,9 @@ public:
     {
         waitForWritesToFinish();
 
-        // !range means the table 'ledger_range' is not populated it; This would be first write to the table
-        // In this case, insert both min_sequence/max_sequence range into the table
-        if (!range_) {
+        // !range_.has_value() means the table 'ledger_range' is not populated; This would be the first write to the
+        // table In this case, insert both min_sequence/max_sequence range into the table
+        if (!range_.has_value()) {
             executor_.writeSync(schema_->insertLedgerRange, false, ledgerSequence_);
             executor_.writeSync(schema_->insertLedgerRange, true, ledgerSequence_);
         }
@@ -517,11 +517,9 @@ public:
     ) const override
     {
         std::vector<ripple::uint256> nftIDs;
-        // --- A specific taxon is requested ---
         if (taxon.has_value()) {
             nftIDs = fetchNFTIDsByTaxon(issuer, *taxon, limit, cursorIn, yield);
         } else {
-            // --- No taxon is specified (general pagination) ---
             nftIDs = fetchNFTIDsWithoutTaxon(issuer, limit, cursorIn, yield);
         }
 

src/data/cassandra/impl/Cluster.hpp

@@ -45,7 +45,7 @@ struct Settings {
     static constexpr uint32_t kDEFAULT_MAX_WRITE_REQUESTS_OUTSTANDING = 10'000;
     static constexpr uint32_t kDEFAULT_MAX_READ_REQUESTS_OUTSTANDING = 100'000;
     static constexpr std::size_t kDEFAULT_BATCH_SIZE = 20;
-    static constexpr std::string kDEFAULT_PROVIDER = "scylladb";
+    static constexpr std::string kDEFAULT_PROVIDER = "cassandra";
 
     /**
      * @brief Represents the configuration of contact points for cassandra.

src/util/config/ConfigDescription.hpp

@@ -173,9 +173,7 @@ This document provides a list of all available Clio configuration properties in
                "Maximum number of outstanding read requests. Read requests are API calls that read from the database."},
         KV{.key = "database.cassandra.threads",
            .value = "Represents the number of threads that will be used for database operations."},
-        KV{.key = "database.cassandra.provider",
-           .value = "The specific database backend provider we are using. Currently we only support cassandra, or "
-                    "aws_keyspace."},
+        KV{.key = "database.cassandra.provider", .value = "The specific database backend provider we are using."},
         KV{.key = "database.cassandra.core_connections_per_host",
            .value = "The number of core connections per host for the Cassandra database."},
         KV{.key = "database.cassandra.queue_size_io",

tests/integration/data/BackendFactoryTests.cpp

@@ -44,6 +44,7 @@ using namespace util::config;
 
 struct BackendCassandraFactoryTest : SyncAsioContextTest, util::prometheus::WithPrometheus {
     static constexpr auto kKEYSPACE = "factory_test";
+    static constexpr auto kPROVIDER = "cassandra";
 
 protected:
     ClioConfigDefinition cfg_{
@@ -53,7 +54,7 @@ protected:
         {"database.cassandra.secure_connect_bundle", ConfigValue{ConfigType::String}.optional()},
         {"database.cassandra.port", ConfigValue{ConfigType::Integer}.optional()},
         {"database.cassandra.keyspace", ConfigValue{ConfigType::String}.defaultValue(kKEYSPACE)},
-        {"database.cassandra.provider", ConfigValue{ConfigType::String}.defaultValue("cassandra")},
+        {"database.cassandra.provider", ConfigValue{ConfigType::String}.defaultValue(kPROVIDER)},
         {"database.cassandra.replication_factor", ConfigValue{ConfigType::Integer}.defaultValue(1)},
         {"database.cassandra.table_prefix", ConfigValue{ConfigType::String}.optional()},
         {"database.cassandra.max_write_requests_outstanding", ConfigValue{ConfigType::Integer}.defaultValue(10'000)},