ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2026-06-02 16:26:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix missing "validated" (#778)

Browse Source 
Fixes #779
This commit is contained in:
cyan317
2023-07-18 10:52:22 +01:00
committed by GitHub
parent 12178abf4d
commit 2336148d0d
2 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/rpc/handlers/NoRippleCheck.cpp
View File

@@ -190,6 +190,7 @@ tag_invoke(boost::json::value_from_tag, boost::json::value& jv, NoRippleCheckHan
{JS(ledger_hash), output.ledgerHash},
{JS(ledger_index), output.ledgerIndex},
{"problems", output.problems},
{JS(validated), output.validated},
};
if (output.transactions)

15
unittests/rpc/handlers/NoRippleCheckTest.cpp
View File

@@ -269,7 +269,8 @@ TEST_F(RPCNoRippleCheckTest, NormalPathRoleUserDefaultRippleSetTrustLineNoRipple
"problems":
[
"You appear to have set your default ripple flag even though you are not a gateway. This is not recommended unless you are experimenting"
]
],
"validated":true
})";
MockBackend* rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
mockBackendPtr->updateRange(10); // min
@@ -328,7 +329,8 @@ TEST_F(RPCNoRippleCheckTest, NormalPathRoleUserDefaultRippleUnsetTrustLineNoRipp
"problems":[
"You should probably set the no ripple flag on your USD line to rLEsXccBGNR3UPuPu2hUXPjziKC3qKSBun",
"You should probably set the no ripple flag on your USD line to rLEsXccBGNR3UPuPu2hUXPjziKC3qKSBun"
]
],
"validated":true
})";
MockBackend* rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
mockBackendPtr->updateRange(10); // min
@@ -386,7 +388,8 @@ TEST_F(RPCNoRippleCheckTest, NormalPathRoleGatewayDefaultRippleSetTrustLineNoRip
[
"You should clear the no ripple flag on your USD line to rLEsXccBGNR3UPuPu2hUXPjziKC3qKSBun",
"You should clear the no ripple flag on your USD line to rLEsXccBGNR3UPuPu2hUXPjziKC3qKSBun"
]
],
"validated":true
})";
MockBackend* rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
mockBackendPtr->updateRange(10); // min
@@ -445,7 +448,8 @@ TEST_F(RPCNoRippleCheckTest, NormalPathRoleGatewayDefaultRippleUnsetTrustLineNoR
"problems":
[
"You should immediately set your default ripple flag"
]
],
"validated":true
})";
MockBackend* rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
mockBackendPtr->updateRange(10); // min
@@ -640,7 +644,8 @@ TEST_F(RPCNoRippleCheckTest, NormalPathTransactions)
}},
"Flags":{}
}}
]
],
"validated":true
}})",
transactionSeq,
transactionSeq + 1,