ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2026-08-23 21:50:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

style: Fix lint comments due to style changes (#2963)

Browse Source
This commit is contained in:
Ayaz Salikhov
2026-02-23 16:24:27 +00:00
committed by GitHub
parent e9052bcd80
commit 1220d632b5
3 changed files with 13 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/etl/NFTHelpers.cpp
View File

@@ -137,20 +137,19 @@ getNFTokenMintData(ripple::TxMeta const& txMeta, ripple::STTx const& sttx)
// Find the first NFT ID that doesn't match. We're looking for an
// added NFT, so the one we want will be the mismatch in finalIDs.
// NOLINTNEXTLINE(modernize-use-ranges)
auto const diff = std::ranges::mismatch(finalIDs, prevIDs);
auto const [finalMismatch, prevMismatch] = std::ranges::mismatch(finalIDs, prevIDs);
// There should always be a difference so the returned finalIDs
// iterator should never be end(). But better safe than sorry.
if (finalIDs.size() != prevIDs.size() + 1 || diff.in1 == finalIDs.end() || !owner) {
if (finalIDs.size() != prevIDs.size() + 1 || finalMismatch == finalIDs.end() || !owner) {
throw std::runtime_error(
fmt::format(" - unexpected NFTokenMint data in tx {}", strHex(sttx.getTransactionID()))
);
}
return {
{NFTTransactionsData(*diff.in1, txMeta, sttx.getTransactionID())},
NFTsData(*diff.in1, *owner, sttx.getFieldVL(ripple::sfURI), txMeta)
{NFTTransactionsData(*finalMismatch, txMeta, sttx.getTransactionID())},
NFTsData(*finalMismatch, *owner, sttx.getFieldVL(ripple::sfURI), txMeta)
};
}

12
tests/unit/app/CliArgsTests.cpp
View File

@@ -116,8 +116,10 @@ TEST_F(CliArgsTests, Parse_Config)
{
std::string_view configPath = "some_config_path";
std::array argv{
"clio_server", "--conf", configPath.data()
}; // NOLINT(bugprone-suspicious-stringview-data-usage)
"clio_server",
"--conf",
configPath.data() // NOLINT(bugprone-suspicious-stringview-data-usage)
};
auto const action = CliArgs::parse(argv.size(), argv.data());
int const returnCode = 123;
@@ -140,8 +142,10 @@ TEST_F(CliArgsTests, Parse_VerifyConfig)
{
std::string_view configPath = "some_config_path";
std::array argv{
"clio_server", configPath.data(), "--verify"
}; // NOLINT(bugprone-suspicious-stringview-data-usage)
"clio_server",
configPath.data(), // NOLINT(bugprone-suspicious-stringview-data-usage)
"--verify"
};
auto const action = CliArgs::parse(argv.size(), argv.data());
int const returnCode = 123;

3
tests/unit/web/RPCServerHandlerTests.cpp
View File

@@ -70,9 +70,8 @@ struct MockWsBase : public web::ConnectionBase {
}
void
// NOLINTNEXTLINE(cppcoreguidelines-rvalue-reference-param-not-moved)
send(
std::string&& msg,
std::string&& msg, // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
boost::beast::http::status status = boost::beast::http::status::ok
) override
{