Commit Graph

186 Commits

Author SHA1 Message Date
jonathanlei
f90d31ffd1 Merge pull request #1673 from AlexanderBuzz/DGE-94_javascript-code-samples_tx_ser
Added tx-serialization JavaScript examples analog to python version
2023-02-03 11:49:33 -08:00
AlexanderBuzz
3b84534b6a - Changed link in xrpl.org/serialization.html from ripple-binary-codec to the code from this PR 2023-01-30 13:06:27 +01:00
mDuo13
b8e37727e2 ledger_entry amm fixes 2023-01-21 04:39:47 -08:00
mDuo13
98a759f455 [DRAFT] updates to ledger_entry for AMM, type filter 2023-01-18 18:01:49 -08:00
Oliver Eggert
bcb28a3b58 Add reviewer fixes 2023-01-18 12:23:15 -08:00
Oliver Eggert
0b3a2c9a16 Fix broken links to amendment blocked servers section 2023-01-15 22:37:48 -08:00
Oliver Eggert
58df747093 Update to match style guide. 2023-01-15 20:45:23 -08:00
Rome Reginelli
281ddc5664 Merge pull request #1659 from wojake/patch-12
escrowcreate.md typo fix
2023-01-04 15:52:05 -08:00
Rome Reginelli
81e34b9997 Merge pull request #1637 from XRPLF/rr-clarify-nftokentaxon
Clarify NFTokenTaxon
2023-01-04 15:51:40 -08:00
Wo Jake
732c32659a escrowcreate.md typo fix 2022-12-26 19:21:56 +08:00
mDuo13
daeabe6c9d Merge branch 'amm_concept' 2022-12-16 14:05:00 -08:00
Amarantha Kulkarni
845422da7f Add words from new features such as NFTs to the spell checker (#1615)
* Add words from new features such as NFTs to the spell checker

* Add more proper nouns and general purpose words

* Add more proper nouns and general purpose words

* Update to use backticks

* Update proper nouns and generic words

* Fix style for words based on style checker report

* Style/spelling fixes

* Fix links broken by style/spelling updates

* More edits for style

* Finish updates to get style checker to pass

Co-authored-by: mDuo13 <mduo13@gmail.com>
2022-12-15 14:29:32 -08:00
Rome Reginelli
3286df3cca Clarify NFTokenTaxon
Lathan in Mattermost called out that this line is confusing. I think this rewrite should clear up the confusion. (Note, I'm using "NFT" to get a head start on #1628.)

The note on the maximum value is not necessary because that's the actual hard max of a UInt32 type anyway.
2022-12-14 12:54:18 -08:00
mDuo13
b8794f80f6 AMM: add concept links to more tx types 2022-12-12 20:10:54 -08:00
Michael Legleux
e63f3a60c2 does -> does _not_ 2022-12-12 18:55:55 -08:00
mDuo13
b5478b863e AMM: edit concept, add links to it 2022-12-12 17:28:48 -08:00
Rome Reginelli
7897a9c73a Merge pull request #1619 from XRPLF/rr-fix-amm-trading-fee
AMM: Fix trading fee decimal comparison
2022-12-08 13:48:29 -08:00
Rome Reginelli
4da14c00f4 Merge pull request #1608 from XRPLF/rr-stissue-length
Serialization: fix STIssue definition
2022-12-07 15:58:21 -08:00
Wietse Wind
2924e465e0 Add note about not being able to AccountDelete (tecHAS_OBLIGATIONS) if minted 2022-12-04 01:06:17 +01:00
Rome Reginelli
b2ae59164e AMM: Fix trading fee decimal comparison
"units of 1/100,000" is equivalent to "⅒ basis points" which is correct. This 10,000 number is a carry over from when it was basis points, not ⅒ thereof
2022-12-02 13:53:20 -08:00
oeggert
a271942c1e Merge pull request #1598 from XRPLF/oeggert/issue1554
Add code samples for markers and pagination.
2022-11-29 14:23:58 -08:00
oeggert
ed607d813d Merge pull request #1596 from XRPLF/oeggert/issue1421
Add example links for each transaction type
2022-11-28 15:59:03 -08:00
oeggert
85fec9c23b Update content/references/protocol-reference/transactions/transaction-types/escrowcreate.md
Co-authored-by: Rome Reginelli <rome@ripple.com>
2022-11-28 15:22:46 -08:00
oeggert
9e0d32b223 Update content/references/protocol-reference/transactions/transaction-types/payment.md
Co-authored-by: Rome Reginelli <rome@ripple.com>
2022-11-28 15:21:37 -08:00
Rome Reginelli
68d41fae5a Serialization: fix STIssue definition
Noah from the xrpl4j team noted that the STIssue definition used was wrong in the case of XRP, and the actual implementation has an optimization to drop the second 160 bits in the case where the first 160 bits are XRP.
2022-11-28 14:49:16 -08:00
Oliver Eggert
6c141b50af Change examples to relative links and add blank line before link. 2022-11-23 16:25:18 -08:00
Rome Reginelli
e3a6935cb2 Merge pull request #1541 from XRPLF/amm_ref
Automated Market Maker (XLS-30d) reference documentation
2022-11-23 14:33:21 -08:00
mDuo13
ecb8acfafb Fix AMMDeposit formula 2022-11-22 20:04:30 -08:00
mDuo13
bc752f213d Enable include_code by default 2022-11-22 16:18:30 -08:00
Rome Reginelli
572e0ab3c6 AMM: apply suggestions from review
Co-authored-by: oeggert <117319296+oeggert@users.noreply.github.com>
2022-11-21 22:42:30 -08:00
mDuo13
720a322892 AMM refs: more edits per reviews 2022-11-21 22:40:14 -08:00
mDuo13
abd20d99d9 [JA] serialization, fix link 2022-11-21 22:40:14 -08:00
mDuo13
e2ff0a7d97 AMM doc cleanup
- fix typo in serialization
- add STIssue type to type list in serialization
- more clearly mark things that need to be translated to Japanese
- Put AMMBid & AMMCreate transactions in alphabetical order
2022-11-21 22:40:14 -08:00
mDuo13
ab0b7f78d8 [JA] add untranslated section on AMMs 2022-11-21 22:40:14 -08:00
mDuo13
08bbcc4dd7 AMM reference docs
AMM object: some clarifications

AMM references: incomplete draft

AMM updates

AMM: add AMMBid, clarify more stuff

Docs for AMMBid transaction

AMM: more work on error codes

AMM: example transactions, related upates

Fix broken links

AMM: reflect naming updates

more AMMBid edits

Add amm_info API method

Add style for AMM label

AMM: more clarifications on tx, accounts

AMM references: Clean up draft

amm_info: reflect code updates

AMM: updates for the latest changes

AMM: update flags for Deposit/Withdraw

AMM: update JSON examples for latest code

Serialization: add STIssue type

STIssue: clarify definition with commas
2022-11-21 22:40:12 -08:00
Oliver Eggert
078bd39e7e Fix CheckCash link. 2022-11-21 18:50:54 -08:00
Oliver Eggert
4949f99075 Add remaining permalink examples for transaction types. 2022-11-21 18:42:14 -08:00
Rome Reginelli
1d1c48c319 Remove duplicate UNLModify header. (#1594)
The snippet includes the header so having the header separately is redundant.

Fixes #1590
2022-11-21 08:59:54 -08:00
Oliver Eggert
b7e46c8f11 Added query example transaction buttons. 2022-11-18 20:59:32 -08:00
Oliver Eggert
916a792d00 Add sample query for AccountSet transactions. 2022-11-18 20:30:37 -08:00
mDuo13
67920cc502 [JA] Update number of signers for ExpandedSignerList 2022-10-31 17:42:09 -07:00
mDuo13
c1d79b6529 Fix ExpandedSignerList link 2022-10-31 17:41:17 -07:00
mDuo13
86383ca28d Add example NFTokenOffer, NFTokenAcceptOffer
Fixes #1553 by adding real examples from Mainnet of the NFTokenOffer
object type and NFTokenAcceptOffer transaction type (the offer entry is
no longer in the ledger because it was deleted when the sale was
completed, but you can look it up in ledger 75443623.
2022-10-31 17:32:27 -07:00
mDuo13
4addf5996b Update NFT status 2022-10-31 14:52:40 -07:00
Rome Reginelli
2e5b6637e3 Merge pull request #1536 from develoQ/japanese-nftoken
add Japanese translations of NFT-related pages
2022-10-19 16:34:23 -07:00
mDuo13
41d7334499 [JA] fix broken links 2022-10-19 15:56:37 -07:00
Dennis Dawson
22cf651220 Merge pull request #1526 from mDuo13/fix_nft_bps
NFToken: fix basis points numbers
2022-10-17 18:22:11 -07:00
mDuo13
69b61f7528 NFT fees: Fix 1/10,000 number as well 2022-10-17 16:24:28 -07:00
mDuo13
a14d65d821 NFT: correctly update transfer fee for ⅒bps. 2022-10-17 16:19:11 -07:00
develoQ
b104052085 fix to match XLS-20 spec 2022-10-08 15:22:46 +09:00