ARCHIVE/xrpl-dev-portal
1
0
Fork 0
mirror of https://github.com/XRPLF/xrpl-dev-portal.git synced 2025-11-21 20:25:51 +00:00
Code Issues Packages Projects Releases Wiki Activity
6,507 Commits 28 Branches 32 Tags
08048d1323a66fb9a162c43dba4065e35e8cba8d
Commit Graph

296 Commits

Author SHA1 Message Date
mDuo13
72c18f32e5 Code samples: update includes for moved samples 2022-04-20 14:04:04 -07:00
Dennis Dawson
65dde30676 Fix capitalization of tesSUCCESS 2022-04-14 16:07:15 -07:00
Dennis Dawson
0af2e731cc Merge branch 'master' into dd-NFT-Jira-Fixes20200322 2022-04-14 15:59:43 -07:00
Dennis Dawson
70d45bbc46 Style updates 
Thanks very much for the help, Jackson. I did some tech writing tomfoolery.
 2022-04-11 14:41:36 -07:00
Jackson Mills
eecdc2f53d Fix broken example on NFTokenMint + explain Issuer 
In response to this thread on Discord:
* Initial problem: https://discord.com/channels/886050993802985492/890685878068969472/962675085557235742
* Response: https://discord.com/channels/886050993802985492/890685878068969472/963111448995831838

This attempts to:
1. Simplify the initial example to just work without any setup (Fixing issues which make copy + pasting simply not work)
2. Add a section on minting with another issuer to handle that specific case, with a more complicated example that also simply works to copy + paste. (And putting the "Set the MinterAccount" instruction at the top rather than as a foot note.
 2022-04-11 09:47:28 -07:00
Dennis Dawson
8ef1fefcfd Merge branch 'master' into dd-NFT-Jira-Fixes20200322 2022-04-07 11:11:50 -07:00
Dennis Dawson
40e50a3d81 Merge pull request #1386 from XRPLF/dd-NFT-refactor 
Dd nft refactor
 2022-04-07 11:01:51 -07:00
Dennis Dawson
953f0ba387 Update variable names in TokenOffers note. 
Renaming the variable to nft_offer_index makes the distinction less critical. Ultimately we'll probably remove the note on line 45 entirely.
 2022-04-07 10:47:40 -07:00
Dennis Dawson
a0ff9fb9a9 Remove reference to lsfIssuerCanCancelOffers 
* The issuer of the token identified by the `TokenUID` field in the `NFTokenOffer` object, if the token has the `lsfIssuerCanCancelOffers` flag set.
 2022-04-06 16:53:22 -07:00
Dennis Dawson
440a28d2ca Fix NFTokenMinter 2022-04-06 16:48:23 -07:00
Dennis Dawson
b31cb160d4 Fix NFTokenSellOffer, NFTokenBuyOffer 2022-04-06 16:45:34 -07:00
Dennis Dawson
ddc0cb4cd0 Fix MintedNFTokens 2022-04-06 16:37:55 -07:00
Dennis Dawson
0879a0cdad Fix MintedNFTokens, BurnedNFTokens, NFTokenMinter 2022-04-06 16:34:26 -07:00
Jackson Mills
ebdc068767 Add missing Owner field to NFTokenBurn page (#1385) 
When burning a token which has `lsfBurnable` enabled as the original minter, the `Owner` field is required to specify which NFTokenPages to search for the NFTokenID. 

Here's the original issue which prompted this discovery: https://github.com/XRPLF/xrpl.js/issues/1947
 2022-04-06 09:43:52 -07:00
Dennis Dawson
b3b73479a3 Updates for SField changes. 
Minter -> NFTokenMinter
TokenTaxon -> NFTokenTaxon
temBAD_TRANSFER_RATE -> temBAD_NFTOKEN_TRANSFER_FEE
 2022-04-05 17:12:46 -07:00
Dennis Dawson
eac3a6923c Updates for SField changes. 
TokenID -> NFTokenID
 2022-04-05 16:49:28 -07:00
Dennis Dawson
158408c9b6 Update for SField changes 
TokenOffers -> NFTokenOffers
 2022-04-05 16:46:41 -07:00
Dennis Dawson
093d025fc7 Update for SField name changes 
TokenID -> NFTokenID
 2022-04-05 16:42:14 -07:00
Dennis Dawson
9d11aeb315 Updates for SField name changes. 
BuyOffer -> NFTokenBuyOffer
SellOffer -> NFTokenSellOffer
TokenID -> NFTokenID
 2022-04-05 16:37:33 -07:00
Dennis Dawson
cd1977b271 Update TransferFee per spec change 
Per https://ripplelabs.atlassian.net/browse/RIPD-1799, the spec changed to allow for a range of 0-50,000.
 2022-03-22 13:33:44 -07:00
Dennis Dawson
d90a86337d Add owner field description 
Per https://ripplelabs.atlassian.net/browse/RIPD-1800, when the issuer burns a NFToken with tfBurnable set the burn request must include the Owner field.
 2022-03-22 13:03:58 -07:00
Dennis Dawson
1f8dbda012 remove reference to lsfIssuerCanCancelOffers 
This feature has been removed.
 2022-03-22 12:27:00 -07:00
Dennis Dawson
9d25fd99b4 Add clarification for NFTokenOfferID response 
Per TOK-52, providing a value with a valid format can result in a success response, even though no NFTokenOffer has been removed.
 2022-03-22 11:18:36 -07:00
Rome Reginelli
be793039bb Merge pull request #1374 from XRPLF/rr-patch-token-format 
Data Types: issued currency→token
 2022-03-21 15:56:56 -07:00
mDuo13
9a09afdc69 [JA] fix links 2022-03-21 14:31:09 -07:00
Rome Reginelli
42f6d89f81 Merge pull request #1373 from XRPLF/paychan_key_deriv 
Clarify payment channel key derivation
 2022-03-21 13:44:20 -07:00
Rome Reginelli
79b4e54a6a Improve Docs for Decentralized Exchange (#1357) 
* Decentralized Exchange concept article

1st draft

* DEX: example trade diagram, offers rewording

* Offers: more rewriting/updates

* OfferCreate: Add error cases + other updates

* Known Amendments: fix tecEXPIRED, DepositPreauth

- tecEXPIRED was initially attached to the Checks amendment but got
  moved to DepositPreauth before either became released. The docs weren't
  previously updated to reflect this change
- A change to the snippets caused the DepositPreauth amendment reference
  link to get overwritten so the table links to the feature page rather than the
  amendment description. Special cases this one link.

* OfferCreate error cases: switch to table

* DEX/Offers: edits per review
 2022-03-21 08:11:13 -07:00
Rome Reginelli
7d24a34e78 Data Types: issued currency→token 2022-03-17 14:30:32 -07:00
Rome Reginelli
2945394335 Merge pull request #1358 from develoQ/translate/ja 
Translate to Japanese
 2022-03-17 11:41:59 -07:00
mDuo13
a56ad55247 Clarify payment channel key derivation 2022-03-17 11:39:33 -07:00
develoQ
773947c5e9 fix: pointed out in the review 2022-03-16 21:33:55 +09:00
Rome Reginelli
c3fb8b0fb9 Merge pull request #1362 from XRPLF/rr-accountset-tf-flags-clarification 
Clarify tf flag usage
 2022-03-11 12:55:56 -08:00
Rome Reginelli
e96138b079 AccountSet flags: asf is for newer settings 2022-03-10 15:03:38 -08:00
Rome Reginelli
08c1594455 Clarify tf flag usage 
Feedback on the "Issue a Fungible Token" tutorial mentioned that the example there sets multiple flags using a combination of asf and tf flags, but the wording here says tf flags are discouraged. That's confusing, and not really accurate: there's nothing wrong with using tf flags where applicable; it's just that the AccountSet transaction type started running out of unique bits for tf flags, so newer settings only have asf flags.
 2022-03-08 14:04:02 -08:00
Dennis Dawson
b7f6d4d362 Mark Minter not_enabled 
Co-authored-by: Rome Reginelli <rome@ripple.com>
 2022-03-07 16:42:27 -08:00
Dennis Dawson
8426821a9f Add Minter field, update asfAuthorizedMinter 2022-03-07 11:39:06 -08:00
Dennis Dawson
1fac1b8ee5 Trying these changes again. 2022-03-07 11:14:06 -08:00
develoQ
c1004005ab update payment translation to latest en content 2022-03-05 22:50:25 +09:00
develoQ
ca69f3c642 [ja] translate nftoken 2022-03-05 22:49:55 +09:00
Dennis Dawson
31b41a6c86 Correct taxon range 
"Greater than," not "Greater than or equal to."
 2022-03-03 16:57:05 -08:00
Dennis Dawson
190df654c2 gh-1305 Update MintAccount to Minter 2022-03-03 14:24:10 -08:00
Dennis Dawson
1fa9977edb Add info for setting the Minter field 
https://github.com/XRPLF/xrpl-dev-portal/issues/1305
 2022-03-03 14:21:11 -08:00
Dennis Dawson
98d457fb42 Fix links 2022-03-03 13:38:49 -08:00
Dennis Dawson
6784d9a8f7 Add links to NFTokenOffer 2022-03-03 13:36:36 -08:00
Dennis Dawson
192c41aba6 Emphasize the 2022-03-03 13:32:12 -08:00
Dennis Dawson
5da2f1f4b0 Add link to convertStringToHex utility 
Add a tip to help with the URI conversion.
 2022-03-03 12:17:27 -08:00
Dennis Dawson
30803942b1 RIPD-1796 - TokenTaxon range is 0x0 to 0xFFFF'FFFF 
Per Scott Schurr, new range is 0x0 to 0xFFFF'FFFF
 2022-03-03 12:03:44 -08:00
Rome Reginelli
af3bfd35a6 Merge pull request #1354 from XRPLF/rr-patch-hexadecimal-nftokenmint 
NFTokenMint - clarify URI is hex
 2022-03-02 17:02:28 -08:00
Rome Reginelli
0b968827ce NFTokenMint - clarify URI is hex 2022-03-02 16:46:13 -08:00
mDuo13
055ee370fe Tokens renaming: edits per peer review 2022-03-02 15:59:06 -08:00