ARCHIVE/xrpl-dev-portal
1
0
Fork 0
mirror of https://github.com/XRPLF/xrpl-dev-portal.git synced 2025-12-06 17:27:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update blog/2025/vulnerabilitydisclosurereport-bug-nov2024.md

Browse Source 
Co-authored-by: Mayukha Vadari <mvadari@ripple.com>
This commit is contained in:
Amarantha Kulkarni
2025-01-10 11:30:44 -08:00
committed by GitHub
parent 5cb21a74b5
commit e3d5209e4d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
blog/2025/vulnerabilitydisclosurereport-bug-nov2024.md
View File

@@ -40,7 +40,7 @@ The transactions and fields that caused this issue:
* `NFTokenAcceptOffer` (`NFTokenBuyOffer/NFTokenSellOffer`)
* The `CredentialID` field in several transactions (this code is not yet live)
The common factor of the vulnerable transactions was that they accepted an ID of an object (e.g. check, payment channel, NFT token offer, credential etc.) provided in the transaction and used it to lookup the object referred to by the transaction. This was expected to work, and the worst that could happen (assuming there were no bugs) was that the object found was of the wrong type, which should have been handled the same way as if the object was not found. The bug turned the “found object of unexpected type“ condition into an exception, which crashed the program.
The common factor of the vulnerable transactions was that they accepted an ID of an object of a specific type (e.g. check, payment channel, NFT token offer, credential etc.) provided in the transaction and used it to lookup the object referred to by the transaction. This was expected to work, and the worst that could happen (assuming there were no bugs) was that the object found was of the wrong type, which should have been handled the same way as if the object was not found. The bug turned the “found object of unexpected type“ condition into an exception, which crashed the program.
### Root Cause