From 08c1594455e77079d12d9c66f68749f1cd6a6e35 Mon Sep 17 00:00:00 2001 From: Rome Reginelli Date: Tue, 8 Mar 2022 14:04:02 -0800 Subject: [PATCH 1/2] Clarify tf flag usage Feedback on the "Issue a Fungible Token" tutorial mentioned that the example there sets multiple flags using a combination of asf and tf flags, but the wording here says tf flags are discouraged. That's confusing, and not really accurate: there's nothing wrong with using tf flags where applicable; it's just that the AccountSet transaction type started running out of unique bits for tf flags, so newer settings only have asf flags. --- .../transactions/transaction-types/accountset.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/references/protocol-reference/transactions/transaction-types/accountset.md b/content/references/protocol-reference/transactions/transaction-types/accountset.md index 6051633859..96a96bf4ba 100644 --- a/content/references/protocol-reference/transactions/transaction-types/accountset.md +++ b/content/references/protocol-reference/transactions/transaction-types/accountset.md @@ -58,8 +58,8 @@ You can put any domain in your account's `Domain` field. To prove that an accoun There are several options which can be either enabled or disabled for an account. Account options are represented by different types of flags depending on the situation: -* The `AccountSet` transaction type has several "AccountSet Flags" (prefixed **`asf`**) that can enable an option when passed as the `SetFlag` parameter, or disable an option when passed as the `ClearFlag` parameter. -* The `AccountSet` transaction type has several transaction flags (prefixed **`tf`**) that can be used to enable or disable specific account options when passed in the `Flags` parameter. This style is discouraged. New account options do not have corresponding transaction (`tf`) flags. +* The `AccountSet` transaction type has several "AccountSet Flags" (prefixed **`asf`**) that can enable an option when passed as the `SetFlag` parameter, or disable an option when passed as the `ClearFlag` parameter. Some options have only this style of flag. You can only enable up to one `asf` flag per transaction. +* The `AccountSet` transaction type has several transaction flags (prefixed **`tf`**) that can be used to enable or disable specific account options when passed in the `Flags` parameter. You can enable and disable a combination of settings in one transaction using multiple `tf` flags, but not all settings have `tf` flags. * The `AccountRoot` ledger object type has several ledger-state-flags (prefixed **`lsf`**) which represent the state of particular account options within a particular ledger. These settings apply until a transaction changes them. The preferred way to enable and disable Account Flags is using the `SetFlag` and `ClearFlag` parameters of an AccountSet transaction. AccountSet flags have names that begin with **`asf`**. From e96138b079dbd4d431f91aafe0205e4415557f15 Mon Sep 17 00:00:00 2001 From: Rome Reginelli Date: Thu, 10 Mar 2022 15:03:38 -0800 Subject: [PATCH 2/2] AccountSet flags: asf is for newer settings --- .../transactions/transaction-types/accountset.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/references/protocol-reference/transactions/transaction-types/accountset.md b/content/references/protocol-reference/transactions/transaction-types/accountset.md index 96a96bf4ba..9c27ea423b 100644 --- a/content/references/protocol-reference/transactions/transaction-types/accountset.md +++ b/content/references/protocol-reference/transactions/transaction-types/accountset.md @@ -58,7 +58,7 @@ You can put any domain in your account's `Domain` field. To prove that an accoun There are several options which can be either enabled or disabled for an account. Account options are represented by different types of flags depending on the situation: -* The `AccountSet` transaction type has several "AccountSet Flags" (prefixed **`asf`**) that can enable an option when passed as the `SetFlag` parameter, or disable an option when passed as the `ClearFlag` parameter. Some options have only this style of flag. You can only enable up to one `asf` flag per transaction. +* The `AccountSet` transaction type has several "AccountSet Flags" (prefixed **`asf`**) that can enable an option when passed as the `SetFlag` parameter, or disable an option when passed as the `ClearFlag` parameter. Newer options have only this style of flag. You can enable up to one `asf` flag per transaction, and disable up to one `asf` flag per transaction. * The `AccountSet` transaction type has several transaction flags (prefixed **`tf`**) that can be used to enable or disable specific account options when passed in the `Flags` parameter. You can enable and disable a combination of settings in one transaction using multiple `tf` flags, but not all settings have `tf` flags. * The `AccountRoot` ledger object type has several ledger-state-flags (prefixed **`lsf`**) which represent the state of particular account options within a particular ledger. These settings apply until a transaction changes them.