From 1442031aacd6bcab652135b06899f3ddc214f8f8 Mon Sep 17 00:00:00 2001 From: mDuo13 Date: Mon, 11 Oct 2021 15:01:54 -0700 Subject: [PATCH 1/3] Test new GH-pages deploy CI --- .github/workflows/link-checker-pr.yml | 29 +++++++++++++++++---------- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/.github/workflows/link-checker-pr.yml b/.github/workflows/link-checker-pr.yml index 4a6da29864..ad25442043 100644 --- a/.github/workflows/link-checker-pr.yml +++ b/.github/workflows/link-checker-pr.yml @@ -58,21 +58,28 @@ jobs: continue-on-error: true run: dactyl_style_checker -q > out/style_report.txt - - name: Deploy preview to gh-pages - uses: sauloxd/review-apps@v1.3.3 - with: - build-cmd: "echo 'Using existing build'" - branch: "gh-pages" - dist: "out" - slug: "pr-preview" + ## old version, deprecated + # - name: Deploy preview to gh-pages + # uses: sauloxd/review-apps@v1.3.3 + # with: + # build-cmd: "echo 'Using existing build'" + # branch: "gh-pages" + # dist: "out" + # slug: "pr-preview" - - name: Get short SHA6 - id: slug - run: echo "::set-output name=sha6::$(echo ${{ github.event.pull_request.head.sha }} | cut -c1-6)" + # new deploy system. TODO: delete folders from gh-pages when PRs are closed + - name: Deploy to gh-pages + uses: peaceiris/actions-gh-pages@v3 + with: + github_token: ${{ secrets.GITHUB_TOKEN }} + publish_dir: ./out + destination_dir: ./pr-preview/${{ github.head_ref }} - name: Summarize Output uses: unsplash/comment-on-pr@master env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: - msg: "${{ env.LINKREPORT }}\n\nPreview: https://${{ github.repository_owner }}.github.io/${{ github.event.pull_request.base.repo.name }}/pr-preview/${{ github.head_ref }}/${{steps.slug.outputs.sha6}}\n\n[Style Report](https://${{ github.repository_owner }}.github.io/${{ github.event.pull_request.base.repo.name }}/pr-preview/${{ github.head_ref }}/${{steps.slug.outputs.sha6}}/style_report.txt)" + msg: "${{ env.LINKREPORT }}\n\nPreview: https://${{ github.repository_owner }}.github.io/${{ github.event.pull_request.base.repo.name }}/pr-preview/${{ github.head_ref }}/\n\n[Style Report](https://${{ github.repository_owner }}.github.io/${{ github.event.pull_request.base.repo.name }}/pr-preview/${{ github.head_ref }}/style_report.txt)" + ## Old URLs for review-apps version: + # msg: "${{ env.LINKREPORT }}\n\nPreview: https://${{ github.repository_owner }}.github.io/${{ github.event.pull_request.base.repo.name }}/pr-preview/${{ github.head_ref }}/${{steps.slug.outputs.sha6}}\n\n[Style Report](https://${{ github.repository_owner }}.github.io/${{ github.event.pull_request.base.repo.name }}/pr-preview/${{ github.head_ref }}/${{steps.slug.outputs.sha6}}/style_report.txt)" From 30642f8a9e8744d0966ad03a18388a08d6a3da39 Mon Sep 17 00:00:00 2001 From: mDuo13 Date: Tue, 12 Oct 2021 12:48:35 -0700 Subject: [PATCH 2/3] CI: change to pull_request_target compatible comment action --- .github/workflows/link-checker-pr.yml | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/.github/workflows/link-checker-pr.yml b/.github/workflows/link-checker-pr.yml index ad25442043..54efdfa31e 100644 --- a/.github/workflows/link-checker-pr.yml +++ b/.github/workflows/link-checker-pr.yml @@ -58,15 +58,6 @@ jobs: continue-on-error: true run: dactyl_style_checker -q > out/style_report.txt - ## old version, deprecated - # - name: Deploy preview to gh-pages - # uses: sauloxd/review-apps@v1.3.3 - # with: - # build-cmd: "echo 'Using existing build'" - # branch: "gh-pages" - # dist: "out" - # slug: "pr-preview" - # new deploy system. TODO: delete folders from gh-pages when PRs are closed - name: Deploy to gh-pages uses: peaceiris/actions-gh-pages@v3 @@ -76,10 +67,8 @@ jobs: destination_dir: ./pr-preview/${{ github.head_ref }} - name: Summarize Output - uses: unsplash/comment-on-pr@master + uses: thollander/actions-comment-pull-request@v1 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: msg: "${{ env.LINKREPORT }}\n\nPreview: https://${{ github.repository_owner }}.github.io/${{ github.event.pull_request.base.repo.name }}/pr-preview/${{ github.head_ref }}/\n\n[Style Report](https://${{ github.repository_owner }}.github.io/${{ github.event.pull_request.base.repo.name }}/pr-preview/${{ github.head_ref }}/style_report.txt)" - ## Old URLs for review-apps version: - # msg: "${{ env.LINKREPORT }}\n\nPreview: https://${{ github.repository_owner }}.github.io/${{ github.event.pull_request.base.repo.name }}/pr-preview/${{ github.head_ref }}/${{steps.slug.outputs.sha6}}\n\n[Style Report](https://${{ github.repository_owner }}.github.io/${{ github.event.pull_request.base.repo.name }}/pr-preview/${{ github.head_ref }}/${{steps.slug.outputs.sha6}}/style_report.txt)" From 2c9b8326a840a7b985ddbd2dc630e23d44c4126a Mon Sep 17 00:00:00 2001 From: mDuo13 Date: Tue, 12 Oct 2021 13:32:20 -0700 Subject: [PATCH 3/3] code font io1/io2 to match AWS docs & satisfy spell-checker --- .../manage-the-rippled-server/installation/capacity-planning.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/tutorials/manage-the-rippled-server/installation/capacity-planning.md b/content/tutorials/manage-the-rippled-server/installation/capacity-planning.md index 0f0d3ba7de..6edf61d269 100644 --- a/content/tutorials/manage-the-rippled-server/installation/capacity-planning.md +++ b/content/tutorials/manage-the-rippled-server/installation/capacity-planning.md @@ -173,7 +173,7 @@ If you want to contribute to storing ledger history but you do not have enough d ##### Amazon Web Services -Amazon Web Services (AWS) is a popular virtualized hosting environment. You can run `rippled` in AWS, but if using Elastic Block Storage (EBS), only use either the io1 or io2 types, and configure them for at least 10,000 IOPS. +Amazon Web Services (AWS) is a popular virtualized hosting environment. You can run `rippled` in AWS, but if using Elastic Block Storage (EBS), only use either the `io1` or `io2` types, and configure them for at least 10,000 IOPS. Alternately, AWS instance stores (`ephemeral` storage) also has suitable performance. However, that is not durable, so data loss is to be expected under some circumstances. The `database_path` and `node_db` path should each reside on either EBS io1 or io2, or on instance storage.