From b540c9e162987f7090072ae9b5225195997745b3 Mon Sep 17 00:00:00 2001 From: rachelflynn Date: Fri, 12 Jun 2026 13:46:17 -0400 Subject: [PATCH] Addressed PR review feedback --- @l10n/ja/docs/concepts/transactions/secure-signing.md | 2 +- .../docs/infrastructure/troubleshooting/diagnosing-problems.md | 2 +- docs/concepts/transactions/secure-signing.md | 2 +- docs/tutorials/get-started/get-started-go.md | 2 +- docs/tutorials/get-started/get-started-http-websocket-apis.md | 2 +- docs/tutorials/get-started/get-started-java.md | 2 +- docs/tutorials/get-started/get-started-javascript.md | 2 +- docs/tutorials/get-started/get-started-php.md | 2 +- docs/tutorials/get-started/get-started-python.md | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/@l10n/ja/docs/concepts/transactions/secure-signing.md b/@l10n/ja/docs/concepts/transactions/secure-signing.md index dd536f7123..718bb71787 100644 --- a/@l10n/ja/docs/concepts/transactions/secure-signing.md +++ b/@l10n/ja/docs/concepts/transactions/secure-signing.md @@ -46,7 +46,7 @@ labels: 2. トランザクションに署名する必要がある場合は、`localhost`または`127.0.0.1`のサーバに接続します。シングル署名の場合は[signメソッド][]、マルチシグの場合は[sign_forメソッド][]を使用します。 - [構成ファイルの例](https://github.com/XRPLF/rippled/blob/8429dd67e60ba360da591bfa905b58a35638fda1/cfg/xrpld-example.cfg#L1050-L1073)では、ローカルループバックネットワーク上（127.0.0.1）のポート5005でJSON-RPC（HTTP）、ポート6006でWebSocket（WS）の接続をリッスンし、接続されるすべてのクライアントを管理者として扱っています。 + [構成ファイルの例](https://github.com/XRPLF/rippled/blob/develop/cfg/xrpld-example.cfg#L1477-L1494)では、ローカルループバックネットワーク上（127.0.0.1）のポート5005でJSON-RPC（HTTP）、ポート6006でWebSocket（WS）の接続をリッスンし、接続されるすべてのクライアントを管理者として扱っています。 {% admonition type="warning" name="注意" %}署名に[コマンドラインAPI](../../references/http-websocket-apis/api-conventions/request-formatting.md#コマンドライン形式)を使用する場合は、コマンドラインでないクライアントで[Websocket APIやJSON-RPC APIを使用](/docs/tutorials/get-started/get-started-http-websocket-apis.md)する場合よりもセキュリティが弱くなります。コマンドライン構文を使用すると、秘密鍵がシステムのプロセスリストで他のユーザに見える可能性があり、シェル履歴にプレーンテキスト形式でキーが保存される可能性があります。{% /admonition %} diff --git a/@l10n/ja/docs/infrastructure/troubleshooting/diagnosing-problems.md b/@l10n/ja/docs/infrastructure/troubleshooting/diagnosing-problems.md index 04ecd0ebd3..361a17031e 100644 --- a/@l10n/ja/docs/infrastructure/troubleshooting/diagnosing-problems.md +++ b/@l10n/ja/docs/infrastructure/troubleshooting/diagnosing-problems.md @@ -90,7 +90,7 @@ rippled server_info - ピアの数が0の場合、サーバがネットワークに接続できないか、またはシステムクロックが正しくない可能性があります。（サーバのクロックを同期するため、すべてのサーバで[NTP](http://www.ntp.org/)デーモンを実行することが推奨されます。） - - ピアの数が10の場合、`rippled`が[NAT](https://en.wikipedia.org/wiki/Network_address_translation)を使用したルーター経由での着信接続を受信できていない可能性があります。接続を改善するには、ルーターのファイアウォールがピアツーピア接続に使用するポート（[デフォルトでは](https://github.com/XRPLF/rippled/blob/8429dd67e60ba360da591bfa905b58a35638fda1/cfg/xrpld-example.cfg#L1065)ポート51235）を転送するように設定します。 + - ピアの数が10の場合、`rippled`が[NAT](https://en.wikipedia.org/wiki/Network_address_translation)を使用したルーター経由での着信接続を受信できていない可能性があります。接続を改善するには、ルーターのファイアウォールがピアツーピア接続に使用するポート（[デフォルトでは](https://github.com/XRPLF/rippled/blob/develop/cfg/xrpld-example.cfg#L1483-L1488)ポート51235）を転送するように設定します。 ### サーバからレスポンスがない場合 diff --git a/docs/concepts/transactions/secure-signing.md b/docs/concepts/transactions/secure-signing.md index 3c26fb6409..f76b17d103 100644 --- a/docs/concepts/transactions/secure-signing.md +++ b/docs/concepts/transactions/secure-signing.md @@ -45,7 +45,7 @@ In this configuration, you run `rippled` on the machine that generates the trans 2. When you need to sign transactions, connect to your server on `localhost` or `127.0.0.1`. Use the [sign method][] (for single signatures) or [sign_for method][] (for multi-signatures). - The [example config file](https://github.com/XRPLF/rippled/blob/8429dd67e60ba360da591bfa905b58a35638fda1/cfg/xrpld-example.cfg#L1050-L1073) listens for connections on the local loopback network (127.0.0.1), with JSON-RPC (HTTP) on port 5005 and WebSocket (WS) on port 6006, and treats all connected clients as admin. + The [example config file](https://github.com/XRPLF/rippled/blob/develop/cfg/xrpld-example.cfg#L1477-L1494) listens for connections on the local loopback network (127.0.0.1), with JSON-RPC (HTTP) on port 5005 and WebSocket (WS) on port 6006, and treats all connected clients as admin. {% admonition type="warning" name="Caution" %}Using the [commandline API](../../references/http-websocket-apis/api-conventions/request-formatting.md#commandline-format) for signatures is less secure than [using the Websocket or JSON-RPC APIs](../../tutorials/get-started/get-started-http-websocket-apis.md) through non-commandline clients. When using the commandline syntax, your secret key may be visible to other users in the system's process listing, and your shell history may save the key in plain text.{% /admonition %} diff --git a/docs/tutorials/get-started/get-started-go.md b/docs/tutorials/get-started/get-started-go.md index ff7887e2e9..a4343f56fb 100644 --- a/docs/tutorials/get-started/get-started-go.md +++ b/docs/tutorials/get-started/get-started-go.md @@ -79,7 +79,7 @@ The sample code in the previous section shows you how to connect to the Testnet, } ``` - See the example [core server config file](https://github.com/XRPLF/rippled/blob/c0a0b79d2d483b318ce1d82e526bd53df83a4a2c/cfg/xrpld-example.cfg#L1562) for more information about default values. + See the example [core server config file](https://github.com/XRPLF/rippled/blob/develop/cfg/xrpld-example.cfg#L1469) for more information about default values. - By using one of the available [public servers][]: diff --git a/docs/tutorials/get-started/get-started-http-websocket-apis.md b/docs/tutorials/get-started/get-started-http-websocket-apis.md index d3459c81df..abefdfeb89 100644 --- a/docs/tutorials/get-started/get-started-http-websocket-apis.md +++ b/docs/tutorials/get-started/get-started-http-websocket-apis.md @@ -30,7 +30,7 @@ Both APIs can be served unencrypted (`http://` and `ws://`) or encrypted using T The API methods are divided into [Public Methods](../../references/http-websocket-apis/public-api-methods/index.md) and [Admin Methods](../../references/http-websocket-apis/admin-api-methods/index.md) so that organizations can offer public servers for the benefit of the community. To access admin methods, or admin functionality of public methods, you must connect to the API on a **port and IP address marked as admin** in the server's config file. -The [example config file](https://github.com/XRPLF/rippled/blob/f00f263852c472938bf8e993e26c7f96f435935c/cfg/xrpld-example.cfg#L1154-L1179) listens for connections on the local loopback network (127.0.0.1), with JSON-RPC (HTTP) on port 5005 and WebSocket (WS) on port 6006, and treats all connected clients as admin. +The [example config file](https://github.com/XRPLF/rippled/blob/develop/cfg/xrpld-example.cfg#L1477-L1494) listens for connections on the local loopback network (127.0.0.1), with JSON-RPC (HTTP) on port 5005 and WebSocket (WS) on port 6006, and treats all connected clients as admin. ## WebSocket API diff --git a/docs/tutorials/get-started/get-started-java.md b/docs/tutorials/get-started/get-started-java.md index c1cfac8666..ebd8bf735e 100644 --- a/docs/tutorials/get-started/get-started-java.md +++ b/docs/tutorials/get-started/get-started-java.md @@ -104,7 +104,7 @@ The sample code in the previous section shows you how to connect to the Testnet, XrplClient xrplClient = new XrplClient(rippledUrl); ``` - See the example [core server config file](https://github.com/XRPLF/rippled/blob/c0a0b79d2d483b318ce1d82e526bd53df83a4a2c/cfg/xrpld-example.cfg#L1562) for more information about default values. + See the example [core server config file](https://github.com/XRPLF/rippled/blob/develop/cfg/xrpld-example.cfg#L1469) for more information about default values. * By using one of the available [public servers][]: diff --git a/docs/tutorials/get-started/get-started-javascript.md b/docs/tutorials/get-started/get-started-javascript.md index 1f35a646ed..aa14e7add8 100644 --- a/docs/tutorials/get-started/get-started-javascript.md +++ b/docs/tutorials/get-started/get-started-javascript.md @@ -115,7 +115,7 @@ The sample code shows you how to connect to the Testnet, which is one of the ava await client.connect() ``` - See the example [core server config file](https://github.com/XRPLF/rippled/blob/c0a0b79d2d483b318ce1d82e526bd53df83a4a2c/cfg/xrpld-example.cfg#L1562) for more information about default values. + See the example [core server config file](https://github.com/XRPLF/rippled/blob/develop/cfg/xrpld-example.cfg#L1469) for more information about default values. - By using one of the available [public servers][]: diff --git a/docs/tutorials/get-started/get-started-php.md b/docs/tutorials/get-started/get-started-php.md index 563106c7c4..45f5d8b1f6 100644 --- a/docs/tutorials/get-started/get-started-php.md +++ b/docs/tutorials/get-started/get-started-php.md @@ -86,7 +86,7 @@ The sample code in the previous section shows you how to connect to the Testnet, $client = new JsonRpcClient("LOCAL_JSON_RPC_URL"); ``` - See the example [core server config file](https://github.com/XRPLF/rippled/blob/c0a0b79d2d483b318ce1d82e526bd53df83a4a2c/cfg/xrpld-example.cfg#L1562) for more information about default values. + See the example [core server config file](https://github.com/XRPLF/rippled/blob/develop/cfg/xrpld-example.cfg#L1469) for more information about default values. * By using one of the available [public servers][]: diff --git a/docs/tutorials/get-started/get-started-python.md b/docs/tutorials/get-started/get-started-python.md index db403e510c..d0b86e5e27 100644 --- a/docs/tutorials/get-started/get-started-python.md +++ b/docs/tutorials/get-started/get-started-python.md @@ -97,7 +97,7 @@ The sample code in the previous section shows you how to connect to the Testnet, client = JsonRpcClient(JSON_RPC_URL) ``` - See the example [core server config file](https://github.com/XRPLF/rippled/blob/c0a0b79d2d483b318ce1d82e526bd53df83a4a2c/cfg/xrpld-example.cfg#L1562) for more information about default values. + See the example [core server config file](https://github.com/XRPLF/rippled/blob/develop/cfg/xrpld-example.cfg#L1469) for more information about default values. - By using one of the available [public servers][]: