From 762d48e43f153f03e4119103bc766b27ac8de4fe Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 1 Jul 2025 10:27:19 +0000 Subject: [PATCH 1/3] Bump electron in /_code-samples/build-a-desktop-wallet/js Bumps [electron](https://github.com/electron/electron) from 22.3.25 to 28.3.2. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md) - [Commits](https://github.com/electron/electron/compare/v22.3.25...v28.3.2) --- updated-dependencies: - dependency-name: electron dependency-version: 28.3.2 dependency-type: direct:development ... Signed-off-by: dependabot[bot] --- _code-samples/build-a-desktop-wallet/js/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_code-samples/build-a-desktop-wallet/js/package.json b/_code-samples/build-a-desktop-wallet/js/package.json index 009036e61a..6e742dbf62 100644 --- a/_code-samples/build-a-desktop-wallet/js/package.json +++ b/_code-samples/build-a-desktop-wallet/js/package.json @@ -23,6 +23,6 @@ "xrpl": "^4.0.0" }, "devDependencies": { - "electron": "22.3.25" + "electron": "28.3.2" } } From c873acacb7743580a06ea2d255be8e7876695b37 Mon Sep 17 00:00:00 2001 From: mDuo13 Date: Tue, 15 Jul 2025 12:33:05 -0700 Subject: [PATCH 2/3] Update desktop wallet for xrpl.js 4.x+ --- .../build-a-desktop-wallet/js/library/4_helpers.js | 10 +++++----- .../build-a-desktop-wallet/js/library/8_helpers.js | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/_code-samples/build-a-desktop-wallet/js/library/4_helpers.js b/_code-samples/build-a-desktop-wallet/js/library/4_helpers.js index b3e344454a..04a65a5f9f 100644 --- a/_code-samples/build-a-desktop-wallet/js/library/4_helpers.js +++ b/_code-samples/build-a-desktop-wallet/js/library/4_helpers.js @@ -8,12 +8,12 @@ const prepareTxData = (transactions) => { } return { - confirmed: transaction.tx.date, - type: transaction.tx.TransactionType, - from: transaction.tx.Account, - to: transaction.tx.Destination ?? "-", + confirmed: transaction.close_time_iso, + type: transaction.tx_json.TransactionType, + from: transaction.tx_json.Account, + to: transaction.tx_json.Destination ?? "-", value: tx_value, - hash: transaction.tx.hash + hash: transaction.hash } }) } diff --git a/_code-samples/build-a-desktop-wallet/js/library/8_helpers.js b/_code-samples/build-a-desktop-wallet/js/library/8_helpers.js index 38ed7d32ed..30d39344af 100644 --- a/_code-samples/build-a-desktop-wallet/js/library/8_helpers.js +++ b/_code-samples/build-a-desktop-wallet/js/library/8_helpers.js @@ -99,9 +99,9 @@ async function verify(accountAddress, client) { try { const response = await client.request(request) return await checkDestination(response.result.account_data) - } catch { + } catch (err) { return { - domain: 'domain', + domain: '', verified: false } } From 1620a4e1cfb229b95966aa0d5573070267da9577 Mon Sep 17 00:00:00 2001 From: mDuo13 Date: Tue, 15 Jul 2025 13:04:01 -0700 Subject: [PATCH 3/3] Fix desktop wallet (js) deps & API v2 compatibility --- _code-samples/build-a-desktop-wallet/js/4-tx-history/index.js | 2 +- _code-samples/build-a-desktop-wallet/js/library/5_helpers.js | 2 +- _code-samples/build-a-desktop-wallet/js/package.json | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/_code-samples/build-a-desktop-wallet/js/4-tx-history/index.js b/_code-samples/build-a-desktop-wallet/js/4-tx-history/index.js index d879bbb3c9..39d038f6b0 100644 --- a/_code-samples/build-a-desktop-wallet/js/4-tx-history/index.js +++ b/_code-samples/build-a-desktop-wallet/js/4-tx-history/index.js @@ -56,7 +56,7 @@ const main = async () => { const accountData = prepareAccountData(accountInfoResponse.result.account_data) appWindow.webContents.send('update-account-data', accountData) - const transactions = prepareTxData([{tx: transaction.transaction}]) + const transactions = prepareTxData([transaction]) appWindow.webContents.send('update-transaction-data', transactions) }) diff --git a/_code-samples/build-a-desktop-wallet/js/library/5_helpers.js b/_code-samples/build-a-desktop-wallet/js/library/5_helpers.js index 5565e60c07..2f6fb55023 100644 --- a/_code-samples/build-a-desktop-wallet/js/library/5_helpers.js +++ b/_code-samples/build-a-desktop-wallet/js/library/5_helpers.js @@ -68,7 +68,7 @@ const subscribe = async (client, wallet, appWindow) => { const accountData = prepareAccountData(accountInfoResponse.result.account_data) appWindow.webContents.send('update-account-data', accountData) - const transactions = prepareTxData([{tx: transaction.transaction}]) + const transactions = prepareTxData([transaction]) appWindow.webContents.send('update-transaction-data', transactions) }) } diff --git a/_code-samples/build-a-desktop-wallet/js/package.json b/_code-samples/build-a-desktop-wallet/js/package.json index 6e742dbf62..ff5ac0b9e3 100644 --- a/_code-samples/build-a-desktop-wallet/js/package.json +++ b/_code-samples/build-a-desktop-wallet/js/package.json @@ -15,12 +15,12 @@ }, "dependencies": { "async": "^3.2.4", - "fernet": "^0.4.0", + "fernet": "=0.3.3", "node-fetch": "^2.6.9", "pbkdf2-hmac": "^1.1.0", "open": "^8.4.0", "toml": "^3.0.0", - "xrpl": "^4.0.0" + "xrpl": "^4.3.0" }, "devDependencies": { "electron": "28.3.2"