ARCHIVE/xrpl-dev-portal
1
0
Fork 0
mirror of https://github.com/XRPLF/xrpl-dev-portal.git synced 2025-11-20 19:55:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

xrpl.js 2.0: address feedback, fix many TODOs

Browse Source
This commit is contained in:
mDuo13
2021-10-19 18:55:06 -07:00
parent e70926c758
commit 7cff4596cc
16 changed files with 154 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
assets/js/rpc-tool.js
View File

@@ -11,9 +11,7 @@ jQuery(function ($) {
api.on('connected', () => {
const target = location.hash.slice(1);
// TODO: switch back to isValidAddress
if (api.isValidClassicAddress(target) ||
api.isValidXAddress(target) ||
if (api.isValidAddress(target)
reTxId.exec(target) ||
reLedgerSeq.exec(target)) {
$('#target').val(target);
@@ -47,8 +45,7 @@ jQuery(function ($) {
$("#permalink").attr("href", locationWithoutHash + "#" + target);
$("#explorerlink").attr("href", ""); // Reset
// TODO: switch back to isValidAddress()
if (api.isValidClassicAddress(target)) { // Account -------------------------------
if (api.isValidAddress(target)) { // Account -------------------------------
let account = target;
previousMarkers = []
nextMarker = undefined
@@ -221,7 +218,7 @@ jQuery(function ($) {
if (err.error === "remoteError" &&
"object" === typeof err.remote)
{
// TODO: is this "remoteError" thing still valid with ripple-lib 1.x+?
// TODO: is this "remoteError" thing still valid with xrpl.js 2.x+?
err = err.remote;
}