From 7cb8931fdf87892f3c194496116fcf918c0cbba9 Mon Sep 17 00:00:00 2001 From: Oliver Eggert Date: Tue, 23 Jun 2026 17:04:40 -0700 Subject: [PATCH] add reviewer fixes --- .../payment-channel-methods/channel_verify.md | 4 +--- @l10n/ja/docs/references/protocol/binary-format.md | 4 ++-- .../protocol/transactions/types/xchainaccountcreatecommit.md | 2 +- .../transactions/types/xchainaddaccountcreateattestation.md | 2 +- .../protocol/transactions/types/xchainaddclaimattestation.md | 2 +- .../references/protocol/transactions/types/xchainclaim.md | 2 +- .../references/protocol/transactions/types/xchaincommit.md | 2 +- .../protocol/transactions/types/xchaincreatebridge.md | 2 +- .../protocol/transactions/types/xchaincreateclaimid.md | 2 +- .../protocol/transactions/types/xchainmodifybridge.md | 2 +- .../payment-channel-methods/channel_verify.md | 2 -- .../protocol/transactions/types/xchainaccountcreatecommit.md | 2 +- .../transactions/types/xchainaddaccountcreateattestation.md | 2 +- .../protocol/transactions/types/xchainaddclaimattestation.md | 2 +- docs/references/protocol/transactions/types/xchainclaim.md | 2 +- docs/references/protocol/transactions/types/xchaincommit.md | 2 +- .../protocol/transactions/types/xchaincreatebridge.md | 2 +- .../protocol/transactions/types/xchaincreateclaimid.md | 2 +- .../protocol/transactions/types/xchainmodifybridge.md | 2 +- 19 files changed, 19 insertions(+), 23 deletions(-) diff --git a/@l10n/ja/docs/references/http-websocket-apis/public-api-methods/payment-channel-methods/channel_verify.md b/@l10n/ja/docs/references/http-websocket-apis/public-api-methods/payment-channel-methods/channel_verify.md index f2cce8b2b2..b970b01a9a 100644 --- a/@l10n/ja/docs/references/http-websocket-apis/public-api-methods/payment-channel-methods/channel_verify.md +++ b/@l10n/ja/docs/references/http-websocket-apis/public-api-methods/payment-channel-methods/channel_verify.md @@ -7,9 +7,7 @@ labels: - Payment Channel --- # channel_verify -[[ソース]](https://github.com/XRPLF/rippled/blob/cdee9a675c0e571b5c86dc01550a554a42e6f85c/src/xrpld/rpc/handlers/ChannelVerify.cpp#L30 "Source") - -_([PayChan Amendment][]が有効になっている必要があります。{% badge href="https://github.com/XRPLF/rippled/releases/tag/0.33.0" %}新規: rippled 0.33.0{% /badge %})_ +{% source-link path="src/xrpld/rpc/handlers/ChannelVerify.cpp" /%} `channel_verify`メソッドは、特定額のXRPをPayment Channelから清算するときに使用できる署名の有効性を検証します。 diff --git a/@l10n/ja/docs/references/protocol/binary-format.md b/@l10n/ja/docs/references/protocol/binary-format.md index a0446dde50..d52e287ff9 100644 --- a/@l10n/ja/docs/references/protocol/binary-format.md +++ b/@l10n/ja/docs/references/protocol/binary-format.md @@ -157,7 +157,7 @@ curated_anchors: 各フィールドタイプには任意のタイプコードが含まれており、番号が小さいコードから最初にソートされます。これらのコードは{% source-link name="SField.h" path="include/xrpl/protocol/SField.h#L60-L98" /%}で定義されています。 -たとえば {% source-link name="UInt32のタイプコードが2である" path="include/xrpl/protocol/SField.h#L67" /%}ので、すべてのUInt32フィールドは、すべての{% source-link name="Amountフィールド(タイプコード6)" path="include/xrpl/protocol/SField.h#L71" /%}よりも前に位置します。 +たとえば {% source-link name="UInt32のタイプコードが2である" path="include/xrpl/protocol/SField.h#L48" /%}ので、すべてのUInt32フィールドは、すべての{% source-link name="Amountフィールド(タイプコード6)" path="include/xrpl/protocol/SField.h#L52" /%}よりも前に位置します。 [定義ファイル](#定義ファイル)には、`TYPES`マップの各タイプのタイプコードがリストされています。 @@ -165,7 +165,7 @@ curated_anchors: 各フィールドにはフィールドコードが含まれています。フィールドコードは、同じタイプのフィールドをソートするときに使用され、番号が小さいコードが最初になるようにソートされます。これらのフィールドは{% source-link name="sfields/macro" path="include/xrpl/protocol/detail/sfields.macro" /%}で定義されています。 -たとえば[Paymentトランザクション][]の`Account`フィールドの{% source-link name="ソートコードが1である" path="include/xrpl/protocol/detail/sfields.macro#L269" /%}場合、このフィールドは`Destination`フィールド({% source-link name="ソートコードが3である" path="include/xrpl/protocol/detail/sfields.macro#L271" /%}フィールド)よりも前に位置します。 +たとえば[Paymentトランザクション][]の`Account`フィールドの{% source-link name="ソートコードが1である" path="include/xrpl/protocol/detail/sfields.macro#L304" /%}場合、このフィールドは`Destination`フィールド({% source-link name="ソートコードが3である" path="include/xrpl/protocol/detail/sfields.macro#L306" /%}フィールド)よりも前に位置します。 フィールドコードは異なるフィールドタイプのフィールドで再利用されますが、同じタイプのフィールドに同じフィールドコードが含まれることはありません。タイプコードとフィールドコードを組み合わせると、フィールドの一意の[フィールドID](#フィールドid)になります。 diff --git a/@l10n/ja/docs/references/protocol/transactions/types/xchainaccountcreatecommit.md b/@l10n/ja/docs/references/protocol/transactions/types/xchainaccountcreatecommit.md index b3dc639975..998f123c82 100644 --- a/@l10n/ja/docs/references/protocol/transactions/types/xchainaccountcreatecommit.md +++ b/@l10n/ja/docs/references/protocol/transactions/types/xchainaccountcreatecommit.md @@ -8,7 +8,7 @@ status: not_enabled txIcon: create --- # XChainAccountCreateCommit -{% source-link path="src/libxrpl/protocol/TxFormats.cpp#L466-L474" /%} +{% source-link path="include/xrpl/tx/transactors/bridge/XChainBridge.h#L314-L345" /%} 発行チェーンにトランザクションを送信するために、Witnessサーバ用の新しいアカウントを作成します。このトランザクションはXRP-XRPブリッジにのみ使用できます。 diff --git a/@l10n/ja/docs/references/protocol/transactions/types/xchainaddaccountcreateattestation.md b/@l10n/ja/docs/references/protocol/transactions/types/xchainaddaccountcreateattestation.md index a87953e060..44a1e054e1 100644 --- a/@l10n/ja/docs/references/protocol/transactions/types/xchainaddaccountcreateattestation.md +++ b/@l10n/ja/docs/references/protocol/transactions/types/xchainaddaccountcreateattestation.md @@ -8,7 +8,7 @@ status: not_enabled txIcon: create --- # XChainAddAccountCreateAttestation -{% source-link path="src/libxrpl/protocol/TxFormats.cpp#L447-L464" /%} +{% source-link path="include/xrpl/tx/transactors/bridge/XChainBridge.h#L255-L287" /%} `XChainAccountCreateCommit`トランザクションがもう一方のチェーンで発生したというWitnessサーバからの証明を提示します。 diff --git a/@l10n/ja/docs/references/protocol/transactions/types/xchainaddclaimattestation.md b/@l10n/ja/docs/references/protocol/transactions/types/xchainaddclaimattestation.md index 6fb9812e19..0c0a03aa90 100644 --- a/@l10n/ja/docs/references/protocol/transactions/types/xchainaddclaimattestation.md +++ b/@l10n/ja/docs/references/protocol/transactions/types/xchainaddclaimattestation.md @@ -8,7 +8,7 @@ status: not_enabled txIcon: modify --- # XChainAddClaimAttestation -{% source-link path="src/libxrpl/protocol/TxFormats.cpp#L429-L445" /%} +{% source-link path="include/xrpl/tx/transactors/bridge/XChainBridge.h#L221-L253" /%} `XChainCommit`トランザクションを証明するWitnessサーバの署名を提供します。 diff --git a/@l10n/ja/docs/references/protocol/transactions/types/xchainclaim.md b/@l10n/ja/docs/references/protocol/transactions/types/xchainclaim.md index bfa14324c7..58ec067500 100644 --- a/@l10n/ja/docs/references/protocol/transactions/types/xchainclaim.md +++ b/@l10n/ja/docs/references/protocol/transactions/types/xchainclaim.md @@ -8,7 +8,7 @@ status: not_enabled txIcon: finish --- # XChainClaim -{% source-link path="src/libxrpl/protocol/TxFormats.cpp#L418-L427" /%} +{% source-link path="include/xrpl/tx/transactors/bridge/XChainBridge.h#L94-L126" /%} `XChainClaim`トランザクションはクロスチェーンでの価値の移転を完了させます。`XChainClaim`トランザクションにより、ユーザは送信元チェーンでロックされた価値と同等の価値を送信先チェーンで請求することができます。ユーザは、送金元チェーンでロックされた価値に関連付けられたクロスチェーン請求ID(`Account`フィールド)を所有している場合にのみ、その価値を請求することができます。ユーザは誰にでも資金を送ることができます(`Destination`フィールド)。このトランザクションが必要になるのは`XChainCommit`トランザクションで`OtherChainDestination`が指定されていない場合、または自動送金で何か問題が発生した場合のみです。 diff --git a/@l10n/ja/docs/references/protocol/transactions/types/xchaincommit.md b/@l10n/ja/docs/references/protocol/transactions/types/xchaincommit.md index 2143a98b34..b649565b89 100644 --- a/@l10n/ja/docs/references/protocol/transactions/types/xchaincommit.md +++ b/@l10n/ja/docs/references/protocol/transactions/types/xchaincommit.md @@ -8,7 +8,7 @@ status: not_enabled txIcon: send --- # XChainCommit -{% source-link path="src/libxrpl/protocol/TxFormats.cpp#L408-L416" /%} +{% source-link path="include/xrpl/tx/transactors/bridge/XChainBridge.h#L133-L167" /%} クロスチェーン送金の2番目のステップです。`XChainCommit`は発行チェーンでラップできるようにロックチェーンで資産を保管したり、ロックチェーンで返却できるように発行チェーンでラップされた資産をバーンしたりします。 diff --git a/@l10n/ja/docs/references/protocol/transactions/types/xchaincreatebridge.md b/@l10n/ja/docs/references/protocol/transactions/types/xchaincreatebridge.md index 4df1d82939..9fa471423c 100644 --- a/@l10n/ja/docs/references/protocol/transactions/types/xchaincreatebridge.md +++ b/@l10n/ja/docs/references/protocol/transactions/types/xchaincreatebridge.md @@ -8,7 +8,7 @@ status: not_enabled txIcon: create --- # XChainCreateBridge -{% source-link path="src/libxrpl/protocol/TxFormats.cpp#L381-L388" /%} +{% source-link path="include/xrpl/tx/transactors/bridge/XChainBridge.h#L12-L43" /%} 新しい`Bridge`レジャーオブジェクトを作成し、トランザクショ ンが送信されたチェーン上に新しいクロスチェーンブリッジの入り口を定義します。これにはブリッジのドアアカウントと資産に関する情報が含まれます。 diff --git a/@l10n/ja/docs/references/protocol/transactions/types/xchaincreateclaimid.md b/@l10n/ja/docs/references/protocol/transactions/types/xchaincreateclaimid.md index 8686e1c2b5..edc0f164c4 100644 --- a/@l10n/ja/docs/references/protocol/transactions/types/xchaincreateclaimid.md +++ b/@l10n/ja/docs/references/protocol/transactions/types/xchaincreateclaimid.md @@ -8,7 +8,7 @@ status: not_enabled txIcon: create --- # XChainCreateClaimID -{% source-link path="src/libxrpl/protocol/TxFormats.cpp#L399-L406" /%} +{% source-link path="include/xrpl/tx/transactors/bridge/XChainBridge.h#L179-L210" /%} `XChainCreateClaimID`トランザクションはクロスチェーン送金に使われる新しいクロスチェーン請求IDを作成します。クロスチェーン請求IDは*1つの*クロスチェーン送金を表します。 diff --git a/@l10n/ja/docs/references/protocol/transactions/types/xchainmodifybridge.md b/@l10n/ja/docs/references/protocol/transactions/types/xchainmodifybridge.md index c328d08460..83d384d95a 100644 --- a/@l10n/ja/docs/references/protocol/transactions/types/xchainmodifybridge.md +++ b/@l10n/ja/docs/references/protocol/transactions/types/xchainmodifybridge.md @@ -8,7 +8,7 @@ status: not_enabled txIcon: modify --- # XChainModifyBridge -{% source-link path="src/libxrpl/protocol/TxFormats.cpp#L390-L397" /%} +{% source-link path="include/xrpl/tx/transactors/bridge/XChainBridge.h#L45-L79" /%} `XChainModifyBridge`トランザクションでは、ブリッジ管理者がブリッジの設定を変更することができます。変更できるのは`SignatureReward`と`MinAccountCreateAmount`だけです。 diff --git a/docs/references/http-websocket-apis/public-api-methods/payment-channel-methods/channel_verify.md b/docs/references/http-websocket-apis/public-api-methods/payment-channel-methods/channel_verify.md index 29731de742..4394952cc9 100644 --- a/docs/references/http-websocket-apis/public-api-methods/payment-channel-methods/channel_verify.md +++ b/docs/references/http-websocket-apis/public-api-methods/payment-channel-methods/channel_verify.md @@ -9,8 +9,6 @@ labels: The `channel_verify` method checks the validity of a signature that can be used to redeem a specific amount of XRP from a payment channel. -{% amendment-disclaimer name="PayChan" /%} - ## Request Format An example of the request format: diff --git a/docs/references/protocol/transactions/types/xchainaccountcreatecommit.md b/docs/references/protocol/transactions/types/xchainaccountcreatecommit.md index e109c05971..c7afab43f1 100644 --- a/docs/references/protocol/transactions/types/xchainaccountcreatecommit.md +++ b/docs/references/protocol/transactions/types/xchainaccountcreatecommit.md @@ -8,7 +8,7 @@ status: not_enabled txIcon: create --- # XChainAccountCreateCommit -{% source-link path="src/libxrpl/tx/transactors/bridge/XChainBridge.cpp" /%} +{% source-link path="include/xrpl/tx/transactors/bridge/XChainBridge.h#L314-L345" /%} Create a new account for a [witness server](../../../../concepts/xrpl-sidechains/witness-servers.md) to submit transactions on an issuing chain. This transaction can only be used for XRP-XRP bridges. diff --git a/docs/references/protocol/transactions/types/xchainaddaccountcreateattestation.md b/docs/references/protocol/transactions/types/xchainaddaccountcreateattestation.md index 9387b3ef0a..f1a2b6b1e6 100644 --- a/docs/references/protocol/transactions/types/xchainaddaccountcreateattestation.md +++ b/docs/references/protocol/transactions/types/xchainaddaccountcreateattestation.md @@ -8,7 +8,7 @@ status: not_enabled txIcon: create --- # XChainAddAccountCreateAttestation -{% source-link path="src/libxrpl/tx/transactors/bridge/XChainBridge.cpp" /%} +{% source-link path="include/xrpl/tx/transactors/bridge/XChainBridge.h#L255-L287" /%} Provide an attestation from a [witness server](../../../../concepts/xrpl-sidechains/witness-servers.md) that an `XChainAccountCreateCommit` transaction occurred on the other chain. diff --git a/docs/references/protocol/transactions/types/xchainaddclaimattestation.md b/docs/references/protocol/transactions/types/xchainaddclaimattestation.md index e75e07d5f5..cf36895bad 100644 --- a/docs/references/protocol/transactions/types/xchainaddclaimattestation.md +++ b/docs/references/protocol/transactions/types/xchainaddclaimattestation.md @@ -8,7 +8,7 @@ status: not_enabled txIcon: modify --- # XChainAddClaimAttestation -{% source-link path="src/libxrpl/tx/transactors/bridge/XChainBridge.cpp" /%} +{% source-link path="include/xrpl/tx/transactors/bridge/XChainBridge.h#L221-L253" /%} Provide proof from a [witness server](../../../../concepts/xrpl-sidechains/witness-servers.md) attesting to an `XChainCommit` transaction. diff --git a/docs/references/protocol/transactions/types/xchainclaim.md b/docs/references/protocol/transactions/types/xchainclaim.md index 2395ffdb27..f3bf81c6c0 100644 --- a/docs/references/protocol/transactions/types/xchainclaim.md +++ b/docs/references/protocol/transactions/types/xchainclaim.md @@ -8,7 +8,7 @@ status: not_enabled txIcon: finish --- # XChainClaim -{% source-link path="src/libxrpl/tx/transactors/bridge/XChainBridge.cpp" /%} +{% source-link path="include/xrpl/tx/transactors/bridge/XChainBridge.h#L94-L126" /%} Complete a [cross-chain transfer of value](../../../../concepts/xrpl-sidechains/cross-chain-bridges.md). It allows a user to claim the value on the destination chain - the equivalent of the value locked on the source chain. A user can only claim the value if they own the cross-chain claim ID associated with the value locked on the source chain (the `Account` field). The user can send the funds to anyone (the `Destination` field). This transaction is only needed if an `OtherChainDestination` isn't specified in the `XChainCommit` transaction, or if something goes wrong with the automatic transfer of funds. diff --git a/docs/references/protocol/transactions/types/xchaincommit.md b/docs/references/protocol/transactions/types/xchaincommit.md index 9a78db440b..ace9f67fba 100644 --- a/docs/references/protocol/transactions/types/xchaincommit.md +++ b/docs/references/protocol/transactions/types/xchaincommit.md @@ -8,7 +8,7 @@ status: not_enabled txIcon: send --- # XChainCommit -{% source-link path="src/libxrpl/tx/transactors/bridge/XChainBridge.cpp" /%} +{% source-link path="include/xrpl/tx/transactors/bridge/XChainBridge.h#L133-L167" /%} Do the second step in a [cross-chain transfer](../../../../concepts/xrpl-sidechains/cross-chain-bridges.md). This transaction has two modes: diff --git a/docs/references/protocol/transactions/types/xchaincreatebridge.md b/docs/references/protocol/transactions/types/xchaincreatebridge.md index 81cef8266b..70c448dd6b 100644 --- a/docs/references/protocol/transactions/types/xchaincreatebridge.md +++ b/docs/references/protocol/transactions/types/xchaincreatebridge.md @@ -8,7 +8,7 @@ status: not_enabled txIcon: create --- # XChainCreateBridge -{% source-link path="src/libxrpl/tx/transactors/bridge/XChainBridge.cpp" /%} +{% source-link path="include/xrpl/tx/transactors/bridge/XChainBridge.h#L12-L43" /%} Create a new [cross-chain bridge](../../../../concepts/xrpl-sidechains/cross-chain-bridges.md) on the chain that the transaction is submitted on, providing information about door accounts and assets for the bridge. diff --git a/docs/references/protocol/transactions/types/xchaincreateclaimid.md b/docs/references/protocol/transactions/types/xchaincreateclaimid.md index 7b32c884f8..366371798e 100644 --- a/docs/references/protocol/transactions/types/xchaincreateclaimid.md +++ b/docs/references/protocol/transactions/types/xchaincreateclaimid.md @@ -8,7 +8,7 @@ status: not_enabled txIcon: create --- # XChainCreateClaimID -{% source-link path="src/libxrpl/tx/transactors/bridge/XChainBridge.cpp" /%} +{% source-link path="include/xrpl/tx/transactors/bridge/XChainBridge.h#L179-L210" /%} Create a new cross-chain claim ID that is used for a [cross-chain transfer](../../../../concepts/xrpl-sidechains/cross-chain-bridges.md). A cross-chain claim ID represents *one* cross-chain transfer of value. diff --git a/docs/references/protocol/transactions/types/xchainmodifybridge.md b/docs/references/protocol/transactions/types/xchainmodifybridge.md index f8a8a5621e..1740d9daa6 100644 --- a/docs/references/protocol/transactions/types/xchainmodifybridge.md +++ b/docs/references/protocol/transactions/types/xchainmodifybridge.md @@ -8,7 +8,7 @@ status: not_enabled txIcon: modify --- # XChainModifyBridge -{% source-link path="src/libxrpl/tx/transactors/bridge/XChainBridge.cpp" /%} +{% source-link path="include/xrpl/tx/transactors/bridge/XChainBridge.h#L45-L79" /%} Modify the parameters of a [cross-chain bridge](../../../../concepts/xrpl-sidechains/cross-chain-bridges.md). Only managers can send this transaction, and they can only change the `SignatureReward` and the `MinAccountCreateAmount`.